repquota not working correctly with xfs

Bug #1044516 reported by Chris J Arges
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
quota
Fix Released
Unknown
quota (Ubuntu)
Fix Released
Medium
Unassigned
Precise
Fix Released
Medium
Unassigned
Quantal
Fix Released
Medium
Unassigned

Bug Description

SRU Justification:
[IMPACT]
 * When using quota on systems with XFS on precise/quantal only the root quota is reported.
 * This means that users of XFS cannot use repquota, as it does not return reliable results.

[TESTCASE]
 * See bug below.

[Regression Potential]
 * This patch only affects an XFS code path.
 * This patch is already part of quota 4.01-1. It would be important to test on XFS and non-XFS partitions to see if functionality is as expected.
 * This bug worked correctly in Lucid, and appears to be a regression in the upstream package between Lucid and Precise.

--

Description of the problem:

The command 'repquota' is not working properly with an XFS file system on 12.04 and later. It only reports root's quota. The same command worked well with 10.04, and the other quota commands (xfs_quota) seem to work properly as well.

Version affected: 12.04 LTS:

ii quota 4.00-3 implementation of the disk quota system
ii xfsprogs 3.1.7 Utilities for managing the XFS filesystem

How reproducible is the problem? Always.

Steps to Reproduce:

1. Create a XFS partition.
2. Create an entry in fstab such as:

/dev/vdb1 /mnt xfs defaults,usrquota,grpquota 1 1

3. Run and compare the output of the following commands on 10.04 LTS , 12.04 LTS and 12.10.

$ sudo mount /mnt
$ sudo mkdir -p /mnt/test
$ sudo chown $USER:$GROUP /mnt/test
$ sudo repquota /mnt
$ sudo xfs_quota -x -c report /mnt

This appears to be a regression.

Revision history for this message
Chris J Arges (arges) wrote :

There is already a debian bug here:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=685356

I've attached a patch based on the suggestion there, and can confirm this does fix the issue:
http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=16;filename=quota_4.00-4ubuntu1.debdiff;att=1;bug=685356

Changed in quota (Ubuntu Precise):
importance: Undecided → Medium
assignee: nobody → Chris J Arges (christopherarges)
Changed in quota (Ubuntu Quantal):
assignee: nobody → Chris J Arges (christopherarges)
Changed in quota (Ubuntu Precise):
status: New → In Progress
Changed in quota (Ubuntu Quantal):
status: New → In Progress
Changed in quota:
status: Unknown → Confirmed
Changed in quota:
status: Confirmed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote :

This is fixed in quota 4.01-1. I will backport the changes for precise/quantal.

Revision history for this message
Chris J Arges (arges) wrote :
Revision history for this message
Chris J Arges (arges) wrote :
Chris J Arges (arges)
description: updated
Revision history for this message
Daniel Holbach (dholbach) wrote :

Can you please update the changelog entries of both patches to go to 'precise-proposed' and 'quantal'?

Revision history for this message
Chris J Arges (arges) wrote :
Revision history for this message
Chris J Arges (arges) wrote :
Revision history for this message
Chris J Arges (arges) wrote :

There ya go.

Michael Terry (mterry)
description: updated
Revision history for this message
Michael Terry (mterry) wrote :

Uploaded to quantal and precise-proposed.

Changed in quota (Ubuntu Quantal):
assignee: Chris J Arges (christopherarges) → nobody
Changed in quota (Ubuntu Precise):
assignee: Chris J Arges (christopherarges) → nobody
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package quota - 4.00-4ubuntu1

---------------
quota (4.00-4ubuntu1) quantal; urgency=low

  * debian/patches/repquota_fix_xfs_reporting.diff:
    - Patch from upstream to fix repquota on xfs. (LP: #1044516)
 -- Chris J Arges <email address hidden> Mon, 17 Sep 2012 13:38:49 -0500

Changed in quota (Ubuntu Quantal):
status: In Progress → Fix Released
Revision history for this message
Adam Conrad (adconrad) wrote : Please test proposed package

Hello Chris, or anyone else affected,

Accepted quota into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/quota/4.00-3ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in quota (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Roel Standaert (s-roel) wrote :

Tested quota 4.00-3ubuntu1 from precise-proposed. Quotas of users are now displayed too.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Steve Langasek (vorlon) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package quota - 4.00-3ubuntu1

---------------
quota (4.00-3ubuntu1) precise-proposed; urgency=low

  * debian/patches/repquota_fix_xfs_reporting.diff:
    - Patch from upstream to fix repquota on xfs. (LP: #1044516)
  * debian/patches/quota_fix_nfs_reporting.diff:
    - Patch from upstream to fix quota on nfs. (LP: #973663)
 -- Chris J Arges <email address hidden> Mon, 17 Sep 2012 13:33:16 -0500

Changed in quota (Ubuntu Precise):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.