Quasselcore should use an Upstart script instead of a sysv initscript

Bug #1244036 reported by Michael Marley
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
quassel (Ubuntu)
Fix Released
Wishlist
Michael Marley

Bug Description

I have written an Upstart script to replace the old sysv initscript for the quassel core.

Revision history for this message
Michael Marley (mamarley) wrote :
Revision history for this message
Scott Kitterman (kitterman) wrote :

Looks pretty good, but I got a few comments from a developer that knows way more about upstart than me:

<stgraber> ScottK: looks to me like he wants "start on filesystem and static-network-up" instead, but the start on condition he's using isn' wrong either. Just because I'm picky, the respawn stanza is usually put before the script section so it's easier to spot.
<stgraber> besides that, it should all work fine assuming quasselcore doesn't fork/daemonize
<stgraber> oh and hardcoding /usr/bin is usually not considered a good thing
<ScottK> So just excec quasselcore?
<ScottK> exec even
<ScottK> stgraber: ^^^
<stgraber> yep
<ScottK> Thanks.

Changed in quassel (Ubuntu):
status: New → Incomplete
Revision history for this message
Michael Marley (mamarley) wrote :

OK, here is a new version with most of the suggestions implemented. I didn't change it to "static-network-up" though, because based on what I read about "static-network-up," it is only for statically-configured network interfaces and not ones configured through network-manager.

Revision history for this message
Michael Marley (mamarley) wrote :

Here is another update with the default values for PORT and LOGLEVEL added to the Upstart script, as recommended by debfx in #kubuntu-devel.

Changed in quassel (Ubuntu):
status: Incomplete → In Progress
assignee: nobody → Michael Marley (thefirstm)
Revision history for this message
Michael Marley (mamarley) wrote :

I have made an updated version that uses start-stop-daemon in an attempt to fix the problem that debfx was having with SSL certificates.

Revision history for this message
Michael Marley (mamarley) wrote :

Here is a quassel-core.preinst file that will stop the quasselcore when upgrading to an Upstart-enabled version so that Upstart may track the process.

Changed in quassel (Ubuntu):
importance: Undecided → Wishlist
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package quassel - 0.9.2-0ubuntu2

---------------
quassel (0.9.2-0ubuntu2) trusty; urgency=low

  * Add quasselcore upstart job. Thanks to Michael Marley. (LP: #1244036)
  * Restart quasselcore after upgrades.
  * Make quassel-data and quassel-qt4-data conflict as they ship common files.
 -- Felix Geyer <email address hidden> Mon, 02 Dec 2013 16:50:58 +0100

Changed in quassel (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.