commit b017396bf391ba05a448262e290a6609cfe7f275 Author: commit-queue Date: Sun Aug 28 19:24:40 2011 +0000 Fix build error when compiling with MinGW-w64 by disabling JIT on Windows 64-bit https://bugs.webkit.org/show_bug.cgi?id=61235 Patch by Jonathan Liu on 2011-08-28 Reviewed by Gavin Barraclough. The fixed mmap executable allocator for JIT on x86_64 requires sys/mman.h which is not available on Windows. * wtf/Platform.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93950 268f45cc-cd09-0410-ab3c-d52691b4dbfc commit dda59e50379214c098f365a39c4d64b39ced427e Author: Ademar de Souza Reis Jr Date: Fri Aug 26 17:49:20 2011 -0300 Revert "[Qt] Fix tst_QWebFrame::setHtmlWithResource() API test" [1/2] This reverts commit 83cad9be6897798567d0e477ab7f928c93fceed1. The patch was not needed in qtwebkit-2.2, as the failure was specific to trunk. This is the first commit, which added XFAILs to the test. commit 5e03a534a590d88fb7afff68b2728470a650483f Author: Ademar de Souza Reis Jr Date: Fri Aug 26 17:43:54 2011 -0300 Revert "[Qt] Fix tst_QWebFrame::setHtmlWithResource() API test" [2/2] This reverts commit dfe73c30b98223a75f91050ae55ccb87afcf2c73. The patch was not needed in qtwebkit-2.2, as the failure was specific to trunk. This is the second commit, which "fixes" the test. commit 16cbdf38f280feb8fcc073b5c461673dffe0feab Author: Ademar de Souza Reis Jr Date: Fri Aug 26 10:19:43 2011 -0300 Add build flags to reduce the size of Webcore library Patch by Holger Freyther Rubberstamped by Andreas Kling. (qtwebkit-2.2 only by now) [Qt] libwebcore.a source is compiled without -fvisibility=hidden -fvisibility-inlines-hidden https://bugs.webkit.org/show_bug.cgi?id=65470 WTF_USE_EXPORT_MACROS is still not enabled on trunk because there are pending issues with WebKit2, but it appears to be safe to enable this on QtWebKit, so this change is being added to the qtwebkit-2.2 branch. The patch also adds CONFIG += hide_symbols and on Unix, += bsymbolic_functions, which should help reduce the library binary size. Testing this is quite easy, so if there's any problem we'll soon know. :-) commit 85d4df147ac7b239497b05979a51fd6fde7580fd Author: Ademar de Souza Reis Junior Date: Thu Aug 25 20:29:30 2011 +0000 [Qt] Enable password echo on Symbian builds https://bugs.webkit.org/show_bug.cgi?id=66954 Reviewed by Chang Shu. No tests, as this is just a build change. * config.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93817 268f45cc-cd09-0410-ab3c-d52691b4dbfc commit 836fa24be73978fb292e954abb151fb46b1d97e0 Author: Ademar de Souza Reis Junior Date: Thu Aug 25 15:29:21 2011 +0000 Unreviewed QtWebKit.pro fix for when building inside Qt Patch by Simo Fält The QtWebKit version was being overwritten by a global Qt version when QtWebKit was built inside Qt. Fixed by moving the version definition after the inclusion of qbase.pri. * QtWebKit.pro: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93787 268f45cc-cd09-0410-ab3c-d52691b4dbfc commit 17039576ed6c8d2cf26005cbc70ac20486a2c56f Author: Ademar de Souza Reis Jr Date: Thu Aug 25 11:53:59 2011 -0300 Add missing libWebKitSystemInterfaceLion.a to QtWebKit-2.2 branch This file is required when building QtWebKit using the QTKit multimedia backend on Lion, as it provides a bridge to some system interfaces. It was added on trunk a while ago with several other changes, but all we need is the file itself. commit 35023190d11c50ec0ce9ec038bf224f07f87db5a Author: Ademar de Souza Reis Jr Date: Wed Aug 24 11:28:59 2011 -0300 Added support for momentarily revealing last typed character in password input. Code change was partially based on Apple's iOS code and Samuel Nevala's work. https://bugs.webkit.org/show_bug.cgi?id=32509 Patch by Chang Shu on 2011-08-23 Reviewed by Alexey Proskuryakov. Source/WebCore: * editing/InsertIntoTextNodeCommand.cpp: (WebCore::InsertIntoTextNodeCommand::doApply): * rendering/RenderText.cpp: (WebCore::SecureTextTimer::SecureTextTimer): (WebCore::SecureTextTimer::restartWithNewText): (WebCore::SecureTextTimer::invalidate): (WebCore::SecureTextTimer::lastTypedCharacterOffset): (WebCore::SecureTextTimer::fired): (WebCore::RenderText::willBeDestroyed): (WebCore::RenderText::setTextInternal): (WebCore::RenderText::secureText): (WebCore::RenderText::momentarilyRevealLastTypedCharacter): * rendering/RenderText.h: (WebCore::RenderText::isSecure): * testing/Internals.cpp: (WebCore::Internals::setPasswordEchoEnabled): Fixed some silly coding in Internals. (WebCore::Internals::setPasswordEchoDurationInSeconds): (WebCore::Internals::reset): LayoutTests: Updated failed expected files. * editing/input/password-echo-passnode-expected.txt: * editing/input/password-echo-passnode2-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93656 268f45cc-cd09-0410-ab3c-d52691b4dbfc Conflicts: Source/WebCore/editing/InsertIntoTextNodeCommand.cpp Source/WebCore/testing/Internals.cpp commit 3da1d42284d6ab38146278a1218ebf97235e341c Author: Ademar de Souza Reis Jr Date: Wed Aug 24 11:26:06 2011 -0300 Source/JavaScriptCore: Rename "makeSecure" to "fill" and remove the support for displaying last character to avoid layering violatation. https://bugs.webkit.org/show_bug.cgi?id=59114 Patch by Chang Shu on 2011-07-08 Reviewed by Alexey Proskuryakov. * JavaScriptCore.exp: * JavaScriptCore.order: * wtf/text/StringImpl.cpp: (WTF::StringImpl::fill): * wtf/text/StringImpl.h: * wtf/text/WTFString.h: (WTF::String::fill): Source/WebCore: Update calling sites after function renamed. https://bugs.webkit.org/show_bug.cgi?id=59114 Patch by Chang Shu on 2011-07-08 Reviewed by Alexey Proskuryakov. No new tests, just refactoring. * editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::nextBoundary): * rendering/RenderText.cpp: (WebCore::RenderText::setTextInternal): Source/WebKit/win: Update calling sites after function renamed. https://bugs.webkit.org/show_bug.cgi?id=59114 Patch by Chang Shu on 2011-07-08 Reviewed by Alexey Proskuryakov. * WebKitGraphics.cpp: (WebDrawText): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90643 268f45cc-cd09-0410-ab3c-d52691b4dbfc Conflicts: Source/JavaScriptCore/JavaScriptCore.order commit 985a8fa875e9f8c46d2cd379d55983e8ab8d839f Author: Ademar de Souza Reis Jr Date: Wed Aug 24 11:23:22 2011 -0300 Add support of setPasswordEchoEnabled and setPasswordEchoDuration for password echo feature https://bugs.webkit.org/show_bug.cgi?id=66052 Patch by Chang Shu on 2011-08-18 Reviewed by Alexey Proskuryakov. Source/WebCore: Added runtime settings in WebCore. Added support in window.internals for testing. Tests: editing/input/password-echo-passnode.html editing/input/password-echo-passnode2.html editing/input/password-echo-passnode3.html editing/input/password-echo-textnode.html * page/Settings.cpp: (WebCore::Settings::Settings): * page/Settings.h: (WebCore::Settings::setPasswordEchoEnabled): (WebCore::Settings::passwordEchoEnabled): (WebCore::Settings::setPasswordEchoDurationInSeconds): (WebCore::Settings::passwordEchoDurationInSeconds): * testing/Internals.cpp: (WebCore::Internals::Internals): (WebCore::Internals::setPasswordEchoEnabled): (WebCore::Internals::setPasswordEchoDurationInSeconds): (WebCore::Internals::reset): * testing/Internals.h: * testing/Internals.idl: Source/WebKit/qt: Enable password echo under the build flag. * Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): LayoutTests: Added tests. * editing/input/password-echo-passnode-expected.txt: Added. * editing/input/password-echo-passnode.html: Added. * editing/input/password-echo-passnode2-expected.txt: Added. * editing/input/password-echo-passnode2.html: Added. * editing/input/password-echo-passnode3-expected.txt: Added. * editing/input/password-echo-passnode3.html: Added. * editing/input/password-echo-textnode-expected.txt: Added. * editing/input/password-echo-textnode.html: Added. * editing/input/resources: Added. * editing/input/resources/password-echo.js: Added. (secureChar): (secureText): (log): (assert): (run.else): (run): (init): * platform/wk2/Skipped: No support yet. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93291 268f45cc-cd09-0410-ab3c-d52691b4dbfc Conflicts: LayoutTests/platform/wk2/Skipped Source/WebCore/page/Settings.cpp Source/WebCore/page/Settings.h Source/WebCore/testing/Internals.cpp Source/WebCore/testing/Internals.h Source/WebCore/testing/Internals.idl commit 2777535ba73a764640da9fac79f0f8d4ee5355ab Author: Ademar de Souza Reis Jr Date: Wed Aug 24 11:15:37 2011 -0300 2011-08-16 Chang Shu Support reset in WebCore::Internals https://bugs.webkit.org/show_bug.cgi?id=66307 Reviewed by Dimitri Glazkov. New tests will be added when function reset is implemented. Added framework code in WebCoreTestSupport. The real implementation of Internals::reset() depends on the need from the settings that require a reset. * testing/Internals.cpp: (WebCore::Internals::reset): * testing/Internals.h: * testing/js/WebCoreTestSupport.cpp: (WebCoreTestSupport::resetInternalsObject): * testing/js/WebCoreTestSupport.h: * testing/v8/WebCoreTestSupport.cpp: (WebCoreTestSupport::resetInternalsObject): * testing/v8/WebCoreTestSupport.h: 2011-08-16 Chang Shu Support reset in WebCore::Internals https://bugs.webkit.org/show_bug.cgi?id=66307 Reviewed by Dimitri Glazkov. Added framework code in WebKit. * public/WebTestingSupport.h: * src/WebTestingSupport.cpp: (WebKit::WebTestingSupport::resetInternalsObject): 2011-08-16 Chang Shu Support reset in WebCore::Internals https://bugs.webkit.org/show_bug.cgi?id=66307 Reviewed by Dimitri Glazkov. Added framework code in WebKit. * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::resetInternalsObject): * WebCoreSupport/DumpRenderTreeSupportQt.h: 2011-08-16 Chang Shu Support reset in WebCore::Internals https://bugs.webkit.org/show_bug.cgi?id=66307 Reviewed by Dimitri Glazkov. Added call to resetInternalsObject in DRT. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController): * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93235 268f45cc-cd09-0410-ab3c-d52691b4dbfc Conflicts: Source/WebCore/testing/Internals.cpp Source/WebCore/testing/Internals.h Source/WebKit/chromium/public/WebTestingSupport.h Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp commit f3847b9e81180f185bac7338520edb9732b687fa Author: Ademar de Souza Reis Jr Date: Wed Aug 24 11:59:28 2011 -0300 2011-06-09 Robert Hogan Reviewed by Andreas Kling. Teach Qt about window.internals https://bugs.webkit.org/show_bug.cgi?id=61074 Unskip fast/harness/internals-object.html * platform/qt/Skipped: 2011-06-09 Robert Hogan Reviewed by Andreas Kling. Teach Qt about window.internals https://bugs.webkit.org/show_bug.cgi?id=61074 A weakness of the Qt DRT setup is that things like JSContextRef are abstracted away from the QtWebKit API so we need DumpRenderTreeSupportQt to access WebCore internals. Since the window.internals object requires JSContextRef we need to implement it in DumpRenderTreeSupportQt where we can access it. DumpRenderTreeSupportQt cannot be compiled outside Qt's WebCore and as it is our only possible route into the WebCoreTestSupport class neither can the new window.internals plumbing. Likewise we can't put the accessor in WebCoreTestSupport because it would then need to know about QWebFrame and others. The only alternative seems like a compile time guard which we would have to teach the bots about. * CodeGenerators.pri: * WebCore.pri: * WebCore.pro: 2011-06-09 Robert Hogan Reviewed by Andreas Kling. Teach Qt about window.internals https://bugs.webkit.org/show_bug.cgi?id=61074 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::injectInternalsObject): * WebCoreSupport/DumpRenderTreeSupportQt.h: 2011-06-09 Robert Hogan Reviewed by Andreas Kling. Teach Qt about window.internals https://bugs.webkit.org/show_bug.cgi?id=61074 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::initJSObjects): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88446 268f45cc-cd09-0410-ab3c-d52691b4dbfc Conflicts: LayoutTests/platform/qt/Skipped Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h commit b0ff91f953d5f3781d24c842c5616d29be04fca6 Author: Ademar de Souza Reis Jr Date: Wed Aug 24 11:01:28 2011 -0300 2011-06-02 Dimitri Glazkov Reviewed by Darin Adler. Add build logistics and plumbing for window.internals object. https://bugs.webkit.org/show_bug.cgi?id=60313 * fast/dom/Window/script-tests/window-property-descriptors.js: Added internals object to list of properties to skip. * fast/dom/Window/window-properties.html: Ditto. * fast/dom/script-tests/prototype-inheritance-2.js: Ditto. * fast/dom/script-tests/prototype-inheritance.js: Ditto. * fast/harness/internals-object-expected.txt: Added. * fast/harness/internals-object.html: Added. * platform/gtk/Skipped: Skipped the newly added test until platform supports window.internals. * platform/mac-wk2/Skipped: Ditto. * platform/qt/Skipped: Ditto. * platform/win/Skipped: Ditto. 2011-06-02 Dimitri Glazkov Reviewed by Darin Adler. Add build logistics and plumbing for window.internals object. https://bugs.webkit.org/show_bug.cgi?id=60313 Test: fast/harness/internals-object.html * Configurations/WebCoreTestSupport.xcconfig: Added. * DerivedSources.make: Added support for generating from Internals.idl. * WebCore.gyp/WebCore.gyp: Added new webcore_test_support library. * WebCore.gypi: Ditto. * WebCore.xcodeproj/project.pbxproj: Added WebCoreTestSupport library. * testing/Internals.cpp: Added. * testing/Internals.h: Added. * testing/Internals.idl: Added. * testing/js/WebCoreTestSupport.cpp: Added. * testing/js/WebCoreTestSupport.h: Added. * testing/v8/WebCoreTestSupport.cpp: Added. * testing/v8/WebCoreTestSupport.h: Added. 2011-06-02 Dimitri Glazkov Reviewed by Darin Adler. Add build logistics and plumbing for window.internals object. https://bugs.webkit.org/show_bug.cgi?id=60313 * WebKit.gyp: Added linking new webkit_test_support library. * public/WebTestingSupport.h: Added. * src/WebTestingSupport.cpp: Added. 2011-06-02 Dimitri Glazkov Reviewed by Darin Adler. Add build logistics and plumbing for window.internals object. https://bugs.webkit.org/show_bug.cgi?id=60313 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::bindJSObjectsToWindow): Added injection code. * DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87948 268f45cc-cd09-0410-ab3c-d52691b4dbfc Conflicts: LayoutTests/platform/gtk/Skipped LayoutTests/platform/mac-wk2/Skipped LayoutTests/platform/qt/Skipped LayoutTests/platform/win/Skipped commit fcfb7c14310eac4cec42da5cd9ce873e911894ce Author: Ademar de Souza Reis Jr Date: Tue Aug 23 18:19:17 2011 -0300 Add a missing trailing whitespace to a test expectation svg/dom/stylesheet-candidate-node-crash-main.html is a crash test and it fails because of a missing trailing whitespace. For some reason it doesn't fail on trunk (maybe because of new run-webkit-tests or something in our DRT?). commit 2a511cf13bb1bccd312b39fbdafe69a19e54826f Author: Ademar de Souza Reis Jr Date: Tue Aug 23 18:24:20 2011 -0300 Skip failing test introduced in r92966 SHA1: 0e9f086adb423a785038bc12e7a646620a890f7a editing/selection/select-start-remove-root-crash.html fails (timeout) in our 2.2 branch. It's a crash test and the original test-case doesn't crash the QtTestBrowser. I guess there's something missing in our DRT. Pending investigation. commit 5a9b4b9c9f8e18a5d90b6c11656b99272104c876 Author: Ademar de Souza Reis Jr Date: Tue Aug 23 17:17:39 2011 -0300 Crash in FocusController::advanceFocusInDocumentOrder https://bugs.webkit.org/show_bug.cgi?id=66678 Source/WebCore: RefPtr the focusable node to prevent getting deleted by mutation event. Author: Abhishek Arya Reviewed by Dave Hyatt. Test: fast/frames/focus-controller-crash-change-event.html * page/FocusController.cpp: (WebCore::FocusController::advanceFocusInDocumentOrder): LayoutTests: Reviewed by Dave Hyatt. * fast/frames/focus-controller-crash-change-event-expected.txt: Added. * fast/frames/focus-controller-crash-change-event.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93514 268f45cc-cd09-0410-ab3c-d52691b4dbfc Conflicts: Source/WebCore/page/FocusController.cpp commit b0f1d639e8bd2da6bab80d6238a7d56a947420ff Author: Ryosuke Niwa Date: Thu Aug 18 20:41:51 2011 +0000 SimplifiedBackwardsTextIterator returns incorrect offset with first-letter rule https://bugs.webkit.org/show_bug.cgi?id=66086 Reviewed by Darin Adler. Source/WebCore: The bug was caused by SimplifiedBackwardsTextIterator's not taking care of first-letter at all. Fixing the bug by detecting RenderTextFragment in handleTextNode. Also added m_shouldHandleFirstLetter to SimplifiedBackwardsTextIterator to keep track of whether or not the next call to handleTextNode needs to process the first-letter part of the text fragment. Test: editing/text-iterator/backward-textiterator-first-letter-crash.html * editing/TextIterator.cpp: (WebCore::firstRenderTextInFirstLetter): Extracted from handleTextNodeFirstLetter. (WebCore::TextIterator::handleTextNodeFirstLetter): Calls firstRenderTextInFirstLetter. (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): (WebCore::SimplifiedBackwardsTextIterator::handleFirstLetter): Added. * editing/TextIterator.h: LayoutTests: Added a test to ensure WebKit does not hit assertions in SimplifiedBackwardsTextIterator. Also fixed a bug in first-letter-word-boundary.html and updated expected offsets for move backward by word from 0 to 1 because there is unrendered space before "hello". * editing/text-iterator/backward-textiterator-first-letter-crash-expected.txt: Added. * editing/text-iterator/backward-textiterator-first-letter-crash.html: Added. * editing/text-iterator/first-letter-word-boundary-expected.txt: * editing/text-iterator/first-letter-word-boundary.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93347 268f45cc-cd09-0410-ab3c-d52691b4dbfc commit f011bd5f216ba62629ddd6e3f5cec97f44814f58 Author: Tor Arne Vestbø Date: Tue Aug 23 13:26:26 2011 +0000 [Qt] Fix build on Lion https://bugs.webkit.org/show_bug.cgi?id=66770 Reviewed by Andreas Kling. We were mistakenly picking up mac/WebCoreSystemInterface.h instead of the Qt one, and building on Lion revealed this when a typedef for IOSurfaceRef was wrapped in PLATFORM(MAC). For now we fix this by including WebCoreSystemInterface using brackets, so that we'll pick up the right file based on the include paths. This also means exposing a few missing enums in our own version of the file, so those were added. Lasty, we need to link against the right system interface library on Lion. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93600 268f45cc-cd09-0410-ab3c-d52691b4dbfc commit 607eaba91272f6e7b996920dc8410d0ac00fa73b Author: Cris Neckar Date: Mon Aug 8 20:39:23 2011 +0000 Remove counter nodes from the tree and fix-up children when they are removed from the counter map. https://bugs.webkit.org/show_bug.cgi?id=65346 Reviewed by Adam Barth. Covered by existing CSS counter tests. * rendering/CounterNode.cpp: (WebCore::CounterNode::~CounterNode): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92630 268f45cc-cd09-0410-ab3c-d52691b4dbfc commit 668d03b83596f616cd9b4ba94908428ba1c6f330 Author: Ademar de Souza Reis Jr Date: Thu Aug 18 16:36:27 2011 -0300 Move towards supporting user controlled prototypes on CanvasPixelArray https://bugs.webkit.org/show_bug.cgi?id=66429 Author: Oliver Hunt Reviewed by Gavin Barraclough. Start using a per-global object structure for canvas pixel array. * bindings/js/JSImageDataCustom.cpp: (WebCore::toJS): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93264 268f45cc-cd09-0410-ab3c-d52691b4dbfc Conflicts: Source/WebCore/bindings/js/JSImageDataCustom.cpp commit 964b7e9738b9770e0a6bffd4aa4b9514169f5a21 Author: Ademar de Souza Reis Jr Date: Thu Aug 18 15:45:59 2011 -0300 Source/WebCore: Crash in Document::recalcStyleSelector https://bugs.webkit.org/show_bug.cgi?id=66335 Author: Abhishek Arya Reviewed by Simon Fraser. When node is getting destroyed and its removedFromDocument is not called due to entire document structure torn down(using removeAllChildren), make sure to clear out the stylesheet candidate node from document's structures in its destructor. Test: svg/dom/stylesheet-candidate-node-crash-main.html * dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::~ProcessingInstruction): * html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::~HTMLLinkElement): * html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::~HTMLStyleElement): * svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::~SVGStyleElement): LayoutTests: Tests that we do not crash when iterating through stylesheet candidate list hashset. https://bugs.webkit.org/show_bug.cgi?id=66335 Reviewed by Simon Fraser. * svg/dom/resources/stylesheet-candidate-node-crash.svg: Added. * svg/dom/stylesheet-candidate-node-crash-main-expected.txt: Added. * svg/dom/stylesheet-candidate-node-crash-main.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93227 268f45cc-cd09-0410-ab3c-d52691b4dbfc Conflicts: Source/WebCore/html/HTMLLinkElement.cpp commit 4277f8277b1daf3ec33c996f5a760ccd1113af4b Author: Ademar de Souza Reis Jr Date: Thu Aug 18 11:23:19 2011 -0300 [Mac] Add a missing include path to generated headers Author: Alexis Menard When building QtWebKit from inside Qt, we need to use auto-generated headers. On Mac there was an include path missing after the multimedia backend change (Bug 63472, r91752). This is not being added to trunk because it doesn't make sense to add this include path when using build-webkit. commit d054da8fd1752501582c12cb24cf9a7489e0f9e6 Author: Ademar de Souza Reis Jr Date: Tue Aug 16 17:10:03 2011 -0300 Crash accessing static property on sealed object https://bugs.webkit.org/show_bug.cgi?id=66242 Author: Gavin Barraclough Reviewed by Sam Weinig. Source/JavaScriptCore: * runtime/JSObject.h: (JSC::JSObject::putDirectInternal): - should only check isExtensible if checkReadOnly. LayoutTests: * fast/js/preventExtensions-expected.txt: * fast/js/script-tests/preventExtensions.js: - added test case. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93048 268f45cc-cd09-0410-ab3c-d52691b4dbfc Conflicts: LayoutTests/fast/js/preventExtensions-expected.txt LayoutTests/fast/js/script-tests/preventExtensions.js commit 0e9f086adb423a785038bc12e7a646620a890f7a Author: Ademar de Souza Reis Jr Date: Mon Aug 15 18:02:07 2011 -0300 Crash in WebCore::editingIgnoresContent https://bugs.webkit.org/show_bug.cgi?id=66125 Author: Abhishek Arya Reviewed by Ryosuke Niwa. Source/WebCore: RefPtr a few nodes in case they get blown away in dispatchEvent calls. Test: editing/selection/select-start-remove-root-crash.html * editing/FrameSelection.cpp: (WebCore::FrameSelection::selectAll): * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): LayoutTests: Tests that we do not crash when we blow away the root during the firing of selectstart event in selection. * editing/selection/select-start-remove-root-crash-expected.txt: Added. * editing/selection/select-start-remove-root-crash.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92966 268f45cc-cd09-0410-ab3c-d52691b4dbfc Conflicts: Source/WebCore/editing/FrameSelection.cpp commit fbfc2f9a18a55802204a8e95dd22bb5c1fe49f1a Author: Abhishek Arya Date: Sun Aug 14 23:08:11 2011 +0000 Source/WebCore: Crash in HTMLTreeBuilder::processAnyOtherEndTagForInBody https://bugs.webkit.org/show_bug.cgi?id=66187 Reviewed by Adam Barth. RefPtr a few ContainerNodes to prevent premature deletion. Test: fast/html/process-end-tag-for-inbody-crash.html * html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag): (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): (WebCore::HTMLTreeBuilder::callTheAdoptionAgency): LayoutTests: Crash in HTMLTreeBuilder::processAnyOtherEndTagForInBody. https://bugs.webkit.org/show_bug.cgi?id=66187 Reviewed by Adam Barth. * fast/html/process-end-tag-for-inbody-crash-expected.txt: Added. * fast/html/process-end-tag-for-inbody-crash.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93032 268f45cc-cd09-0410-ab3c-d52691b4dbfc commit a755bead1f11d4d721d7dee518c566345e6ea484 Author: Abhishek Arya Date: Wed Aug 10 21:48:18 2011 +0000 Source/WebCore: Check that we do not need layout before trying to dirty m_originatingLine for our floats. https://bugs.webkit.org/show_bug.cgi?id=65938 Reviewed by Dave Hyatt. Test: fast/block/float/float-originating-line-deleted-crash.html * rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeFloatingObject): (WebCore::RenderBlock::clearFloats): LayoutTests: Tests that we do not crash when trying to access a removed m_originatingLine for a float. https://bugs.webkit.org/show_bug.cgi?id=65938 Reviewed by Dave Hyatt. * fast/block/float/float-originating-line-deleted-crash-expected.txt: Added. * fast/block/float/float-originating-line-deleted-crash.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92798 268f45cc-cd09-0410-ab3c-d52691b4dbfc commit 8ed79cb10ca72b5d240beae674a7932963cbd007 Author: Alexis Menard Date: Thu Aug 11 12:45:44 2011 +0000 Unreviewed build fix for Qt. Make sure we build when Qt is namespaced. * platform/graphics/gstreamer/PlatformVideoWindowPrivate.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92841 268f45cc-cd09-0410-ab3c-d52691b4dbfc commit 66b76cdb8ef823f27a8229c5cae2d35e7f2d3c59 Author: Ademar de Souza Reis Jr Date: Mon Aug 8 12:15:10 2011 -0300 Skip tests that fail because of qtwebkit-2.2 DRT limitations Introduced by r92142 (bug 61809): Source/WebCore: Never override the policy URL on form submissions https://bugs.webkit.org/show_bug.cgi?id=61809 On qtwebkit-2.2 our DRT doesn't support third-party-cookies configuration (layoutTestController.setAlwaysAcceptCookies() and therefore these tests fail. commit 0c20586abec46074c8641f80736e473201344e5a Author: commit-queue Date: Sat Aug 6 19:52:39 2011 +0000 Patch by Aron Rosenberg on 2011-08-06 Reviewed by Benjamin Poulain. [Qt] Fix build with Intel compiler on Windows https://bugs.webkit.org/show_bug.cgi?id=65088 .: Disable Intel Compiler warning 873 - function "" has no corresponding operator delete (to be called if an exception is thrown during initialization of an allocated object). * Source/WebKit.pri: Source/JavaScriptCore: Intel compiler needs .lib suffixes instead of .a Intel compiler doesn't support nullptr Intel compiler supports unsized arrays * JavaScriptCore.pri: * jsc.cpp: * wtf/ByteArray.h: * wtf/NullPtr.h: Source/WebCore: Intel compiler needs .lib suffixes instead of .a * WebCore.pri: Source/WebKit2: Intel compiler needs .lib suffixes instead of .a * WebKit2.pri: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92555 268f45cc-cd09-0410-ab3c-d52691b4dbfc commit 6c2f6bbcd6f5d9c63b936851c2b58f06f477f99a Author: Kent Tamura Date: Thu Aug 4 04:38:01 2011 +0000 Fix incorrect checks for HTMLMediaElement https://bugs.webkit.org/show_bug.cgi?id=65590 Reviewed by Dimitri Glazkov.