Playlist support in vivid+overlay and Xenial is different/non compatible

Bug #1523407 reported by Albert Astals Cid on 2015-12-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
High
John McAleely
qtmultimedia-opensource-src (Ubuntu)
High
Jim Hodapp

Bug Description

qtmultimedia-opensource-src-5.4.1/debian/patches/add_qdeclarative_playlist.patch says

+ qmlRegisterType<QDeclarativePlaylist>(uri, 5, 4, "Playlist");

while qtmultimedia-opensource-src-5.5.1/debian/patches/Added-new-playlist-QML-type.patch (as per silo 12) says

+ qmlRegisterType<QDeclarativePlaylist>(uri, 5, 6, "Playlist");

This is not a good idea, we should keep the imports to the same level as we decide to support them, even if the support was not official doing this makes it harder to have a codebase that works fine in both vivid+overlay and xenial.

Also the xenial patch seems to be missing some things like QDeclarativePlaylist::moveItem

Michał Sawicz (saviq) wrote :

One thing to note, the fact we've exported backported features as 5.4 is IMO a mistake, because that means we'll need to carry a patch forever (until we deprecate 5.4 whole, or just the Playlist export).

Whenever backporting features from future Qt, we should only export them at the version they will ultimately land with. While this will likely mean a bit more involved porting effort, it will save us trouble down the line.

Timo Jyrinki (timo-jyrinki) wrote :

Another thing to be noted is that there have been big landings to vivid-proposed in media-hub etc that would need to be ported to xenial. The current patch in xenial Qt 5.5 is what has been upstreamed so far and it is fairly close to current vivid-overlay (but lacks moveItem and a couple of other small bits that are not yet merged in upstream). The previous patch in xenial was the older patch that is no longer compatible with either vivid-overlay or upstream.

The moveItem among else will only be in Qt 5.7 so backports to both Qt 5.4 and 5.5 (vivid-overlay/xenial) will need to take that into consideration too probably.

Changed in canonical-devices-system-image:
assignee: nobody → John McAleely (john.mcaleely)
milestone: none → ww02-2016
status: New → Confirmed
importance: Undecided → High
Jim Hodapp (jhodapp) on 2015-12-16
Changed in qtmultimedia-opensource-src (Ubuntu):
status: New → Triaged
importance: Undecided → High
assignee: nobody → Thomas Voß (thomas-voss)
Jim Hodapp (jhodapp) on 2015-12-18
Changed in qtmultimedia-opensource-src (Ubuntu):
status: Triaged → In Progress
Changed in canonical-devices-system-image:
status: Confirmed → In Progress
Changed in qtmultimedia-opensource-src (Ubuntu):
assignee: Thomas Voß (thomas-voss) → Jim Hodapp (jhodapp)
Jim Hodapp (jhodapp) wrote :

Let me make sure I understand. We should change the vivid+overlay version of the QtMultimedia so that the exported Playlist types are under 5.6 and not 5.4?

Jim Hodapp (jhodapp) wrote :

Changes for xenial to catch up with vivid on playlist support: https://requests.ci-train.ubuntu.com/#/ticket/808

Michał Sawicz (saviq) wrote :

@Jim, yeah, we want to keep backported features at their original import versions so we don't have to carry backport patches indefinitely.

Jim Hodapp (jhodapp) on 2015-12-21
Changed in qtmultimedia-opensource-src (Ubuntu):
status: In Progress → Fix Committed
Jim Hodapp (jhodapp) on 2015-12-22
Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
Changed in qtmultimedia-opensource-src (Ubuntu):
status: Fix Committed → Fix Released
Timo Jyrinki (timo-jyrinki) wrote :

qtmultimedia-opensource-src (5.5.1-1ubuntu2) xenial; urgency=medium

  [ Timo Jyrinki ]
  * More patches from upstream to the playlist:
    - debian/patches/Change-the-way-a-playlist-is-bound-to-a-media-object.patch
      (replaces earlier abandoned Sync-the-state... patch)
    - debian/patches/Added-addItems-to-QML-Playlist-for-batch-adding-of-t.patch
    - debian/patches/Added-insertItems-and-removeItems-to-QML-Playlist.patch
    - debian/patches/Add-moveItem-from-to-to-QMediaPlaylist.patch

  [ Jim Hodapp ]
  * Related changes for compatibility reasons:
    - debian/patches/backport_adjustments.patch

 -- Timo Jyrinki <email address hidden> Tue, 22 Dec 2015 13:57:22 +0000

Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers