Upstream the media role property patch

[Timo Jyrinki]

Please upstream the adding_media_role_property.patch properly to the upstream code review system, as we shouldn't carry non-upstreamed patches or deviate to direction that would be incompatible with future upstream selections.

The already existing bug report https://bugreports.qt-project.org/browse/QTBUG-41054 can be referred in the git commit proposal.

[Timo Jyrinki (timo-jyrinki)]

The patch fails to apply to Qt 5.5.

Bug https://bugreports.qt.io/browse/QTBUG-41054 states the patch should have been submitted to Gerrit, but that seems not to have happened (https://codereview.qt-project.org/#/q/owner:jim.hodapp%2540canonical.com+status:open,n,z)

Please supply both a version of the patch that applies to the 5.5 branch and also submit the patch to the upstream code review for current dev version (5.6) soon.

[Timo Jyrinki (timo-jyrinki)]

Looks like only plugins.qmltypes has changed in 5.5 so far regarding the patch, so the rebasing does not look like a problem. However upstreaming needed.

[Timo Jyrinki (timo-jyrinki)]

Done! https://codereview.qt-project.org/#/c/122658/

[Jim Hodapp (jhodapp)]

Fantastic! Give me plenty of warning before we switch to Qt 5.6 (assuming this gets in there) as we'll have to do some adapting to the qtubuntu-media code due to some of the restructuring that went on in this patch to get this upstreamed.