[PATCH] Fix crash in hasAtlasTexture

Bug #1563320 reported by Albert Astals Cid on 2016-03-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
qtdeclarative-opensource-src (Ubuntu)
Undecided
Timo Jyrinki
qtdeclarative-opensource-src (Ubuntu RTM)
Undecided
Unassigned

Bug Description

I have just fixed the bug upstream, it would be great if we could have it in our packages (both vivid and xenial) since i'm hitting it regularly with some new code i am working on.

https://codereview.qt-project.org/#/c/154085/

Changed in qtdeclarative-opensource-src (Ubuntu):
status: New → Triaged
assignee: nobody → Timo Jyrinki (timo-jyrinki)
Timo Jyrinki (timo-jyrinki) wrote :

The backport from 5.6 applies to 5.5 fine, but there is no hasAtlasTexture function at all in 5.4. care to take a look? I'm not sure if eg line 140 of src/quick/items/qquickshadereffectnode.cpp or line 715 of src/quick/items/qquickimage.cpp would benefit from having the extra check for "t" or not.

Albert Astals Cid (aacid) wrote :

> line 140 of src/quick/items/qquickshadereffectnode.cpp
Not needed there, lines 129 and 130 have the proper checks already

> line 715 of src/quick/items/qquickimage.cpp
Not needed there either, line 599 also protects us

From what i can see it seems that this backport may only be needed for 5.5 (i.e. xenial)

Timo Jyrinki (timo-jyrinki) wrote :

Ok, thank you for investigating.

Changed in qtdeclarative-opensource-src (Ubuntu RTM):
status: New → Invalid
Changed in qtdeclarative-opensource-src (Ubuntu):
status: Triaged → In Progress
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qtdeclarative-opensource-src - 5.5.1-2ubuntu6

---------------
qtdeclarative-opensource-src (5.5.1-2ubuntu6) xenial; urgency=medium

  * debian/patches/Fix-crash-in-hasAtlasTexture.patch:
    - Backport patch from Qt 5.6 (LP: #1563320)

 -- Timo Jyrinki <email address hidden> Tue, 12 Apr 2016 10:44:18 +0000

Changed in qtdeclarative-opensource-src (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers