Adapt QML Cache patch for Qt 5.5

Bug #1437320 reported by Timo Jyrinki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
qtdeclarative-opensource-src (Ubuntu)
Fix Released
High
Timo Jyrinki

Bug Description

QML cache patch QML-Compilation-unit-caching-and-JIT-changes.patch does not apply against Qt 5.5, and would need adjusting. Bug #1426288 is a bug about upstreaming it so that it wouldn't need to be carried in the first place.

More information about Qt 5.5 at https://wiki.ubuntu.com/Touch/QtTesting

Tags: patch qt5.5
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

I was able to rebase the patch as the Qt 5.5 changes did not seem as big as with Qt 5.4. The revised patch attached. But it fails to build with:

---
In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qnamespace.h:37:0,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/qobjectdefs.h:41,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/qobject.h:40,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/qabstractanimation.h:37,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/QtCore:4,
                 from ../../include/QtQml/QtQmlDepends:3:
compiler/qv4isel_p.cpp: In member function ‘QQmlRefPointer<QV4::CompiledData::CompilationUnit> QV4::EvalInstructionSelection::compile(bool)’:
compiler/qv4isel_p.cpp:340:40: error: ‘codeRefLen’ was not declared in this scope
             Q_ASSERT(dummySize == (int)codeRefLen);
---

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

And here are the rebasing changes as a diff I did to the patch.

Revision history for this message
Ricardo Mendoza (ricmm) wrote :

I'll find some time this week to look at it.

Changed in qtdeclarative-opensource-src (Ubuntu):
importance: Undecided → High
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

I now ended up commenting out the ASSERT. Also a QDataStream change in 5.5 required a slight change, but now it builds with this version attached.

Unable to test yet because of the GCC5 transition.

tags: added: patch
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Seems to work on x86 at least after setting the environment variable, unable to test on arm at the moment on wily.

Changed in qtdeclarative-opensource-src (Ubuntu):
status: New → Fix Committed
assignee: Ricardo Mendoza (ricmm) → Timo Jyrinki (timo-jyrinki)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Now finally fully testable on the phone, seems to work fine on armhf too.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qtdeclarative-opensource-src - 5.5.1-2ubuntu2

---------------
qtdeclarative-opensource-src (5.5.1-2ubuntu2) xenial; urgency=high

  * Fix symbols for s390x.

 -- Dimitri John Ledkov <email address hidden> Wed, 09 Dec 2015 13:14:34 +0000

Changed in qtdeclarative-opensource-src (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

qtdeclarative-opensource-src (5.5.1-2ubuntu1) xenial; urgency=medium

  * New upstream release. (LP: #1502883)
  * Remove patches no longer needed:
    - debian/patches/High-dpi-SVG-and-QQuickImageProvider-Images.patch
    - debian/patches/aarch64.patch
    - debian/patches/check_system_double-conversion.patch
    - debian/patches/ppc64el.patch
  * Rebase patches:
    - debian/patches/Add-QQuickAsyncImageProvider.patch
    - debian/patches/disable_failing_tests.patch
    - debian/patches/QML-Compilation-unit-caching-and-JIT-changes.patch
      (LP: #1437320)
  * Drop upstreamed patches:
    - debian/patches/Fix-memory-leak-when-QQuickPixmapReply-Event-is-dele.patch
  * Update .install files.
  * Skip tests also on ppc64el, they are flaky.
  * Update symbols and mark/unmark private ones.
  * Bump ABI version to 5-5-0.
  * Bump build dependencies.
  * Build dep on libqt5xcbqpa5 to be able to run the tests under xvfb.
  * Update Vcs url:s to Debian git.
  * Add qmlplugindump-Don-t-try-to-import-Qt.test.qtestroot.patch
    (LP: #1473976)

 -- Timo Jyrinki <email address hidden> Tue, 01 Dec 2015 08:12:31 +0000

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.