Add a --ignore-debug-mode switch

[Daniel Holbach]

Maybe we need to add an --ignore-debug-mode switch?

<zbenjamin> dholbach: can we do something about that debug policy problem ?
 dholbach: the review throws them as errors of course, but can we have a switch like --allow-debug ?
<dholbach> zbenjamin, I don't quite know what we're talking about
 ah ok
 zbenjamin, could we turn the debugging machinery off, when a click is created?
<zbenjamin> dholbach: i tried to rewrite the errors to warnings with matching them. But any change on the strings will make it fail of course
 dholbach: no, we need click packages to install a debug enabled app on the phone
<dholbach> hummmmmmmmmmmmmm
<zbenjamin> dholbach: but it would be nice if we still can run the review tools on them to catch other problems
<dholbach> could we inject the debug machinery bits just into clicks which are shipped to the phone?
 for all other use-cases it sounds like we don't want them to be enabled(?)
 I'm not sure if that's actually the case
<zbenjamin> dholbach: well thats what we do, but the review tools run on them as well because they would catch other problems that would cause the install to fail
<dholbach> right

[Jamie Strandboge (jdstrand)]

We have special SDK json (click-review --sdk) that the SDK can consume to do what it wants with any test and the click-reviewers-tools were specifically designed for this. I'm not sure why this isn't sufficient?

[Benjamin Zeller (zeller-benjamin)]

The SDK is using the --sdk switch , that however does not help with changing
error messages and new error messages that need to be treated as warnings instead.

Especially the debug group related messages are a problem here because instead of
starting the App QtCreator will pop up a messagebox asking if the user wants to ignore
the error.

However in case of running a app from QtCreator this is not an error.

Also the --sdk switch should not change the outputs contents, but only provide a parseable
output for QtC.
This parseable output is used:

a) in the publish tab where we WANT debug parts as errors
b) before pushing a click package to the device, here we do NOT want to
     have the debug parts as errors

[Jamie Strandboge (jdstrand)]

I guess I don't see why it would not be the SDK's responsibility to ignore the error-- it is the one adding the debug policy group. Seems that the SDK should simply not display the pop up messagebox if the debug policy group is the only error.

[Benjamin Zeller (zeller-benjamin)]

Thats what I already did, but since we do not have error codes that help me to exactly identify a specific
error, i had to fall back to string matching. And string matching breaks everytime the error message
gets changed....

[Jamie Strandboge (jdstrand)]

Has this error message changed recently and broken things? I feel like I am missing something...

[Benjamin Zeller (zeller-benjamin)]

This is one example which just came up recently:

https://bugs.launchpad.net/ubuntu/+source/qtcreator-plugin-ubuntu/+bug/1426315

[Benjamin Zeller (zeller-benjamin)]

Another example just came up, breaking the deployment of scopes to the device:

https://bugs.launchpad.net/ubuntu/+source/qtcreator-plugin-ubuntu/+bug/1499135

Even though we have a regex for the policy_groups_safe error for debug group it stopped
to work because the string was changed.

Can we do anything to prevent that kind of breakage?

[Jamie Strandboge (jdstrand)]

Marking as "Won't Fix". Series 16 snaps don't have the 'debug' policy group and people can use devmode instead. This is fixed in the SDK already and I've just now added comments to not change the string the SDK looks at without coordination with the SDK team.