Activity log for bug #1799111

Date Who What changed Old value New value Message
2018-10-22 03:43:44 michael bug added bug
2018-10-22 03:44:17 michael summary lots of Classes missing from docs (ie.g. QFileInfo) lots of Classes missing from docs (e.g. QFileInfo)
2018-10-22 16:29:57 Dmitry Shachnev bug watch added https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=908328
2018-10-22 16:29:57 Dmitry Shachnev bug task added qtdoc-opensource-src (Debian)
2018-10-22 16:30:21 Dmitry Shachnev affects qtdoc-opensource-src (Debian) qtbase-opensource-src (Debian)
2018-10-22 16:30:33 Dmitry Shachnev affects qtdoc-opensource-src (Ubuntu) qtbase-opensource-src (Ubuntu)
2018-10-23 16:11:08 Dmitry Shachnev description The Qt offline documentation for cosmic is incomplete. In fact there's virtually no content what so ever. It would be easier I think to list what actually got picked up that what was missed. [Impact] The packaged Qt documentation, which can be viewed in browser (qt*-doc-html packages) or in Qt Assistant (qt*-doc packages) is missing all documentation generated from C++ files. Only the static text is present. Qt is split by many modules (qtbase, qtdeclarative, qtwebengine, etc.). I am now fixing it for qtbase, the largest module, but I may fix it for other modules if someone requests it. [Test Case] 1. Install qtbase5-doc-html package. 2. Make sure /usr/share/qt5/doc/qtcore/qobject.html is present. [Regression Potential] The proposed fix only adds a new build-dependency. There is absolutely no regression potential. [Other Info] Description of the fix: qdoc is a tool that parses C++ source files and generates documentation from them. Recently, qdoc began using clang instead of its own C++ parser. Clang needs the C++ standard library to work. qdoc build system uses a build-time macro (CLANG_RESOURCE_DIR) that hard-codes the path to standard library in the executable: https://code.qt.io/cgit/qt/qttools.git/tree/src/qdoc/qdoc.pro?h=5.11#n19. From qttools-opensource-src 5.11.1-5 build log in Cosmic amd64, one can see that qdoc was compiled with -D'CLANG_RESOURCE_DIR="/usr/lib/llvm-6.0/lib/clang/6.0.1/include"'. So this directory needs to be present when qdoc is used. This directory is provided by libclang-common-6.0-dev package. So adding it to build-dependencies makes the documentation build correctly. This is the minimal fix for Cosmic. For Ubuntu 19.04, I will try to use a better solution like moving the clang standard library detection from build time to run time, or making qttools5-dev-tools depend on the needed -dev packages. [Original Description] The Qt offline documentation for cosmic is incomplete. In fact there's virtually no content what so ever. It would be easier I think to list what actually got picked up that what was missed.
2018-11-08 00:27:00 Bug Watch Updater qtbase-opensource-src (Debian): status Unknown Fix Released
2018-11-15 12:05:37 Dmitry Shachnev description [Impact] The packaged Qt documentation, which can be viewed in browser (qt*-doc-html packages) or in Qt Assistant (qt*-doc packages) is missing all documentation generated from C++ files. Only the static text is present. Qt is split by many modules (qtbase, qtdeclarative, qtwebengine, etc.). I am now fixing it for qtbase, the largest module, but I may fix it for other modules if someone requests it. [Test Case] 1. Install qtbase5-doc-html package. 2. Make sure /usr/share/qt5/doc/qtcore/qobject.html is present. [Regression Potential] The proposed fix only adds a new build-dependency. There is absolutely no regression potential. [Other Info] Description of the fix: qdoc is a tool that parses C++ source files and generates documentation from them. Recently, qdoc began using clang instead of its own C++ parser. Clang needs the C++ standard library to work. qdoc build system uses a build-time macro (CLANG_RESOURCE_DIR) that hard-codes the path to standard library in the executable: https://code.qt.io/cgit/qt/qttools.git/tree/src/qdoc/qdoc.pro?h=5.11#n19. From qttools-opensource-src 5.11.1-5 build log in Cosmic amd64, one can see that qdoc was compiled with -D'CLANG_RESOURCE_DIR="/usr/lib/llvm-6.0/lib/clang/6.0.1/include"'. So this directory needs to be present when qdoc is used. This directory is provided by libclang-common-6.0-dev package. So adding it to build-dependencies makes the documentation build correctly. This is the minimal fix for Cosmic. For Ubuntu 19.04, I will try to use a better solution like moving the clang standard library detection from build time to run time, or making qttools5-dev-tools depend on the needed -dev packages. [Original Description] The Qt offline documentation for cosmic is incomplete. In fact there's virtually no content what so ever. It would be easier I think to list what actually got picked up that what was missed. [Impact] The packaged Qt documentation, which can be viewed in browser (qt*-doc-html packages) or in Qt Assistant (qt*-doc packages) is missing all documentation generated from C++ files. Only the static text is present. Qt is split by many modules (qtbase, qtdeclarative, qtwebengine, etc.). To properly fix this bug, we need changes in qtbase and qttools modules. In addition, I will be uploading a no-change rebuild of qtdeclarative module to demonstrate that the fixes work. If requested, I can also upload no-change rebuilds of some other modules to get their -doc packages properly regenerated. [Test Case] For qtbase5-doc-html: 1. Install qtbase5-doc-html package. 2. Make sure /usr/share/qt5/doc/qtcore/qobject.html is present. For qtdeclarative5-doc-html: 1. Install qtdeclarative5-doc-html package. 2. Make sure /usr/share/qt5/doc/qtquick/qquickwidget.html is present. [Regression Potential] The proposed change in qtbase is affecting only builds of Qt modules documentation. So the worst thing it can do is breaking the build of -doc packages in other Qt modules. However, as confirmed by qtdeclarative example, it makes things only better, not worse. The proposed change in qttools can affect more packages. It can result in qdoc passing more -isystem flags to clang code analyzer. I am not aware of negative consequences of this, but if they happen, these consequences will be limited to potential build failures or wrong documentation contents. [Other Info] Description of the fix: qdoc is a tool that parses C++ source files and generates documentation from them. Recently, qdoc began using clang instead of its own C++ parser. Clang needs the C++ standard library to work. Starting with llvm-toolchain 1:7~+rc1-1~exp2, the GCC C++ standard library is no longer on clang’s default search paths, so we need to pass it explicitly as -I flag. The proposed qtbase patch (qdoc_default_incdirs.diff) does that. That patch fixes documentation build for qtbase, but for other modules there is another problem. The Qt headers are installed into /usr/include/<triplet>/qt5 directory, but it is also not on Clang default search path. qmake passes these directories as -isystem flags, but qdoc ignores -isystem by default, unless it is built with QDOC_PASS_ISYSTEM defined. So the proposed change in qttools is building with this define. [Original Description] The Qt offline documentation for cosmic is incomplete. In fact there's virtually no content what so ever. It would be easier I think to list what actually got picked up that what was missed.
2018-11-15 12:06:36 Dmitry Shachnev bug task added qttools-opensource-src (Ubuntu)
2018-11-15 12:06:52 Dmitry Shachnev bug task added qtdeclarative-opensource-src (Ubuntu)
2018-11-15 12:07:02 Dmitry Shachnev nominated for series Ubuntu Cosmic
2018-11-15 12:07:02 Dmitry Shachnev bug task added qtbase-opensource-src (Ubuntu Cosmic)
2018-11-15 12:07:02 Dmitry Shachnev bug task added qtdeclarative-opensource-src (Ubuntu Cosmic)
2018-11-15 12:07:02 Dmitry Shachnev bug task added qttools-opensource-src (Ubuntu Cosmic)
2018-11-23 10:23:47 Launchpad Janitor qtbase-opensource-src (Ubuntu): status New Fix Released
2018-11-23 10:32:40 Launchpad Janitor qttools-opensource-src (Ubuntu): status New Fix Released
2018-11-26 08:22:40 Dmitry Shachnev qtdeclarative-opensource-src (Ubuntu): status New Fix Released
2018-11-30 22:59:22 Launchpad Janitor qtbase-opensource-src (Ubuntu Cosmic): status New Confirmed
2018-11-30 22:59:22 Launchpad Janitor qtdeclarative-opensource-src (Ubuntu Cosmic): status New Confirmed
2018-11-30 22:59:22 Launchpad Janitor qttools-opensource-src (Ubuntu Cosmic): status New Confirmed
2019-01-25 08:56:38 Timo Aaltonen tags verification-needed
2019-02-05 11:59:36 Dmitry Shachnev tags verification-needed verification-done verification-done-cosmic
2019-02-07 15:36:28 Dmitry Shachnev bug watch added https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=907339
2019-02-11 10:03:00 Launchpad Janitor qttools-opensource-src (Ubuntu Cosmic): status Confirmed Fix Released
2019-02-11 10:03:09 Launchpad Janitor qtbase-opensource-src (Ubuntu Cosmic): status Confirmed Fix Released
2019-02-11 10:03:12 Launchpad Janitor qtdeclarative-opensource-src (Ubuntu Cosmic): status Confirmed Fix Released