Re-enable qtbase tests that are disabled with Qt 5.3

Bug #1324000 reported by Timo Jyrinki
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
qtbase-opensource-src (Ubuntu)
Confirmed
Medium
Unassigned

Bug Description

To get Qt 5.3 builds going, I had to disable qtbase tests at first.

I've now worked on restoring them, but while doing so a handful of new failing tests were discovered that I had to disable.

These newly disabled tests should be re-enabled. The commit where tests were re-enabled but some tests disabled was: http://bazaar.launchpad.net/~timo-jyrinki/kubuntu-packaging/qtbase-opensource-src_qt530RC/revision/175

Tags: qt5.3
tags: added: qt5.3
Changed in qtbase-opensource-src (Ubuntu):
assignee: nobody → Timo Jyrinki (timo-jyrinki)
Changed in qtbase-opensource-src (Ubuntu):
status: New → In Progress
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Some whitelist candidates and reasoning:

- tst_QThreadPool::expiryTimeoutRace - test did not exist in 5.2.1. fails only on armhf and upstream seems to have had problems with the test.
- tests/auto/gui/kernel/qwindow/tst_qwindow.cpp - tests (positioning, isactive) already disabled in our 5.2.1 build, now initialsize added though
- tests/auto/corelib/tools/qdate/tst_qdate.cpp - there's a text prefix character (Unicode?) error in the string, but the number seems right.

Possibly problematic ones that would need more investigating or some fix:

- qtbase-opensource-src-5.3.0/tests/auto/dbus/qdbusxmlparser/tst_qdbusxmlparser.cpp - tests were not disabled in 5.2.1.
Error: FAIL! : tst_QDBusXmlParser::initTestCase() 'qt_qhash_seed.testAndSetRelaxed(-1, 0)' returned FALSE. () Loc: [tst_qdbusxmlparser.cpp(84)]
- qtbase-opensource-src-5.3.0/tests/auto/widgets/widgets/qlineedit/tst_qlineedit.cpp - tests were not disabled in 5.2.1. Notes: affects only desktop since is in QWidgets.
Error: FAIL! : tst_QLineEdit::passwordEchoOnEdit() '(testWidget->hasFocus())' returned FALSE. () Loc: [tst_qlineedit.cpp(1690)]
            FAIL! : tst_QLineEdit::inlineCompletion() Compared pointers are not the same Actual ((((static_cast<QApplication *>(QCoreApplication::instance()))->activeWindow()))): (nil) Expected ((QWidget*)testWidget) : 0x1f1a860 Loc: [tst_qlineedit.cpp(3241)]

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

I've now tested all of the following that they pass - under xvfb-run too - locally for me, which leads to thinking the problems only happen on builders (for some reason):

- tests/auto/gui/kernel/qwindow/tst_qwindow.cpp
- tests/auto/corelib/tools/qdate/tst_qdate.cpp
- tests/auto/dbus/qdbusxmlparser/tst_qdbusxmlparser.cpp
- tests/auto/widgets/widgets/qlineedit/tst_qlineedit.cpp
(+ tst_qthreadpool, but that wasn't failing on x86 on the builders either)

At the moment I don't think there's anything that strictly needs re-enabling in qtbase, but the tests should be kept on mind for future Qt releases.

I'm marking the bug as Invalid for now, but it can be reopened later too or adjusted to point out what should be done.

Changed in qtbase-opensource-src (Ubuntu):
status: In Progress → Invalid
Changed in qtbase-opensource-src (Ubuntu):
status: Invalid → Confirmed
importance: Undecided → Medium
JACQUELINE (ijdisabest)
Changed in qtbase-opensource-src (Ubuntu):
status: Confirmed → Fix Committed
Colin Watson (cjwatson)
Changed in qtbase-opensource-src (Ubuntu):
status: Fix Committed → Confirmed
Changed in qtbase-opensource-src (Ubuntu):
assignee: Timo Jyrinki (timo-jyrinki) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.