| 2016-04-05 23:04:32 |
dann frazier |
bug |
|
|
added bug |
| 2016-04-05 23:07:50 |
dann frazier |
tags |
arm64 armhf |
arm64 armhf patch |
|
| 2016-04-07 14:38:52 |
Serge Hallyn |
summary |
support query-gic-version QMP command |
[FFE] support query-gic-version QMP command |
|
| 2016-04-07 14:39:41 |
Serge Hallyn |
bug |
|
|
added subscriber Ubuntu Release Team |
| 2016-04-07 14:41:01 |
Serge Hallyn |
description |
There currently is no interface for an external tool to determine what GIC versions can be used by guests on the current hardware/QEMU combination. Upstream patches have recently landed to solve this problem, exposing a QMP interface for probing the system:
dannf@mustang:~$ telnet localhost 4444
Trying ::1...
Connected to localhost.
Escape character is '^]'.
{"QMP": {"version": {"qemu": {"micro": 0, "minor": 5, "major": 2}, "package": " (Debian 1:2.5+dfsg-5ubuntu6)"}, "capabilities": []}}
{ "execute": "qmp_capabilities" }
{"return": {}}
{ "execute": "query-gic-capabilities" }
{"return": [{"emulated": false, "version": 3, "kernel": false}, {"emulated": true, "version": 2, "kernel": true}]}
This is important, because VM management software (i.e. libvirt) need to be able to figure out what guest configurations are supported. |
[Note - the patches are all upstream, so risk on this patchset should be low]
There currently is no interface for an external tool to determine what GIC versions can be used by guests on the current hardware/QEMU combination. Upstream patches have recently landed to solve this problem, exposing a QMP interface for probing the system:
dannf@mustang:~$ telnet localhost 4444
Trying ::1...
Connected to localhost.
Escape character is '^]'.
{"QMP": {"version": {"qemu": {"micro": 0, "minor": 5, "major": 2}, "package": " (Debian 1:2.5+dfsg-5ubuntu6)"}, "capabilities": []}}
{ "execute": "qmp_capabilities" }
{"return": {}}
{ "execute": "query-gic-capabilities" }
{"return": [{"emulated": false, "version": 3, "kernel": false}, {"emulated": true, "version": 2, "kernel": true}]}
This is important, because VM management software (i.e. libvirt) need to be able to figure out what guest configurations are supported. |
|
| 2016-04-22 22:47:20 |
Serge Hallyn |
summary |
[FFE] support query-gic-version QMP command |
support query-gic-version QMP command |
|
| 2016-05-14 02:37:33 |
Launchpad Janitor |
qemu (Ubuntu): status |
Confirmed |
Fix Released |
|
| 2016-05-18 21:12:21 |
dann frazier |
bug task added |
|
libvirt (Ubuntu) |
|
| 2016-05-18 22:14:07 |
dann frazier |
description |
[Note - the patches are all upstream, so risk on this patchset should be low]
There currently is no interface for an external tool to determine what GIC versions can be used by guests on the current hardware/QEMU combination. Upstream patches have recently landed to solve this problem, exposing a QMP interface for probing the system:
dannf@mustang:~$ telnet localhost 4444
Trying ::1...
Connected to localhost.
Escape character is '^]'.
{"QMP": {"version": {"qemu": {"micro": 0, "minor": 5, "major": 2}, "package": " (Debian 1:2.5+dfsg-5ubuntu6)"}, "capabilities": []}}
{ "execute": "qmp_capabilities" }
{"return": {}}
{ "execute": "query-gic-capabilities" }
{"return": [{"emulated": false, "version": 3, "kernel": false}, {"emulated": true, "version": 2, "kernel": true}]}
This is important, because VM management software (i.e. libvirt) need to be able to figure out what guest configurations are supported. |
[Impact]
TLDR; It is not currently possible to define a libvirt KVM guest that will boot on any arm64 system. This breaks assumptions of higher level tools like nova and virt-install.
ARM systems can only boot KVM guests that have the same GIC (Generic Interrupt Controller) version as the host. GICv2 is the QEMU default but, if your system does not have a GICv2, you need to know your GIC version and pass that down to the QEMU command line (e.g. -M virt,gic_version=3). If you (or your tools) don't know to do that, your guests will just fail to boot on non-GICv2 hosts with the obscure error "Failed to set device address: No such device". Starting with Ubuntu 16.04, we support at least one GICv3-only system (Cavium ThunderX).
Recent changes to QEMU and libvirt have improved this situation. QEMU now exposes a "query-gic-capabilities" QMP interface that can let the caller ask what GIC types are available for guests to use on that host. libvirt can now make use of this QEMU interface, and expose that information to users via the domcapabilities interface. Further, the user can specify a gic version of "host" to have libvirt choose a detected GIC version, or the user can omit the <gic> feature altogether, and libvirt will choose a GIC version supported by the host and update the guest XML appropriately. This allows tools like virt-install and nova to generate GIC-agnostic XML that can boot on any arm64 host.
[Test Case]
Detection. Run this command on an arm64 host:
$ sudo virsh domcapabilities --machine virt --virttype kvm
After the update, you should see a <gic> capability with a list of supported GIC versions that match the host system.
Runtime1. Place the attached gic.xml file in /etc/libvirt/qemu.
$ sudo virsh define /etc/libvirt/qemu/gic.xml
$ sudo virsh start /etc/libvirt/qemu/gic.xml
Prior to this update, it will error out with:
error: XML error: malformed gic version: host
After the update, it'll boot using whatever GIC version is available on your system.
Runtime2. On a GICv3 system, edit the gic.xml file and remove the <gic version='host'/> line.
$ sudo virsh define /etc/libvirt/qemu/gic.xml
$ sudo virsh start /etc/libvirt/qemu/gic.xml
Prior to this update, this will fail with an I/O error. After this update, it will succeed, and a <gic version='3'/> setting will be added to the XML.
[Regression Risk]
These patches are all upstream, so risk on this patchset should be low.
The change to both QEMU and libvirt are backwards compatible with the existing versions in xenial. If no GIC version is specified, QEMU still defaults to GICv2. If a GIC is specified w/o a version, libvirt continues to default to GICv2. |
|
| 2016-05-18 22:14:10 |
dann frazier |
libvirt (Ubuntu): status |
New |
Confirmed |
|
| 2016-05-18 22:16:37 |
dann frazier |
description |
[Impact]
TLDR; It is not currently possible to define a libvirt KVM guest that will boot on any arm64 system. This breaks assumptions of higher level tools like nova and virt-install.
ARM systems can only boot KVM guests that have the same GIC (Generic Interrupt Controller) version as the host. GICv2 is the QEMU default but, if your system does not have a GICv2, you need to know your GIC version and pass that down to the QEMU command line (e.g. -M virt,gic_version=3). If you (or your tools) don't know to do that, your guests will just fail to boot on non-GICv2 hosts with the obscure error "Failed to set device address: No such device". Starting with Ubuntu 16.04, we support at least one GICv3-only system (Cavium ThunderX).
Recent changes to QEMU and libvirt have improved this situation. QEMU now exposes a "query-gic-capabilities" QMP interface that can let the caller ask what GIC types are available for guests to use on that host. libvirt can now make use of this QEMU interface, and expose that information to users via the domcapabilities interface. Further, the user can specify a gic version of "host" to have libvirt choose a detected GIC version, or the user can omit the <gic> feature altogether, and libvirt will choose a GIC version supported by the host and update the guest XML appropriately. This allows tools like virt-install and nova to generate GIC-agnostic XML that can boot on any arm64 host.
[Test Case]
Detection. Run this command on an arm64 host:
$ sudo virsh domcapabilities --machine virt --virttype kvm
After the update, you should see a <gic> capability with a list of supported GIC versions that match the host system.
Runtime1. Place the attached gic.xml file in /etc/libvirt/qemu.
$ sudo virsh define /etc/libvirt/qemu/gic.xml
$ sudo virsh start /etc/libvirt/qemu/gic.xml
Prior to this update, it will error out with:
error: XML error: malformed gic version: host
After the update, it'll boot using whatever GIC version is available on your system.
Runtime2. On a GICv3 system, edit the gic.xml file and remove the <gic version='host'/> line.
$ sudo virsh define /etc/libvirt/qemu/gic.xml
$ sudo virsh start /etc/libvirt/qemu/gic.xml
Prior to this update, this will fail with an I/O error. After this update, it will succeed, and a <gic version='3'/> setting will be added to the XML.
[Regression Risk]
These patches are all upstream, so risk on this patchset should be low.
The change to both QEMU and libvirt are backwards compatible with the existing versions in xenial. If no GIC version is specified, QEMU still defaults to GICv2. If a GIC is specified w/o a version, libvirt continues to default to GICv2. |
[Impact]
TLDR; It is not currently possible to define a libvirt KVM guest that will boot on any arm64 system. This breaks assumptions of higher level tools like nova and virt-install.
ARM systems can only boot KVM guests that have the same GIC (Generic Interrupt Controller) version as the host. GICv2 is the QEMU default but, if your system does not have a GICv2, you need to know your GIC version and pass that down to the QEMU command line (e.g. -M virt,gic_version=3). If you (or your tools) don't know to do that, your guests will just fail to boot on non-GICv2 hosts with the obscure error "Failed to set device address: No such device". Starting with Ubuntu 16.04, we support at least one GICv3-only system (Cavium ThunderX).
I consider this a hardware enablement issue, and seek SRU approval based on that criteria.
Recent changes to QEMU and libvirt have improved this situation. QEMU now exposes a "query-gic-capabilities" QMP interface that can let the caller ask what GIC types are available for guests to use on that host. libvirt can now make use of this QEMU interface, and expose that information to users via the domcapabilities interface. Further, the user can specify a gic version of "host" to have libvirt choose a detected GIC version, or the user can omit the <gic> feature altogether, and libvirt will choose a GIC version supported by the host and update the guest XML appropriately. This allows tools like virt-install and nova to generate GIC-agnostic XML that can boot on any arm64 host.
[Test Case]
Detection. Run this command on an arm64 host:
$ sudo virsh domcapabilities --machine virt --virttype kvm
After the update, you should see a <gic> capability with a list of supported GIC versions that match the host system.
Runtime1. Place the attached gic.xml file in /etc/libvirt/qemu.
$ sudo virsh define /etc/libvirt/qemu/gic.xml
$ sudo virsh start /etc/libvirt/qemu/gic.xml
Prior to this update, it will error out with:
error: XML error: malformed gic version: host
After the update, it'll boot using whatever GIC version is available on your system.
Runtime2. On a GICv3 system, edit the gic.xml file and remove the <gic version='host'/> line.
$ sudo virsh define /etc/libvirt/qemu/gic.xml
$ sudo virsh start /etc/libvirt/qemu/gic.xml
Prior to this update, this will fail with an I/O error. After this update, it will succeed, and a <gic version='3'/> setting will be added to the XML.
[Regression Risk]
These patches are all upstream, so risk on this patchset should be low.
The change to both QEMU and libvirt are backwards compatible with the existing versions in xenial. If no GIC version is specified, QEMU still defaults to GICv2. If a GIC is specified w/o a version, libvirt continues to default to GICv2. |
|
| 2016-05-18 22:16:47 |
dann frazier |
nominated for series |
|
Ubuntu Xenial |
|
| 2016-05-18 22:16:47 |
dann frazier |
bug task added |
|
qemu (Ubuntu Xenial) |
|
| 2016-05-18 22:16:47 |
dann frazier |
bug task added |
|
libvirt (Ubuntu Xenial) |
|
| 2016-05-18 22:16:54 |
dann frazier |
libvirt (Ubuntu Xenial): status |
New |
Confirmed |
|
| 2016-05-18 22:16:57 |
dann frazier |
qemu (Ubuntu Xenial): status |
New |
Confirmed |
|
| 2016-05-18 23:11:15 |
dann frazier |
attachment added |
|
sample xml for test case https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1566564/+attachment/4665863/+files/gic.xml |
|
| 2016-05-18 23:11:46 |
dann frazier |
attachment added |
|
debdiff for libvirt/yakkety https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1566564/+attachment/4665864/+files/libvirt-yakkety.debdiff |
|
| 2016-05-19 17:01:11 |
Raghuram Kota |
bug |
|
|
added subscriber Raghuram Kota |
| 2016-05-19 17:01:24 |
Raghuram Kota |
tags |
arm64 armhf patch |
arm64 armhf hs-arm64 patch |
|
| 2016-05-19 18:18:28 |
dann frazier |
libvirt (Ubuntu): status |
Confirmed |
In Progress |
|
| 2016-05-19 19:59:57 |
dann frazier |
attachment added |
|
proposed patch for libvirt in xenial https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1566564/+attachment/4666427/+files/libvirt-xenial.debdiff |
|
| 2016-05-19 20:00:40 |
dann frazier |
attachment added |
|
proposed patch for qemu in xenial https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1566564/+attachment/4666428/+files/qemu-xenial.debdiff |
|
| 2016-05-20 07:09:50 |
Andrew Cloke |
bug |
|
|
added subscriber Andrew Cloke |
| 2016-05-23 22:14:45 |
Launchpad Janitor |
libvirt (Ubuntu): status |
In Progress |
Fix Released |
|
| 2016-06-09 17:22:59 |
Brian Murray |
qemu (Ubuntu Xenial): status |
Confirmed |
Fix Committed |
|
| 2016-06-09 17:23:01 |
Brian Murray |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2016-06-09 17:23:07 |
Brian Murray |
bug |
|
|
added subscriber SRU Verification |
| 2016-06-09 17:23:13 |
Brian Murray |
tags |
arm64 armhf hs-arm64 patch |
arm64 armhf hs-arm64 patch verification-needed |
|
| 2016-06-09 17:27:19 |
Brian Murray |
libvirt (Ubuntu Xenial): status |
Confirmed |
Fix Committed |
|
| 2016-06-09 20:25:20 |
dann frazier |
description |
[Impact]
TLDR; It is not currently possible to define a libvirt KVM guest that will boot on any arm64 system. This breaks assumptions of higher level tools like nova and virt-install.
ARM systems can only boot KVM guests that have the same GIC (Generic Interrupt Controller) version as the host. GICv2 is the QEMU default but, if your system does not have a GICv2, you need to know your GIC version and pass that down to the QEMU command line (e.g. -M virt,gic_version=3). If you (or your tools) don't know to do that, your guests will just fail to boot on non-GICv2 hosts with the obscure error "Failed to set device address: No such device". Starting with Ubuntu 16.04, we support at least one GICv3-only system (Cavium ThunderX).
I consider this a hardware enablement issue, and seek SRU approval based on that criteria.
Recent changes to QEMU and libvirt have improved this situation. QEMU now exposes a "query-gic-capabilities" QMP interface that can let the caller ask what GIC types are available for guests to use on that host. libvirt can now make use of this QEMU interface, and expose that information to users via the domcapabilities interface. Further, the user can specify a gic version of "host" to have libvirt choose a detected GIC version, or the user can omit the <gic> feature altogether, and libvirt will choose a GIC version supported by the host and update the guest XML appropriately. This allows tools like virt-install and nova to generate GIC-agnostic XML that can boot on any arm64 host.
[Test Case]
Detection. Run this command on an arm64 host:
$ sudo virsh domcapabilities --machine virt --virttype kvm
After the update, you should see a <gic> capability with a list of supported GIC versions that match the host system.
Runtime1. Place the attached gic.xml file in /etc/libvirt/qemu.
$ sudo virsh define /etc/libvirt/qemu/gic.xml
$ sudo virsh start /etc/libvirt/qemu/gic.xml
Prior to this update, it will error out with:
error: XML error: malformed gic version: host
After the update, it'll boot using whatever GIC version is available on your system.
Runtime2. On a GICv3 system, edit the gic.xml file and remove the <gic version='host'/> line.
$ sudo virsh define /etc/libvirt/qemu/gic.xml
$ sudo virsh start /etc/libvirt/qemu/gic.xml
Prior to this update, this will fail with an I/O error. After this update, it will succeed, and a <gic version='3'/> setting will be added to the XML.
[Regression Risk]
These patches are all upstream, so risk on this patchset should be low.
The change to both QEMU and libvirt are backwards compatible with the existing versions in xenial. If no GIC version is specified, QEMU still defaults to GICv2. If a GIC is specified w/o a version, libvirt continues to default to GICv2. |
[Impact]
TLDR; It is not currently possible to define a libvirt KVM guest that will boot on any arm64 system. This breaks assumptions of higher level tools like nova and virt-install.
ARM systems can only boot KVM guests that have the same GIC (Generic Interrupt Controller) version as the host. GICv2 is the QEMU default but, if your system does not have a GICv2, you need to know your GIC version and pass that down to the QEMU command line (e.g. -M virt,gic_version=3). If you (or your tools) don't know to do that, your guests will just fail to boot on non-GICv2 hosts with the obscure error "Failed to set device address: No such device". Starting with Ubuntu 16.04, we support at least one GICv3-only system (Cavium ThunderX).
I consider this a hardware enablement issue, and seek SRU approval based on that criteria.
Recent changes to QEMU and libvirt have improved this situation. QEMU now exposes a "query-gic-capabilities" QMP interface that can let the caller ask what GIC types are available for guests to use on that host. libvirt can now make use of this QEMU interface, and expose that information to users via the domcapabilities interface. Further, the user can specify a gic version of "host" to have libvirt choose a detected GIC version, or the user can omit the <gic> feature altogether, and libvirt will choose a GIC version supported by the host and update the guest XML appropriately. This allows tools like virt-install and nova to generate GIC-agnostic XML that can boot on any arm64 host.
[Test Case]
Detection. Run this command on an arm64 host:
$ sudo virsh domcapabilities --machine virt --virttype kvm
After the update, you should see a <gic> capability with a list of supported GIC versions that match the host system.
Runtime1. Place the attached gic.xml file in /etc/libvirt/qemu.
$ sudo virsh define /etc/libvirt/qemu/gic.xml
$ sudo virsh start gic
Prior to this update, it will error out with:
error: XML error: malformed gic version: host
After the update, it'll boot using whatever GIC version is available on your system.
Runtime2. On a GICv3 system, edit the gic.xml file and remove the <gic version='host'/> line.
$ sudo virsh define /etc/libvirt/qemu/gic.xml
$ sudo virsh start /etc/libvirt/qemu/gic.xml
Prior to this update, this will fail with an I/O error. After this update, it will succeed, and a <gic version='3'/> setting will be added to the XML.
[Regression Risk]
These patches are all upstream, so risk on this patchset should be low.
The change to both QEMU and libvirt are backwards compatible with the existing versions in xenial. If no GIC version is specified, QEMU still defaults to GICv2. If a GIC is specified w/o a version, libvirt continues to default to GICv2. |
|
| 2016-06-09 21:24:14 |
dann frazier |
tags |
arm64 armhf hs-arm64 patch verification-needed |
arm64 armhf hs-arm64 patch verification-done |
|
| 2016-06-20 09:25:09 |
Martin Pitt |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2016-06-20 09:25:17 |
Launchpad Janitor |
libvirt (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
| 2016-06-20 09:27:32 |
Launchpad Janitor |
qemu (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
