From b2e00f1aa259207a545eb885ece0f0fd6648257c Mon Sep 17 00:00:00 2001 From: David Gibson Date: Tue, 12 Jul 2016 16:54:03 +1000 Subject: [PATCH 19/21] vfio/spapr: Remove stale ioctl() call This ioctl() call to VFIO_IOMMU_SPAPR_TCE_REMOVE was left over from an earlier version of the code and has since been folded into vfio_spapr_remove_window(). It wasn't caught because although the argument structure has been removed, the libc function remove() means this didn't trigger a compile failure. The ioctl() was also almost certain to fail silently and harmlessly with the bogus argument, so this wasn't caught in testing. Suggested-by: Paolo Bonzini Signed-off-by: David Gibson Reviewed-by: Alexey Kardashevskiy (cherry picked from commit 21bb3093e6accd2d7d60531a472a34e40911acd9) Signed-off-by: Michael Roth --- hw/vfio/spapr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/vfio/spapr.c b/hw/vfio/spapr.c index 0af3423..7443d34 100644 --- a/hw/vfio/spapr.c +++ b/hw/vfio/spapr.c @@ -177,7 +177,6 @@ int vfio_spapr_create_window(VFIOContainer *container, error_report("Host doesn't support DMA window at %"HWADDR_PRIx", must be %"PRIx64, section->offset_within_address_space, (uint64_t)create.start_addr); - ioctl(container->fd, VFIO_IOMMU_SPAPR_TCE_REMOVE, &remove); return -EINVAL; } trace_vfio_spapr_create_window(create.page_shift, -- 1.9.1