Activity log for bug #584143

Date Who What changed Old value New value Message
2010-05-22 09:21:04 Michael Tokarev bug added bug
2010-05-22 16:10:51 Loïc Minier bug watch added http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=573439
2010-05-22 16:10:51 Loïc Minier bug task added qemu-kvm (Debian)
2010-05-22 16:13:26 Loïc Minier bug task added qemu-kvm (Ubuntu)
2010-05-24 14:55:39 C de-Avillez qemu-kvm (Ubuntu): importance Undecided Medium
2010-05-24 14:55:39 C de-Avillez qemu-kvm (Ubuntu): status New Triaged
2010-05-24 14:56:05 C de-Avillez nominated for series Ubuntu Lucid
2010-05-24 14:56:05 C de-Avillez bug task added qemu-kvm (Ubuntu Lucid)
2010-06-02 20:34:25 Luiz Capitulino qemu: status New In Progress
2010-06-16 20:03:35 Rob qemu-kvm (Ubuntu Lucid): status New Confirmed
2011-01-01 14:34:37 Aurelien Jarno qemu: status In Progress Fix Committed
2011-02-20 17:13:26 Aurelien Jarno qemu: status Fix Committed Fix Released
2011-03-14 22:30:51 Serge Hallyn qemu-kvm (Ubuntu): assignee Serge Hallyn (serge-hallyn)
2011-03-14 22:31:34 Serge Hallyn nominated for series Ubuntu Maverick
2011-03-14 22:31:34 Serge Hallyn bug task added qemu-kvm (Ubuntu Maverick)
2011-03-14 22:31:49 Serge Hallyn qemu-kvm (Ubuntu): status Triaged Fix Released
2011-03-14 22:31:55 Serge Hallyn qemu-kvm (Ubuntu Lucid): assignee Serge Hallyn (serge-hallyn)
2011-03-14 22:32:00 Serge Hallyn qemu-kvm (Ubuntu Maverick): assignee Serge Hallyn (serge-hallyn)
2011-03-15 02:48:32 Launchpad Janitor branch linked lp:~serge-hallyn/ubuntu/lucid/qemu-kvm/hdd-serial
2011-03-15 02:54:07 Launchpad Janitor branch linked lp:~serge-hallyn/ubuntu/maverick/qemu-kvm/hdd-serial
2011-03-15 04:05:59 Serge Hallyn attachment added amd64 debs for lucid https://bugs.launchpad.net/qemu/+bug/584143/+attachment/1909175/+files/hdd-lucid-debs.tgz
2011-03-15 04:13:51 Serge Hallyn attachment added amd64 debs for maverick https://bugs.launchpad.net/qemu/+bug/584143/+attachment/1909178/+files/hdd-mav-debs.tgz
2011-03-15 04:25:50 Serge Hallyn qemu-kvm (Ubuntu Maverick): status New In Progress
2011-03-15 04:25:55 Serge Hallyn qemu-kvm (Ubuntu Lucid): status Confirmed In Progress
2011-03-15 13:37:50 Serge Hallyn description The -drive ...,serial=xyz option is broken, at least in 0.12. See Debian bug#573439, http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=573439 for details. The proposed fix from the original reporter: --- qemu-kvm-0.12.3+dfsg/vl.c 2010-02-26 11:34:00.000000000 +0900 +++ qemu-kvm-0.12.3+dfsg.old/vl.c 2010-03-11 02:26:00.134217787 +0900 @@ -2397,7 +2397,7 @@ dinfo->on_write_error = on_write_error; dinfo->opts = opts; if (serial) - strncpy(dinfo->serial, serial, sizeof(serial)); + strncpy(dinfo->serial, serial, sizeof(dinfo->serial)); QTAILQ_INSERT_TAIL(&drives, dinfo, next); if (is_extboot) { extboot_drive = dinfo; ========================================= SRU Justification: 1. Impact: 'qemu -drive ...,serial=xyz' does not work 2. How addressed: a patch from upstream fixes bug that sizeof was called on the wrong thing. 3. patch: is in the description 4. to reproduce: use '-drive ...,serial=xyz' option to qemu 5. regression potential: this only changes one line which called sizeof on the wrong thing, so should not impact any other code. ========================================= The -drive ...,serial=xyz option is broken, at least in 0.12. See Debian bug#573439, http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=573439 for details. The proposed fix from the original reporter: --- qemu-kvm-0.12.3+dfsg/vl.c 2010-02-26 11:34:00.000000000 +0900 +++ qemu-kvm-0.12.3+dfsg.old/vl.c 2010-03-11 02:26:00.134217787 +0900 @@ -2397,7 +2397,7 @@      dinfo->on_write_error = on_write_error;      dinfo->opts = opts;      if (serial) - strncpy(dinfo->serial, serial, sizeof(serial)); + strncpy(dinfo->serial, serial, sizeof(dinfo->serial));      QTAILQ_INSERT_TAIL(&drives, dinfo, next);      if (is_extboot) {          extboot_drive = dinfo;
2011-03-15 13:38:07 Serge Hallyn bug added subscriber Ubuntu Stable Release Updates Team
2011-03-15 22:34:16 Serge Hallyn tags patch patch verification-needed
2011-08-10 23:02:35 Bug Watch Updater qemu-kvm (Debian): status Unknown Fix Released
2013-07-06 11:34:53 Adolfo Jayme Barrientos bug task deleted qemu-kvm (Ubuntu Lucid)
2013-07-06 11:34:55 Adolfo Jayme Barrientos bug task deleted qemu-kvm (Ubuntu Maverick)