[SRU] python-pylxd 2.0.7 (xenial), python-pylxd 2.2.6 (artful)

Bug #1754657 reported by Corey Bryant on 2018-03-09
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Cloud Archive
Undecided
Unassigned
Mitaka
Undecided
Unassigned
Pike
Undecided
Unassigned
python-pylxd (Ubuntu)
Undecided
Unassigned
Xenial
Undecided
Unassigned
Artful
Undecided
Unassigned

Bug Description

[Impact]
This SRU gets us to the latest pylxd point releases for xenial and artful.

[Test Case]
Upstream integration tests will be run against the python-pylxd installed from -proposed: https://github.com/lxc/pylxd/blob/master/run_integration_tests

Instead of running 'tox -e integration' run 'nosetests integration'.

[Regresion Potential]
Regression potential is minimal. This is an upstream patch version update to the same major/minor 2.0.x version that is already in xenial.

Changed in python-pylxd (Ubuntu):
status: New → Invalid
Corey Bryant (corey.bryant) wrote :

I've uploaded python-pylxd 2.0.7 to the xenial Unapproved queue where it is awaiting SRU team review: https://launchpad.net/ubuntu/xenial/+queue?queue_state=1&queue_text=

Note to SRU team: There are currently two python-pylxd 2.0.7-0ubuntu1 uploads in the queue. The new one is good and ready for review. The older one should be rejected.

description: updated
summary: - [SRU] python-pylxd 2.0.7
+ [SRU] python-pylxd 2.0.7 (xenial), python-pylxd 2.2.6 (artful)
description: updated

Hello Corey, or anyone else affected,

Accepted python-pylxd into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python-pylxd/2.0.7-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in python-pylxd (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed verification-needed-xenial
Corey Bryant (corey.bryant) wrote :

Hello Corey, or anyone else affected,

Accepted python-pylxd into mitaka-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:mitaka-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-mitaka-needed to verification-mitaka-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-mitaka-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-mitaka-needed
Alex Kavanagh (ajkavanagh) wrote :

So tested this manually on xenial (pylxd/lxd) and it's all working perfectly.

Also checked with lxd charm/nova-compute (mitaka) to verify that the nova-compute/nova-lxd/pylxd combo works; did this by running up an openstack bundle (openstack-bundles/development/openstack-lxd-xenial-mitaka) and used distro-proposed for nova-compute. This pulls in lxd 2.1 and pylxd 2.0.7 on xenial.

tags: added: verification-mitaka-done verification-xenial-done
removed: verification-mitaka-needed verification-needed-xenial
tags: added: verification-artful-needed
Alex Kavanagh (ajkavanagh) wrote :

I can't check artful as pylxd 2.2.6 doesn't appear in artful-proposed yet.

Corey Bryant (corey.bryant) wrote :

I don't completely remember why but I think 2.2.6 wasn't available at the time that 2.0.7 was uploaded. Either way, I don't think it ever got uploaded so I'll do that now.

Corey Bryant (corey.bryant) wrote :

I've uploaded 2.2.6 to the artful review queue [1] where it is awaiting review by the SRU team.

[1] https://launchpad.net/ubuntu/artful/+queue?queue_state=1&queue_text=

Alex Kavanagh (ajkavanagh) wrote :

@corey.bryant -- I probably didn't have 2.2.6 ready at the time; sorry. I'll test it as soon as it becomes available in proposed. Thanks.

Łukasz Zemczak (sil2100) wrote :

Just want to confirm: do the python*-requests-toolbelt build-dependencies result in any binary dependencies in the end binary packages? I'm asking as python-pylxd is in main while python-requests-toolbelt is still in universe in artful for instance. Wouldn't want a component mismatch with this SRU.

Corey Bryant (corey.bryant) wrote :

That is a great catch, and an issue in bionic and cosmic as well, so we'll need fixes in those releases first. I think we can add it via Suggests in Artful and Depends in Bionic/Cosmic (since it's in main for the latter). The reason python-pylxd is in main is due to use by nova-lxd, which doesn't use the Image.create() method. Rather, pre-built images are retrieved from glance in the case of nova-lxd. Since that's the case I think we can consider this dependency as being optional and add it as a Suggests for Artful in this SRU.

Alex, can you confirm my understanding before we move forward?

Corey Bryant (corey.bryant) wrote :

I've opened the following bug to track the missing python(3)-requests-toolbelt issue: https://bugs.launchpad.net/ubuntu/+source/python-pylxd/+bug/1775238

Corey Bryant (corey.bryant) wrote :

I've uploaded a new version of python-pylxd to Artful with python(3)-requests-toolbelt added to Suggests, and have also uploaded Bionic and Cosmic versions of python-pylxd with python(3)-requests-toolbelt fixed via the above linked bug.

Alex Kavanagh (ajkavanagh) wrote :

@sil2100, that is a good catch, and sadly, Corey, there isn't an easy solution. What requests.toolbelt is used for is to allow Multipart uploads to lxd (from pylxd) so that data can be streamed from disk, rather than pulled into memory.

nova-lxd DOES use this feature, in that it grabs the image from the archive to disk, and then uses the requests.toolbelt streaming feature to stream it from disk to lxd.

So, awkwardly, nova-lxd does require the pylxd requests-toolbelt package, which isn't in main. The best "solution" would be to get requests-toolbelt into main alongside requests, but that may not be feasible/desirable. Could we get it into cloud-archive instead?

Corey Bryant (corey.bryant) wrote :

OK thanks for checking. I see that the version of nova-lxd in bionic uses images create() but I'm not seeing a similar call in the xenial version. Is it possible the xenial version of nova-lxd doesn't use it?

Alex Kavanagh (ajkavanagh) wrote :

@Corey, yes, you're correct; xenial doesn't use it; It first appeared in 2.2.5, and xenial is on the 2.0.x series. So artful got 2.2.x series, which means artful has the issue, whereas xenial as 2.0.7 which means it doesn't have this feature (as we didn't backport it).

Corey Bryant (corey.bryant) wrote :

Sorry, confusing releases on my end. Ok so we'd have to move python(3)-requests-toolbelt to Depends, which would require it to be in main, if we were to upload to Artful. Artful is almost EOL so let's see if we can handle this in the cloud-archive only.

Changed in python-pylxd (Ubuntu Artful):
status: New → Won't Fix
Corey Bryant (corey.bryant) wrote :

@sil2100, please can you reject the python-pylxd uploads in the Artful queue?

Corey Bryant (corey.bryant) wrote :

Hello Corey, or anyone else affected,

Accepted python-pylxd into pike-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:pike-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-pike-needed to verification-pike-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-pike-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-pike-needed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers