| 2018-08-09 19:54:43 |
Simon Quigley |
bug |
|
|
added bug |
| 2018-08-09 19:54:59 |
Simon Quigley |
bug watch added |
|
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=905796 |
|
| 2018-08-09 19:54:59 |
Simon Quigley |
bug task added |
|
python-phabricator (Debian) |
|
| 2018-08-09 19:56:47 |
Simon Quigley |
nominated for series |
|
Ubuntu Bionic |
|
| 2018-08-09 19:56:47 |
Simon Quigley |
bug task added |
|
python-phabricator (Ubuntu Bionic) |
|
| 2018-08-09 19:56:47 |
Simon Quigley |
nominated for series |
|
Ubuntu Cosmic |
|
| 2018-08-09 19:56:47 |
Simon Quigley |
bug task added |
|
python-phabricator (Ubuntu Cosmic) |
|
| 2018-08-09 19:56:53 |
Simon Quigley |
python-phabricator (Ubuntu Bionic): status |
New |
Confirmed |
|
| 2018-08-09 19:56:55 |
Simon Quigley |
python-phabricator (Ubuntu Cosmic): status |
New |
Confirmed |
|
| 2018-08-09 19:56:56 |
Simon Quigley |
python-phabricator (Ubuntu Bionic): importance |
Undecided |
High |
|
| 2018-08-09 19:56:57 |
Simon Quigley |
python-phabricator (Ubuntu Cosmic): importance |
Undecided |
High |
|
| 2018-08-09 19:56:59 |
Simon Quigley |
python-phabricator (Ubuntu Bionic): assignee |
|
Simon Quigley (tsimonq2) |
|
| 2018-08-09 19:57:00 |
Simon Quigley |
python-phabricator (Ubuntu Cosmic): assignee |
|
Simon Quigley (tsimonq2) |
|
| 2018-08-09 20:06:29 |
Simon Quigley |
python-phabricator (Ubuntu Cosmic): status |
Confirmed |
Fix Committed |
|
| 2018-08-09 21:05:59 |
Launchpad Janitor |
python-phabricator (Ubuntu Cosmic): status |
Fix Committed |
Fix Released |
|
| 2018-08-09 21:22:22 |
Simon Quigley |
description |
I'm looking to improve some Phabricator code for Lugito (Lubuntu's Python script which acts as a hook for commits such as IRC notifications), and I can't use diffusion.commit.search because there's no support for it yet.
>>> phab.diffusion.commit.search(constraints={"query": "a34837de8224"})
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python3/dist-packages/phabricator/__init__.py", line 248, in __call__
return self._request(**kwargs)
File "/usr/lib/python3/dist-packages/phabricator/__init__.py", line 323, in _request
data = self._parse_response(response)
File "/usr/lib/python3/dist-packages/phabricator/__init__.py", line 333, in _parse_response
raise APIError(parsed['error_code'], parsed['error_info'])
phabricator.APIError: ERR-CONDUIT-CALL: Conduit API method "commit.search" does not exist.
However, my Phabricator instance (last updated about a week ago) says this under diffusions.querycommits:
Frozen Method: This method is frozen and will eventually be deprecated. New code should use "diffusion.commit.search" instead.
A patch adding support for this is available upstream: https://github.com/disqus/python-phabricator/commit/a52c0e1357532f9ef8b26321d3728a0edead6ed4
This needs to be backported, or functionality will be lost. |
[Impact]
Without this, users of the API will eventually be unable to search commits in Phabricator, something that is essential to some programs.
[Test Case]
In the Python interactive console, first import the library:
phab = Phabricator(host="https://phab.lubuntu.me/api/", token="API KEY")
(for example)
Then, with an example commit hash, run this:
phab.diffusion.commit.search(constraints={"query": "a34837de8224"})
It should correctly return a result, rather than erroring out as shown below.
[Regression Potential]
Very unlikely. If the interpretation of the JSON file somehow changes in the underlying Python code, it could regress, but the more likely scenario is that the API changes again in upstream Phabricator, which will need another SRU to adjust.
[Original Description]
I'm looking to improve some Phabricator code for Lugito (Lubuntu's Python script which acts as a hook for commits such as IRC notifications), and I can't use diffusion.commit.search because there's no support for it yet.
>>> phab.diffusion.commit.search(constraints={"query": "a34837de8224"})
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python3/dist-packages/phabricator/__init__.py", line 248, in __call__
return self._request(**kwargs)
File "/usr/lib/python3/dist-packages/phabricator/__init__.py", line 323, in _request
data = self._parse_response(response)
File "/usr/lib/python3/dist-packages/phabricator/__init__.py", line 333, in _parse_response
raise APIError(parsed['error_code'], parsed['error_info'])
phabricator.APIError: ERR-CONDUIT-CALL: Conduit API method "commit.search" does not exist.
However, my Phabricator instance (last updated about a week ago) says this under diffusions.querycommits:
Frozen Method: This method is frozen and will eventually be deprecated. New code should use "diffusion.commit.search" instead.
A patch adding support for this is available upstream: https://github.com/disqus/python-phabricator/commit/a52c0e1357532f9ef8b26321d3728a0edead6ed4
This needs to be backported, or functionality will be lost. |
|
| 2018-08-10 14:56:09 |
Bug Watch Updater |
python-phabricator (Debian): status |
Unknown |
New |
|
| 2018-08-10 22:53:05 |
Brian Murray |
python-phabricator (Ubuntu Bionic): status |
Confirmed |
Fix Committed |
|
| 2018-08-10 22:53:07 |
Brian Murray |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2018-08-10 22:53:09 |
Brian Murray |
bug |
|
|
added subscriber SRU Verification |
| 2018-08-10 22:53:12 |
Brian Murray |
tags |
|
verification-needed verification-needed-bionic |
|
| 2018-11-13 18:47:26 |
Brian Murray |
tags |
verification-needed verification-needed-bionic |
removal-candidate verification-needed verification-needed-bionic |
|
| 2018-12-10 00:07:39 |
Thomas Ward |
tags |
removal-candidate verification-needed verification-needed-bionic |
removal-candidate verification-done verification-done-bionic |
|
| 2018-12-11 15:43:44 |
Launchpad Janitor |
python-phabricator (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
| 2018-12-11 15:43:51 |
Brian Murray |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
