Comment 2 for bug 1943143

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

[Summary]
MIR team ACK
This does need a security review, so I'll assign ubuntu-security
List of specific binary packages to be promoted to main:
- python3-oslo.metrics

Required TODOs:
- none
Recommended TODOs:
- Better Subscribe early to the package than forgetting it later

[Duplication]
python3-ceilometermiddleware is similar but for other elements of OpenStack.
But that one would be universe anyway.
So no, there is no other package in main providing the same functionality.

[Dependencies]
OK:
- no other Dependencies to MIR due to this (python3-prometheus-client is
  part of this MIR)
- no -dev/-debug/-doc packages that need exclusion

[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking

[Security]
OK:
- history of CVEs does not look concerning (there are a
  few in oslo, but none in the metrics so far)
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not open a port
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)

Problems:
- does not parse data formats
- routes messages which if crafted correctly might be a problem
=> worth a security review

[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
  - test suite fails will fail the build upon error.
- does have a non-trivial test suite that runs as autopkgtest
- no translation present, but none needed for this case (user visible)?
- no new python2 dependency
- Python package that is using dh_python

Problems:
- remember to subscribe to the package, could not find it for
  openstack-ubuntu-packagers or openstack-packagers

[Packaging red flags]
OK:
- Ubuntu does not carry a delta (still stuck in new queue there)
- symbols tracking not applicable for this kind of code.
- d/watch is present and looks ok
- Upstream update history is good (but rather young)
- Ubuntu update history is unclear (no history yet)
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
  maintained the package
- no massive Lintian warnings
- d/rules is rather clean
- Does not have Built-Using
- is not on the lto-disabled list

[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (python)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH
- no use of user nobody
- no use of setuid
- no important open bugs (crashers, etc) in Debian or Ubuntu or Upstream
- no dependency on webkit, qtwebkit, seed or libgoa-*
- not part of the UI for extra checks