[Summary] MIR Team ACK for python-oslo.limit This does NOT need a security review, got the ack and is shown in component mismatches already - so I'll mark it as Fix Committed for promotion. List of specific binary packages to be promoted to main: python3-oslo.limit Required TODOs: - none Recommended TODOs: - an autopkgtest using the fixture that is provided could help to spot issues earlier than on a rebuild (the same applies to some other already promoted python-oslo.* packages) [Duplication] There is no other package in main providing the same functionality. There is a more detailed reasoning in the spec https://specs.openstack.org/openstack/oslo-specs/specs/rocky/oslo-limit.html The alternative "delimiter" is not in main and no more active. [Dependencies] OK: - no other Dependencies to MIR due to this Deps are python3-keystoneauth1 python3-openstacksdk python3-oslo.config python3-oslo.i18n python3-oslo.log python3 which are all in main - no -dev/-debug/-doc packages that need exclusion [Embedded sources and static linking] OK: - no embedded source present - no static linking [Security] OK: - history of CVEs does not look concerning - does not run a daemon as root - does not use webkit1,2 - does not use lib*v8 directly - does not open a port - does not process arbitrary web content - does not use centralized online accounts - does not integrate arbitrary javascript into the desktop - does not deal with system authentication (eg, pam), etc) Problems: - It does parse data formats in some way, but none externally controllable as I could see Due to the place this is in the openstack stack and what it does I do not think this needs an extra security review. [Common blockers] OK: - does not FTBFS currently - does have a test suite that runs at build time - test suite fails will fail the build upon error. - The package has a team bug subscriber - no translation present, but none needed for this case (user visible)? - no new python2 dependency - Python package that is using dh_python Problems: - does have a test suite that runs as autopkgtest It has build time tests, the other oslo components in main also have either none or a superficial test. But there also is plenty of openstack QA that is done which IMHO is sufficient to replace the autopkgtest in this case, especially if it would only be a superficial one again. If one wants to make this better then an autopkgtest that runs the 20 self tests of the package could be useful - they would break on e.g. a new python or python library versions while the current build time test will only spot this on rebuilds. The code prepares this to be doable without a full openstack, see https://docs.openstack.org/oslo.limit/latest/user/testing.html This is recommended, but not required. [Packaging red flags] OK: - Ubuntu does not carry a delta (ubuntu only for now) - symbols tracking not applicable for this kind of code. - d/watch is present and looks ok - Upstream update history is good - Debian/Ubuntu update history is unknown, but the team has the other python-oslo bits well under control - the current release is packaged - promoting this does not seem to cause issues for MOTUs that so far maintained the package - no massive Lintian warnings - d/rules is rather clean - Does not have Built-Using - is not on the lto-disabled list [Upstream red flags] OK: - no Errors/warnings during the build - no incautious use of malloc/sprintf (python) - no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH - no use of user nobody - no use of setuid - no important open bugs (crashers, etc) in Debian or Ubuntu or Upstream - no dependency on webkit, qtwebkit, seed or libgoa-* - not part of the UI for extra checks