| 2019-07-22 08:21:31 |
zhaobo |
description |
I found we just specify tenant_id for creating SG, but force specify
project_id for creating SG rules [1]. This may cause compatible issue.
So this patch keep SG rules same with SG creation and test in upstream
CI.
This issue raises by https://review.opendev.org/#/c/662724/ , it seems a
small nit that force to specify project_id to create SG_rule. But other
resources, such as Network/SG just pass tenant_id. So it may cause some
compatible issue, or keep the same like other resources at least.
[1] https://github.com/openstack/openstacksdk/blob/master/openstack/cloud/_security_group.py#L312 |
For openstacksdk master branch:
I found we just specify tenant_id for creating SG, but force specify
project_id for creating SG rules [1]. This may cause compatible issue.
So this patch keep SG rules same with SG creation and test in upstream
CI.
This issue raises by https://review.opendev.org/#/c/662724/ , it seems a
small nit that force to specify project_id to create SG_rule. But other
resources, such as Network/SG just pass tenant_id. So it may cause some
compatible issue, or keep the same like other resources at least.
[1] https://github.com/openstack/openstacksdk/blob/master/openstack/cloud/_security_group.py#L312 |
|
