python-httplib2 needs to support SNI for OpenSSL 1.1.1

Bug #1815481 reported by Dimitri John Ledkov
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-httplib2 (Debian)
Fix Released
Unknown
python-httplib2 (Ubuntu)
Fix Released
Undecided
Unassigned
Bionic
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

 * OpenSSL 1.1.1 performs SNI hostname verification, therefore hostname SSL context option must be set when establishing the connection, otherwise, validation of SNI certificates fail and thus resulting in lack of connectivity.

[Test Case]

 * use python-httplib2 to connect to an SNI tls protected host

[Regression Potential]

 * change is compatible with pythons/openssl versions shipped in bionic-release
 * change is from upstream / tested in debian & disco
 * change improves security, and is compatible with deployed servers out there
 * hosts with certificates not matching their actual hostname will remain invalid/untrusted

[Additional info]
To install python & openssl 1.1.1 on Bionic you may enable and use the below silo, which will then exhibit the enforcement of SNI hostname verification.

sudo add-apt-repository ppa:ci-train-ppa-service/3473
sudo apt-get update

Changed in python-httplib2 (Ubuntu):
status: New → Fix Released
Changed in python-httplib2 (Ubuntu Bionic):
status: New → In Progress
summary: - python-httplib2 needs to support SNI for OpenSSL 1.1.1 Edit
+ python-httplib2 needs to support SNI for OpenSSL 1.1.1
Changed in python-httplib2 (Debian):
status: Unknown → Fix Released
tags: added: id-5c619f14f860355c5d264ba1
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Dimitri, or anyone else affected,

Accepted python-httplib2 into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python-httplib2/0.9.2+dfsg-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in python-httplib2 (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

import httplib2
h = httplib2.Http(ca_certs='/etc/ssl/certs/ca-certificates.crt')
h.request("https://www.google.com")[0]['status']
'200'

works with openssl 1.1.1 from the staging ppa, and

python-httplib2:
  Installed: 0.9.2+dfsg-1ubuntu0.1

from bionic-proposed.

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Dimitri John Ledkov (xnox) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package python-httplib2 - 0.9.2+dfsg-1ubuntu0.1

---------------
python-httplib2 (0.9.2+dfsg-1ubuntu0.1) bionic; urgency=medium

  * Cherrypick upstream fixes to set SNI hostname in python2 client. LP:
    #1815481

 -- Dimitri John Ledkov <email address hidden> Wed, 12 Dec 2018 19:20:12 +1100

Changed in python-httplib2 (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for python-httplib2 has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.