Glade *.ui files not recognized due to comment line
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| python-distutils-extra (Ubuntu) |
Undecided
|
Unassigned |
Bug Description
Glade 3.18 likes to insert a comment as the second line that upsets auto.py. Onboard's package fails to build due to this, unless we remember to remove the offending line after every change. Could you have a look?
$ cd onboard
$ ./setup.py build
...
WARNING: the following files are not recognized by DistUtilsExtra.
... many ...
settings.ui
This fixes it for me:
*** /tmp/auto.py 2014-11-16 21:03:04.244604628 +0100
--- /usr/lib/
***************
*** 305,310 ****
--- 305,311 ----
fd = open(f, 'rb')
+ firstlines += b'\n' + fd.readline()
if b'<interface' in firstlines or b'<ui version=' in firstlines:
Ubuntu Vivid
python3-
glade 3.18.3-1
Related branches
marmuta (marmuta) wrote : | #1 |
marmuta (marmuta) wrote : | #2 |
Francesco Fumanti (frafu) wrote : | #3 |
I added marmuta's solution provided in the bug description as a patch to the python-
Afterwards, I tested it against revision 2020 of the trunk branch of Onboard. Onboard was build without error while using the patched version of python-
I will add the relevant files to this bug thread.
Thanks in advance to anybody looking at this.
Francesco Fumanti (frafu) wrote : | #4 |
Francesco Fumanti (frafu) wrote : | #5 |
Francesco Fumanti (frafu) wrote : | #6 |
Francesco Fumanti (frafu) wrote : | #7 |
Francesco Fumanti (frafu) wrote : | #8 |
Francesco Fumanti (frafu) wrote : | #9 |
Francesco Fumanti (frafu) wrote : | #10 |
Francesco Fumanti (frafu) wrote : | #11 |
Francesco Fumanti (frafu) wrote : | #12 |
Francesco Fumanti (frafu) wrote : | #13 |
If you want me to also prepare packages of python-
Martin Pitt (pitti) wrote : | #14 |
Committed with a test case, thank you!
affects: | python-distutils-extra → python-distutils-extra (Ubuntu) |
Changed in python-distutils-extra (Ubuntu): | |
status: | New → Fix Committed |
Launchpad Janitor (janitor) wrote : | #15 |
This bug was fixed in the package python-
---------------
python-
* test/auto.py: Show exactly which modules are missing. Thanks Daniel Macks!
(LP: #1303550)
* Ignore comment in second line when parsing *.ui files. Thanks marmuta!
(LP: #1393247)
* Drop obsolete X-Python-Version.
* Convert build systemd to pybuild.
* Bump Standards-Version to 3.9.6.
* debian/copyright: Rename field to "Format:".
-- Martin Pitt <email address hidden> Wed, 03 Feb 2016 09:56:55 +0100
Changed in python-distutils-extra (Ubuntu): | |
status: | Fix Committed → Fix Released |
It just bit me again: /answers. launchpad. net/onboard/ +question/ 284286
https:/
Could someone have a look at this, please? It's not hard to fix at all.
Ubuntu Xenial distutils- extra 2.38-1build1
python3-
glade 3.18.3-1