ubuntu-image autopkgtests failing since python-debian 0.1.38

[Christian Ehrhardt ]

In the tests it seems that since some - yet to be found - change ~20th Nov the tests of ubuntu-image fail.

Tests all list those three sub-tests as failing:
 unittests.sh FAIL non-zero exit status 1
 qa FAIL non-zero exit status 1
 coverage.sh FAIL non-zero exit status 1

Fails all seem to be related to some python/pytest/py* change that might have slipped in without gating on this test.

Ubuntu-image itself also isn't new - still the same as in groovy
 ubuntu-image | 1.10+20.10ubuntu2 | groovy | source, all
 ubuntu-image | 1.10+20.10ubuntu2 | hirsute | source, all

================================== log start ===================================
Obtaining file:///tmp/autopkgtest.ZuL7Da/build.chY/src
    ERROR: Command errored out with exit status 1:
     command: /tmp/autopkgtest.ZuL7Da/build.chY/src/.tox/py38-nocov/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/autopkgtest.ZuL7Da/build.chY/src/setup.py'"'"'; __file__='"'"'/tmp/autopkgtest.ZuL7Da/build.chY/src/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-yaplrymq
         cwd: /tmp/autopkgtest.ZuL7Da/build.chY/src/
    Complete output (5 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/autopkgtest.ZuL7Da/build.chY/src/setup.py", line 49, in <module>
        __version__ = str(Changelog(infp).get_version())
    AttributeError: 'Changelog' object has no attribute 'get_version'
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
=================================== log end ====================================

The issue reproducible in local KVM-autopkgtest against hirsute-proposed and hirsute-release for me (I mistyped before).
Example:
 sudo ~/work/autopkgtest/autopkgtest/runner/autopkgtest --no-built-binaries --apt-upgrade --apt-pocket=proposed --shell-fail ubuntu-image_1.10+20.10ubuntu2.dsc --testname=qa -- qemu --qemu-options='-cpu host' --ram-size=1536 --cpus 2 ~/work/autopkgtest-hirsute-amd64.img

In terms of similar bug signatures I found
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=973227
Fixed by:
https://gitlab.kitware.com/debian/dh-cmake/-/commit/3337c8e0e9ebd109490d3c40f0bd5c1e367bedc8

Looking for the same issue in ubuntu-image has shown an entry in setup.py
  setup.py:49: __version__ = str(Changelog(infp).get_version())

And now that we know all that we see
https://launchpad.net/ubuntu/+source/python-debian/+publishinghistory

New version in since
2020-11-20 02:23:27 CET

That is a perfect match to our bug.

$ diff -Naur python-debian-0.1.3[78]/lib/debian/changelog.py
...
- def get_version(self):
- # type: () -> Version
+ def _get_version(self):
+ # type: () -> Optional[Version]
         """Return a Version object for the last version"""
- return self._blocks[0].version
+ return self._blocks[0].version # type: ignore
...

[Christian Ehrhardt  (paelzer)]

PPA: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4353/
...

killing the rest as I've seen seb128 to do the same ...

[Christian Ehrhardt  (paelzer)]

Seb has opened: https://code.launchpad.net/~seb128/ubuntu-image/+git/ubuntu-image/+merge/394533
It is idential to what I build and tested in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4353/+packages
If we don't want to wait and retrigger the tests with the new version, here a hint: https://code.launchpad.net/~paelzer/britney/+git/hints-ubuntu/+merge/394535

[Sebastien Bacher (seb128)]

https://launchpad.net/ubuntu/+source/ubuntu-image/1.10+20.10ubuntu3

[Łukasz Zemczak (sil2100)]

This is fixed from our POV, shouldn't be a problem anymore.