[MIR] python-asgiref
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
python-asgiref (Ubuntu) |
Fix Released
|
Critical
|
Unassigned |
Bug Description
Related bug is bug 1951130 which wasn't needed because python-asgiref an optional dependency for flask. However it looks like it's a required dependency of python-django 3.2.
[Availability]
The package python-asgiref is already in Ubuntu universe.
The package python-asgiref builds for the architectures it is designed to work on.
It currently builds and works for architectures: all
Link to package https:/
[Rationale]
- The package python-asgiref is required in Ubuntu main for newer versions of python-django.
- The package python-asgiref will generally be useful for a large part of our user base,
specifically those who work with Django and async-capable Python web servers, frameworks,
and applications.
- The package python-asgiref is a new runtime dependency of package python-django that we already support.
[Security]
- No CVEs/security issues in this software in the past
- no `suid` or `sgid` binaries
- no executables in `/sbin` and `/usr/sbin`
- Package does not install services
- Packages does not open privileged ports (ports < 1024)
- Packages does not contain extensions to security-sensitive software
(filters, scanners, plugins, UI skins, ...)
[Quality assurance - function/usage]
- The package works well right after install
[Quality assurance - maintenance]
- The package is maintained well in Debian/Ubuntu and has not too many
and long term critical bugs open
- Ubuntu https:/
- Debian https:/
[Quality assurance - testing]
- The package runs a test suite on build time, if it fails
it makes the build fail, link to build log
https:/
- The package runs an autopkgtest, and is currently passing on
amd64, arm64, armhf, ppc64el, and s390x. Link to test logs
https:/
- The package does have not failing autopkgtests right now
[Quality assurance - packaging]
- debian/watch is present and works
- This package does not yield massive lintian Warnings, Errors
- Link to recent build log including a lintian run https:/
- Lintian overrides are not present
- This package does not rely on obsolete or about to be demoted packages.
- This package has no python2 or GTK2 dependencies
- The package will not be installed by default
[UI standards]
- Application is not end-user facing (does not need translation)
[Dependencies]
- No further depends or recommends dependencies that are not yet in main
[Standards compliance]
- This package correctly follows FHS and Debian Policy
[Maintenance/Owner]
- Owning Team will be Ubuntu Server
- Team is not yet, but will subscribe to the package before promotion
- This does not use static builds
- This does not use vendored code
[Background information]
The Package description explains the package well
Upstream Name is asgiref
Link to upstream project https:/
ASGI docs describe the package in more detail: https:/
description: | updated |
Changed in python-asgiref (Ubuntu): | |
status: | Incomplete → New |
Changed in python-asgiref (Ubuntu): | |
assignee: | nobody → Christian Ehrhardt (paelzer) |
Changed in python-asgiref (Ubuntu): | |
milestone: | ubuntu-22.02 → ubuntu-22.04-feature-freeze |
Changed in python-asgiref (Ubuntu): | |
status: | New → In Progress |
assignee: | Ubuntu Security Team (ubuntu-security) → Rodrigo Figueiredo Zaiden (rodrigo-zaiden) |
Review for Package: python-asgiref
[Summary]
I can confirm all the checks done when filing this. It seems to be a
useful well maintainer library with not many known issues.
MIR team ACK
Sadly it isn't ready for promotion yet, as due to the nature of the code
between servers and web-apps it does need a security review, so I'll assign
ubuntu-security
List of specific binary packages to be promoted to main: python3-asgiref
Specific binary packages built, but NOT to be promoted to main: None
Notes:
- No TODOs identified at the moment
[Duplication]
OK:
There is no other package in main providing the same functionality.
[Dependencies]
OK:
- no other Dependencies to MIR due to this
- no -dev/-debug/-doc packages that need exclusion
[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have odd Built-Using entries
- not a go package, no extra constraints to consider in that regard
[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not open a port/socket
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
Problems:
- does not parse data formats
- does process arbitrary web content - it is meant for "web apps <-> server"
which by its nature is rather exposed
[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
- test suite fails will fail the build upon error.
- does have a non-trivial test suite that runs as autopkgtest
- no new python2 dependency
- Python package, but using dh_python
[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- d/watch is present and looks ok (if needed, e.g. non-native)
- Upstream update history is good
- Debian/Ubuntu update history is good
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
maintained the package
- no massive Lintian warnings
- d/rules is rather clean
- It is not on the lto-disabled list
[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside
tests)
- no use of user nobody
- no use of setuid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit, seed or libgoa-*
- not part of the UI for extra checks
- no translation present, but none needed for this case