[SRU] apt-add-repository adds duplicate commented/disabled source lines
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
python-apt (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Xenial |
Fix Released
|
Medium
|
Dave Jones | ||
Bionic |
Fix Released
|
High
|
Dave Jones | ||
Eoan |
Fix Released
|
High
|
Dave Jones |
Bug Description
Impact
======
Under most circumstances, the impact is minimal (a few extra redundant comment lines in apt sources. However, if users are automating source removal / addition on a machine (as in comment 11), there is the potential to wind up with an excessively large (and thus slow to parse) apt sources configuration.
Test packages for the supported releases are available from the following PPA:
https:/
Built from the source which can be found in the following branches:
Test Case
=========
* sudo add-apt-repository -y ppa:deadsnakes/ppa
* cat /etc/apt/
* Note the presence of one uncommented "deb" line, and one commented "deb-src" line
* sudo add-apt-repository -y ppa:deadsnakes/ppa
* cat /etc/apt/
* Note the uncommented "deb" line is still there but the commented "deb-src" line has now been duplicated
* sudo add-apt-repository ppa:waveform/
* sudo apt upgrade # update python-apt to fixed version
* sudo add-apt-repository -y ppa:deadsnakes/ppa
* cat /etc/apt/
* Note there has been no further duplication of the commented "deb-src" line
Regression Potential
=======
Minimal; test cases have been added to cover the duplication case, and to cover the enabling of sources (which was not covered by existing tests, but was part of the code altered to fix the duplication case), and insertion of sources at a position (again, not covered by existing tests but modified as part of the fix). The test case has been used successfully on all targeted releases (xenial, bionic, and eoan).
Original Description
=======
Trusty Tahr 14.04
0 root@osprey:
deb http://
# deb-src http://
0 root@osprey:
gpg: keyring `/tmp/tmp0ufdhn
gpg: keyring `/tmp/tmp0ufdhn
gpg: requesting key BE796FF2 from hkp server keyserver.
gpg: /tmp/tmp0ufdhnm
gpg: key BE796FF2: public key "Launchpad PPA for AIMS" imported
gpg: Total number processed: 1
gpg: imported: 1 (RSA: 1)
OK
0 root@osprey:
# deb-src http://
# deb-src http://
0 root@osprey:
That deb-src line should have stayed commented out, and not been duplicated. (Commented deb lines should of course be uncommented, as already fixed per https:/
Changed in software-properties (Ubuntu): | |
importance: | Undecided → Low |
tags: | added: patch |
Changed in python-apt (Ubuntu): | |
importance: | Low → Medium |
importance: | Medium → Critical |
importance: | Critical → High |
tags: | added: id-5d65087107d6ae450d988462 |
no longer affects: | software-properties (Ubuntu) |
no longer affects: | software-properties (Ubuntu Xenial) |
no longer affects: | software-properties (Ubuntu Bionic) |
no longer affects: | software-properties (Ubuntu Eoan) |
description: | updated |
summary: |
- apt-add-repository adds duplicate commented/disabled source lines + [SRU] apt-add-repository adds duplicate commented/disabled source lines |
description: | updated |
description: | updated |
Changed in python-apt (Ubuntu Xenial): | |
importance: | Undecided → Medium |
Changed in python-apt (Ubuntu Eoan): | |
importance: | Undecided → High |
Changed in python-apt (Ubuntu Bionic): | |
importance: | Undecided → High |
Changed in python-apt (Ubuntu Eoan): | |
assignee: | nobody → Dave Jones (waveform) |
Changed in python-apt (Ubuntu Xenial): | |
assignee: | nobody → Dave Jones (waveform) |
Changed in python-apt (Ubuntu Bionic): | |
assignee: | nobody → Dave Jones (waveform) |
Changed in python-apt (Ubuntu Xenial): | |
status: | New → In Progress |
Changed in python-apt (Ubuntu Bionic): | |
status: | New → In Progress |
Changed in python-apt (Ubuntu Eoan): | |
status: | New → In Progress |
tags: |
added: verification-done-bionic removed: verification-needed-bionic |
tags: |
added: verification-done-xenial removed: verification-needed-xenial |
tags: |
added: verification-done-eoan removed: verification-needed-eoan |
Thank you for taking the time to report this bug and helping to make Ubuntu better. It seems that your bug report is not filed about a specific source package though, rather it is just filed against Ubuntu in general. It is important that bug reports be filed about source packages so that people interested in the package can find the bugs about it. You can find some hints about determining what package your bug might be about at https:/ /wiki.ubuntu. com/Bugs/ FindRightPackag e. You might also ask for help in the #ubuntu-bugs irc channel on Freenode.
To change the source package that this bug is filed about visit https:/ /bugs.launchpad .net/ubuntu/ +bug/1311056/ +editstatus and add the package name in the text box next to the word Package.
[This is an automated message. I apologize if it reached you inappropriately; please just reply to this message indicating so.]