blacking listing of nouveau should be removed from __init__.py

[Jack Howarth]

The current pymol package for 2.3.0+dfsg-1build1 has upstream's code to disable shader support on nouveau drivers in /usr/lib/python3/dist-packages/pymol/__init__.py. This causes pymol to render very slowly compared to the non-free nvidia drivers. Disabling this code...

# elif (vendor == 'nouveau'
# or ' R300 ' in vendor # V: X.Org R300 Project, R: Gallium 0.4 on ATI RV370
# ):
# if invocation.options.show_splash:
# print(" Detected blacklisted graphics driver. Disabling shaders.")
# cmd.set("use_shaders", 0)

restores the shader support under nouveau. Since Ubuntu's nouveau and mesa are modern compared to the range of linux releases that the stock pymol binaries have to run on, it is probably safe to make this change for 20.04.

Filed a bug report on this upstream at...

https://github.com/schrodinger/pymol-open-source/issues/87

"shaders disabled on nouveau #87"

[Jack Howarth (jwhowarth)]

Note that this issue is always fixed in pymol trunk with...

https://github.com/schrodinger/pymol-open-source/commit/af8c2e09c3ff45eaaeaac76a9fb89b9359340336

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "do not blacklist "nouveau" driver" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Jack Howarth (jwhowarth)]

I checked with pymol upstream and the 2.4.0 release, which will contain the removal of the nouveau blacklisting, is slated for a May release. This change isn't associated with any fixes in pymol but just a recognition that recent nouveau now has usable shader support.

[Jack Howarth (jwhowarth)]

diff --git a/modules/pymol/__init__.py b/modules/pymol/__init__.py
index fe299fbff..aaf978ade 100644
--- a/modules/pymol/__init__.py
+++ b/modules/pymol/__init__.py
@@ -332,8 +332,7 @@ def adapt_to_hardware(self):
                 print(" Disabling shaders for Intel Express graphics")
             cmd.set("use_shaders", 0)

- elif (vendor == 'nouveau'
- or ' R300 ' in vendor # V: X.Org R300 Project, R: Gallium 0.4 on ATI RV370
+ elif (' R300 ' in vendor # V: X.Org R300 Project, R: Gallium 0.4 on ATI RV370
             ):
         if invocation.options.show_splash:
             print(" Detected blacklisted graphics driver. Disabling shaders.")

[Graham Inggs (ginggs)]

This was fixed in hirsute.

pymol (2.4.0+dfsg-1) unstable; urgency=medium

  * New upstream release.
  * debian/patches/02_test-suite.patch: Refreshed.
  * debian/patches/22_fix_pymol_import.patch: Likewise.
  * debian/patches/27_fix_pymol_path_in_setup.patch: Likewise.
  * debian/patches/31_fix_format-security.patch: Likewise.
  * debian/patches/33_fix_relative_paths_in_example_scripts.patch: Likewise.
  * debian/patches/40_mstop_movies.patch: Likewise.
  * debian/patches/28_no_data_install_in_python_path.patch: Updated.
  * debian/patches/32_fix_spelling_lintian_warnings.patch: Likewise.
  * debian/patches/60_py3_test.patch: Removed, no longer needed.
  * debian/control (Build-Depends): Added libnetcdf-dev
  * debian/pymol-data.install: Remove scripts directory, no longer present
    upstream.

 -- Michael Banck <email address hidden> Sun, 10 Jan 2021 21:46:57 +0100