| 2019-04-02 13:17:49 |
Christian Ehrhardt |
bug |
|
|
added bug |
| 2019-04-02 13:25:09 |
Christian Ehrhardt |
description |
TBD |
On the extended testing for the SRU in bug 1817665 we found that there are a few dependency issues that need to be fixed.
python-libnacl - depends on <1.4 but xenial (and trusty soon) have 1.4.5
Fix by importing https://github.com/ecordell/pymacaroons/commit/3924d5b56c42234d0bff3820bc4cb6c4d3f74d8d
python-six - depends on >=1.8.0 - but trusty is on 1.5.2 still
We evaluated if we need to backport six as well (a lot or reverse deps).
We found that the usage of pymacaroons is actually ok with 1.5.2
Upstream regularly bumps the dependency level as well as some changes that got added but in the meantime removed (e.g. the serialization).
Eventually only two use cases for python3-six are left
- pymacaroons/caveat_delegates/encrypted_first_party.py:4:from six import iteritems
- pymacaroons/utils.py:5:from six import text_type, binary_type
None of these are changed in six between 1.5.2 and 1.8 checked by Odd_block, ahasenack and me.
python2 - we don't need/want python2 support in this, so since we don't usually exercise and have no interest in supporting the python2 paths lets drop them from pymacaroons in trusty (where they are not published yet). |
|
| 2019-04-02 13:34:49 |
Christian Ehrhardt |
nominated for series |
|
Ubuntu Trusty |
|
| 2019-04-02 13:34:49 |
Christian Ehrhardt |
bug task added |
|
pymacaroons (Ubuntu Trusty) |
|
| 2019-04-02 13:34:49 |
Christian Ehrhardt |
nominated for series |
|
Ubuntu Xenial |
|
| 2019-04-02 13:34:49 |
Christian Ehrhardt |
bug task added |
|
pymacaroons (Ubuntu Xenial) |
|
| 2019-04-02 13:34:54 |
Christian Ehrhardt |
pymacaroons (Ubuntu Trusty): status |
New |
Triaged |
|
| 2019-04-02 13:34:56 |
Christian Ehrhardt |
pymacaroons (Ubuntu Xenial): status |
New |
Triaged |
|
| 2019-04-02 13:34:59 |
Christian Ehrhardt |
pymacaroons (Ubuntu): status |
New |
Fix Released |
|
| 2019-04-02 13:35:08 |
Christian Ehrhardt |
bug |
|
|
added subscriber Dan Watkins |
| 2019-04-02 13:35:13 |
Christian Ehrhardt |
bug |
|
|
added subscriber Andreas Hasenack |
| 2019-04-02 13:35:19 |
Christian Ehrhardt |
bug |
|
|
added subscriber Chad Smith |
| 2019-04-02 13:35:25 |
Christian Ehrhardt |
bug |
|
|
added subscriber Joshua Powers |
| 2019-04-02 13:35:59 |
Christian Ehrhardt |
description |
On the extended testing for the SRU in bug 1817665 we found that there are a few dependency issues that need to be fixed.
python-libnacl - depends on <1.4 but xenial (and trusty soon) have 1.4.5
Fix by importing https://github.com/ecordell/pymacaroons/commit/3924d5b56c42234d0bff3820bc4cb6c4d3f74d8d
python-six - depends on >=1.8.0 - but trusty is on 1.5.2 still
We evaluated if we need to backport six as well (a lot or reverse deps).
We found that the usage of pymacaroons is actually ok with 1.5.2
Upstream regularly bumps the dependency level as well as some changes that got added but in the meantime removed (e.g. the serialization).
Eventually only two use cases for python3-six are left
- pymacaroons/caveat_delegates/encrypted_first_party.py:4:from six import iteritems
- pymacaroons/utils.py:5:from six import text_type, binary_type
None of these are changed in six between 1.5.2 and 1.8 checked by Odd_block, ahasenack and me.
python2 - we don't need/want python2 support in this, so since we don't usually exercise and have no interest in supporting the python2 paths lets drop them from pymacaroons in trusty (where they are not published yet). |
On the extended testing for the SRU in bug 1817665 we found that there are a few dependency issues that need to be fixed.
Affects X&T:
python-libnacl - depends on <1.4 but xenial (and trusty soon) have 1.4.5
Fix by importing https://github.com/ecordell/pymacaroons/commit/3924d5b56c42234d0bff3820bc4cb6c4d3f74d8d
Affects T:
python-six - depends on >=1.8.0 - but trusty is on 1.5.2 still
We evaluated if we need to backport six as well (a lot or reverse deps).
We found that the usage of pymacaroons is actually ok with 1.5.2
Upstream regularly bumps the dependency level as well as some changes that got added but in the meantime removed (e.g. the serialization).
Eventually only two use cases for python3-six are left
- pymacaroons/caveat_delegates/encrypted_first_party.py:4:from six import iteritems
- pymacaroons/utils.py:5:from six import text_type, binary_type
None of these are changed in six between 1.5.2 and 1.8 checked by Odd_block, ahasenack and me.
Affects T:
python2 - we don't need/want python2 support in this, so since we don't usually exercise and have no interest in supporting the python2 paths lets drop them from pymacaroons in trusty (where they are not published yet). |
|
| 2019-04-02 13:48:26 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~paelzer/ubuntu/+source/pymacaroons/+git/pymacaroons/+merge/365406 |
|
| 2019-04-02 14:07:40 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~paelzer/ubuntu/+source/pymacaroons/+git/pymacaroons/+merge/365409 |
|
| 2019-04-02 14:09:51 |
Dan Watkins |
description |
On the extended testing for the SRU in bug 1817665 we found that there are a few dependency issues that need to be fixed.
Affects X&T:
python-libnacl - depends on <1.4 but xenial (and trusty soon) have 1.4.5
Fix by importing https://github.com/ecordell/pymacaroons/commit/3924d5b56c42234d0bff3820bc4cb6c4d3f74d8d
Affects T:
python-six - depends on >=1.8.0 - but trusty is on 1.5.2 still
We evaluated if we need to backport six as well (a lot or reverse deps).
We found that the usage of pymacaroons is actually ok with 1.5.2
Upstream regularly bumps the dependency level as well as some changes that got added but in the meantime removed (e.g. the serialization).
Eventually only two use cases for python3-six are left
- pymacaroons/caveat_delegates/encrypted_first_party.py:4:from six import iteritems
- pymacaroons/utils.py:5:from six import text_type, binary_type
None of these are changed in six between 1.5.2 and 1.8 checked by Odd_block, ahasenack and me.
Affects T:
python2 - we don't need/want python2 support in this, so since we don't usually exercise and have no interest in supporting the python2 paths lets drop them from pymacaroons in trusty (where they are not published yet). |
On the extended testing for the SRU in bug 1817665 we found that there are a few dependency issues that need to be fixed.
Affects X&T:
python-libnacl - depends on <1.4 but xenial (and trusty soon) have 1.4.5
Fix by importing https://github.com/ecordell/pymacaroons/commit/3924d5b56c42234d0bff3820bc4cb6c4d3f74d8d
Affects T:
python-six - depends on >=1.8.0 - but trusty is on 1.5.2 still
We evaluated if we need to backport six as well (a lot or reverse deps).
We found that the usage of pymacaroons is actually ok with 1.5.2
Upstream regularly bumps the dependency level as well as some changes that got added but in the meantime removed (e.g. the serialization).
Eventually only two use cases for python3-six are left
- pymacaroons/caveat_delegates/encrypted_first_party.py:4:from six import iteritems
- pymacaroons/utils.py:5:from six import text_type, binary_type
None of these are changed in six between 1.5.2 and 1.8 checked by Odd_Bloke, ahasenack and me.
Affects T:
python2 - we don't need/want python2 support in this, so since we don't usually exercise and have no interest in supporting the python2 paths lets drop them from pymacaroons in trusty (where they are not published yet). |
|
| 2019-04-02 14:35:12 |
Christian Ehrhardt |
description |
On the extended testing for the SRU in bug 1817665 we found that there are a few dependency issues that need to be fixed.
Affects X&T:
python-libnacl - depends on <1.4 but xenial (and trusty soon) have 1.4.5
Fix by importing https://github.com/ecordell/pymacaroons/commit/3924d5b56c42234d0bff3820bc4cb6c4d3f74d8d
Affects T:
python-six - depends on >=1.8.0 - but trusty is on 1.5.2 still
We evaluated if we need to backport six as well (a lot or reverse deps).
We found that the usage of pymacaroons is actually ok with 1.5.2
Upstream regularly bumps the dependency level as well as some changes that got added but in the meantime removed (e.g. the serialization).
Eventually only two use cases for python3-six are left
- pymacaroons/caveat_delegates/encrypted_first_party.py:4:from six import iteritems
- pymacaroons/utils.py:5:from six import text_type, binary_type
None of these are changed in six between 1.5.2 and 1.8 checked by Odd_Bloke, ahasenack and me.
Affects T:
python2 - we don't need/want python2 support in this, so since we don't usually exercise and have no interest in supporting the python2 paths lets drop them from pymacaroons in trusty (where they are not published yet). |
[Impact]
* The pymacaroons stack has dependency issues identified when further
testing the backport to trusty (currently in proposed)
* Ensure that the pymacaroons stack works well in Trusty (for Ubuntu
Advantage client) but also fix the issues that matter for Xenial in
Xenial as well.
[Test Case]
* TODO
[Fix]
* Changes
- Trusty: drop python2 binaries in trusty (was not released there yet)
Xenial has those already published, we are not gonna take them away.
see [1]
- Trusty: adapt python-six dependency to match what is really needed
and available in Trusty. Xenial has a version higher than that so
don't bother modifying it there.
see [2]
- Trusty and Xenial: adapt python-libnacl dependency by backporting
upstream fix on a too struct version requirement.
see [3]
[1]: https://git.launchpad.net/~paelzer/ubuntu/+source/pymacaroons/commit/?id=6746ad32b4d785919e849a4bef5685bf0bec6be2
[2]: https://git.launchpad.net/~paelzer/ubuntu/+source/pymacaroons/commit/?id=f94ac40aeb354c008c4764853b877991003ae429
[3]: https://git.launchpad.net/~paelzer/ubuntu/+source/pymacaroons/commit/?id=1987dffcffae29c63ea71635db1cfe19badc145f
[Regression Potential]
* Lets split this section for Trusty and Xenial.
a) Xenial only gets slightly relaxed version dependencies, those should
allow pymacaroons to run, but actually never cause any additional
issues.
b) Trusty this isn't released in trusty at all yet (still in proposed
intentionally). Therefore this is one of the few cases I'd call
regression risk next to zero. If anything then issues out of the py2
removal not working as expected, but it seems to be ok in build and
tests.
[Other Info]
* This is related to the SRU in bug 1817665
* Furthermore it is related to the MIR extension to Trusty in
bug 1746772 bug 1817327 and bug 1621386
---
On the extended testing for the SRU in bug 1817665 we found that there are a few dependency issues that need to be fixed.
Affects X&T:
python-libnacl - depends on <1.4 but xenial (and trusty soon) have 1.4.5
Fix by importing https://github.com/ecordell/pymacaroons/commit/3924d5b56c42234d0bff3820bc4cb6c4d3f74d8d
Affects T:
python-six - depends on >=1.8.0 - but trusty is on 1.5.2 still
We evaluated if we need to backport six as well (a lot or reverse deps).
We found that the usage of pymacaroons is actually ok with 1.5.2
Upstream regularly bumps the dependency level as well as some changes that got added but in the meantime removed (e.g. the serialization).
Eventually only two use cases for python3-six are left
- pymacaroons/caveat_delegates/encrypted_first_party.py:4:from six import iteritems
- pymacaroons/utils.py:5:from six import text_type, binary_type
None of these are changed in six between 1.5.2 and 1.8 checked by Odd_Bloke, ahasenack and me.
Affects T:
python2 - we don't need/want python2 support in this, so since we don't usually exercise and have no interest in supporting the python2 paths lets drop them from pymacaroons in trusty (where they are not published yet). |
|
| 2019-04-02 14:36:45 |
Christian Ehrhardt |
pymacaroons (Ubuntu Trusty): assignee |
|
Andreas Hasenack (ahasenack) |
|
| 2019-04-02 14:36:53 |
Christian Ehrhardt |
pymacaroons (Ubuntu Xenial): assignee |
|
Dan Watkins (daniel-thewatkins) |
|
| 2019-04-02 20:17:16 |
Andreas Hasenack |
pymacaroons (Ubuntu Xenial): assignee |
Dan Watkins (daniel-thewatkins) |
Andreas Hasenack (ahasenack) |
|
| 2019-04-02 21:02:49 |
Andreas Hasenack |
description |
[Impact]
* The pymacaroons stack has dependency issues identified when further
testing the backport to trusty (currently in proposed)
* Ensure that the pymacaroons stack works well in Trusty (for Ubuntu
Advantage client) but also fix the issues that matter for Xenial in
Xenial as well.
[Test Case]
* TODO
[Fix]
* Changes
- Trusty: drop python2 binaries in trusty (was not released there yet)
Xenial has those already published, we are not gonna take them away.
see [1]
- Trusty: adapt python-six dependency to match what is really needed
and available in Trusty. Xenial has a version higher than that so
don't bother modifying it there.
see [2]
- Trusty and Xenial: adapt python-libnacl dependency by backporting
upstream fix on a too struct version requirement.
see [3]
[1]: https://git.launchpad.net/~paelzer/ubuntu/+source/pymacaroons/commit/?id=6746ad32b4d785919e849a4bef5685bf0bec6be2
[2]: https://git.launchpad.net/~paelzer/ubuntu/+source/pymacaroons/commit/?id=f94ac40aeb354c008c4764853b877991003ae429
[3]: https://git.launchpad.net/~paelzer/ubuntu/+source/pymacaroons/commit/?id=1987dffcffae29c63ea71635db1cfe19badc145f
[Regression Potential]
* Lets split this section for Trusty and Xenial.
a) Xenial only gets slightly relaxed version dependencies, those should
allow pymacaroons to run, but actually never cause any additional
issues.
b) Trusty this isn't released in trusty at all yet (still in proposed
intentionally). Therefore this is one of the few cases I'd call
regression risk next to zero. If anything then issues out of the py2
removal not working as expected, but it seems to be ok in build and
tests.
[Other Info]
* This is related to the SRU in bug 1817665
* Furthermore it is related to the MIR extension to Trusty in
bug 1746772 bug 1817327 and bug 1621386
---
On the extended testing for the SRU in bug 1817665 we found that there are a few dependency issues that need to be fixed.
Affects X&T:
python-libnacl - depends on <1.4 but xenial (and trusty soon) have 1.4.5
Fix by importing https://github.com/ecordell/pymacaroons/commit/3924d5b56c42234d0bff3820bc4cb6c4d3f74d8d
Affects T:
python-six - depends on >=1.8.0 - but trusty is on 1.5.2 still
We evaluated if we need to backport six as well (a lot or reverse deps).
We found that the usage of pymacaroons is actually ok with 1.5.2
Upstream regularly bumps the dependency level as well as some changes that got added but in the meantime removed (e.g. the serialization).
Eventually only two use cases for python3-six are left
- pymacaroons/caveat_delegates/encrypted_first_party.py:4:from six import iteritems
- pymacaroons/utils.py:5:from six import text_type, binary_type
None of these are changed in six between 1.5.2 and 1.8 checked by Odd_Bloke, ahasenack and me.
Affects T:
python2 - we don't need/want python2 support in this, so since we don't usually exercise and have no interest in supporting the python2 paths lets drop them from pymacaroons in trusty (where they are not published yet). |
[Impact]
* The pymacaroons stack has dependency issues identified when further
testing the backport to trusty (currently in proposed)
* Ensure that the pymacaroons stack works well in Trusty (for Ubuntu
Advantage client) but also fix the issues that matter for Xenial in
Xenial as well.
[Test Case]
* install python3-pymacaroons. This will pull in python3-libnacl 1.4.5 as well (expected)
* Without the fix, this command will backtrace as shown:
$ python3 -c "__requires__ = 'pymacaroons';from pkg_resources import load_entry_point"
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/pkg_resources.py", line 444, in _build_master
ws.require(__requires__)
File "/usr/lib/python3/dist-packages/pkg_resources.py", line 725, in require
needed = self.resolve(parse_requirements(requirements))
File "/usr/lib/python3/dist-packages/pkg_resources.py", line 632, in resolve
raise VersionConflict(dist,req) # XXX put more info here
pkg_resources.VersionConflict: (libnacl 1.4.5 (/usr/lib/python3/dist-packages), Requirement.parse('libnacl>=1.3.6,<1.4'))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/usr/lib/python3/dist-packages/pkg_resources.py", line 2749, in <module>
working_set = WorkingSet._build_master()
File "/usr/lib/python3/dist-packages/pkg_resources.py", line 446, in _build_master
return cls._build_from_requirements(__requires__)
File "/usr/lib/python3/dist-packages/pkg_resources.py", line 459, in _build_from_requirements
dists = ws.resolve(reqs, Environment())
File "/usr/lib/python3/dist-packages/pkg_resources.py", line 628, in resolve
raise DistributionNotFound(req)
pkg_resources.DistributionNotFound: libnacl>=1.3.6,<1.4
* the python3-six dependency check isn't reached, because the check stops at the first unsatisfied dependency and that happened to be libnacl. But when testing the fixed packages, there must be no backtrace like above.
[Fix]
* Changes
- Trusty: drop python2 binaries in trusty (was not released there yet)
Xenial has those already published, we are not gonna take them away.
see [1]
- Trusty: adapt python-six dependency to match what is really needed
and available in Trusty. Xenial has a version higher than that so
don't bother modifying it there.
see [2]
- Trusty and Xenial: adapt python-libnacl dependency by backporting
upstream fix on a too struct version requirement.
see [3]
[1]: https://git.launchpad.net/~paelzer/ubuntu/+source/pymacaroons/commit/?id=6746ad32b4d785919e849a4bef5685bf0bec6be2
[2]: https://git.launchpad.net/~paelzer/ubuntu/+source/pymacaroons/commit/?id=f94ac40aeb354c008c4764853b877991003ae429
[3]: https://git.launchpad.net/~paelzer/ubuntu/+source/pymacaroons/commit/?id=1987dffcffae29c63ea71635db1cfe19badc145f
[Regression Potential]
* Lets split this section for Trusty and Xenial.
a) Xenial only gets slightly relaxed version dependencies, those should
allow pymacaroons to run, but actually never cause any additional
issues.
b) Trusty this isn't released in trusty at all yet (still in proposed
intentionally). Therefore this is one of the few cases I'd call
regression risk next to zero. If anything then issues out of the py2
removal not working as expected, but it seems to be ok in build and
tests.
[Other Info]
* This is related to the SRU in bug 1817665
* Furthermore it is related to the MIR extension to Trusty in
bug 1746772 bug 1817327 and bug 1621386
---
On the extended testing for the SRU in bug 1817665 we found that there are a few dependency issues that need to be fixed.
Affects X&T:
python-libnacl - depends on <1.4 but xenial (and trusty soon) have 1.4.5
Fix by importing https://github.com/ecordell/pymacaroons/commit/3924d5b56c42234d0bff3820bc4cb6c4d3f74d8d
Affects T:
python-six - depends on >=1.8.0 - but trusty is on 1.5.2 still
We evaluated if we need to backport six as well (a lot or reverse deps).
We found that the usage of pymacaroons is actually ok with 1.5.2
Upstream regularly bumps the dependency level as well as some changes that got added but in the meantime removed (e.g. the serialization).
Eventually only two use cases for python3-six are left
- pymacaroons/caveat_delegates/encrypted_first_party.py:4:from six import iteritems
- pymacaroons/utils.py:5:from six import text_type, binary_type
None of these are changed in six between 1.5.2 and 1.8 checked by Odd_Bloke, ahasenack and me.
Affects T:
python2 - we don't need/want python2 support in this, so since we don't usually exercise and have no interest in supporting the python2 paths lets drop them from pymacaroons in trusty (where they are not published yet). |
|
| 2019-04-02 21:08:12 |
Andreas Hasenack |
description |
[Impact]
* The pymacaroons stack has dependency issues identified when further
testing the backport to trusty (currently in proposed)
* Ensure that the pymacaroons stack works well in Trusty (for Ubuntu
Advantage client) but also fix the issues that matter for Xenial in
Xenial as well.
[Test Case]
* install python3-pymacaroons. This will pull in python3-libnacl 1.4.5 as well (expected)
* Without the fix, this command will backtrace as shown:
$ python3 -c "__requires__ = 'pymacaroons';from pkg_resources import load_entry_point"
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/pkg_resources.py", line 444, in _build_master
ws.require(__requires__)
File "/usr/lib/python3/dist-packages/pkg_resources.py", line 725, in require
needed = self.resolve(parse_requirements(requirements))
File "/usr/lib/python3/dist-packages/pkg_resources.py", line 632, in resolve
raise VersionConflict(dist,req) # XXX put more info here
pkg_resources.VersionConflict: (libnacl 1.4.5 (/usr/lib/python3/dist-packages), Requirement.parse('libnacl>=1.3.6,<1.4'))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/usr/lib/python3/dist-packages/pkg_resources.py", line 2749, in <module>
working_set = WorkingSet._build_master()
File "/usr/lib/python3/dist-packages/pkg_resources.py", line 446, in _build_master
return cls._build_from_requirements(__requires__)
File "/usr/lib/python3/dist-packages/pkg_resources.py", line 459, in _build_from_requirements
dists = ws.resolve(reqs, Environment())
File "/usr/lib/python3/dist-packages/pkg_resources.py", line 628, in resolve
raise DistributionNotFound(req)
pkg_resources.DistributionNotFound: libnacl>=1.3.6,<1.4
* the python3-six dependency check isn't reached, because the check stops at the first unsatisfied dependency and that happened to be libnacl. But when testing the fixed packages, there must be no backtrace like above.
[Fix]
* Changes
- Trusty: drop python2 binaries in trusty (was not released there yet)
Xenial has those already published, we are not gonna take them away.
see [1]
- Trusty: adapt python-six dependency to match what is really needed
and available in Trusty. Xenial has a version higher than that so
don't bother modifying it there.
see [2]
- Trusty and Xenial: adapt python-libnacl dependency by backporting
upstream fix on a too struct version requirement.
see [3]
[1]: https://git.launchpad.net/~paelzer/ubuntu/+source/pymacaroons/commit/?id=6746ad32b4d785919e849a4bef5685bf0bec6be2
[2]: https://git.launchpad.net/~paelzer/ubuntu/+source/pymacaroons/commit/?id=f94ac40aeb354c008c4764853b877991003ae429
[3]: https://git.launchpad.net/~paelzer/ubuntu/+source/pymacaroons/commit/?id=1987dffcffae29c63ea71635db1cfe19badc145f
[Regression Potential]
* Lets split this section for Trusty and Xenial.
a) Xenial only gets slightly relaxed version dependencies, those should
allow pymacaroons to run, but actually never cause any additional
issues.
b) Trusty this isn't released in trusty at all yet (still in proposed
intentionally). Therefore this is one of the few cases I'd call
regression risk next to zero. If anything then issues out of the py2
removal not working as expected, but it seems to be ok in build and
tests.
[Other Info]
* This is related to the SRU in bug 1817665
* Furthermore it is related to the MIR extension to Trusty in
bug 1746772 bug 1817327 and bug 1621386
---
On the extended testing for the SRU in bug 1817665 we found that there are a few dependency issues that need to be fixed.
Affects X&T:
python-libnacl - depends on <1.4 but xenial (and trusty soon) have 1.4.5
Fix by importing https://github.com/ecordell/pymacaroons/commit/3924d5b56c42234d0bff3820bc4cb6c4d3f74d8d
Affects T:
python-six - depends on >=1.8.0 - but trusty is on 1.5.2 still
We evaluated if we need to backport six as well (a lot or reverse deps).
We found that the usage of pymacaroons is actually ok with 1.5.2
Upstream regularly bumps the dependency level as well as some changes that got added but in the meantime removed (e.g. the serialization).
Eventually only two use cases for python3-six are left
- pymacaroons/caveat_delegates/encrypted_first_party.py:4:from six import iteritems
- pymacaroons/utils.py:5:from six import text_type, binary_type
None of these are changed in six between 1.5.2 and 1.8 checked by Odd_Bloke, ahasenack and me.
Affects T:
python2 - we don't need/want python2 support in this, so since we don't usually exercise and have no interest in supporting the python2 paths lets drop them from pymacaroons in trusty (where they are not published yet). |
[Impact]
* The pymacaroons stack has dependency issues identified when further
testing the backport to trusty (currently in proposed)
* Ensure that the pymacaroons stack works well in Trusty (for Ubuntu
Advantage client) but also fix the issues that matter for Xenial in
Xenial as well.
[Test Case]
* install python3-pymacaroons. This will pull in python3-libnacl 1.4.5 as well (expected)
* Without the latest fix from proposed, this command will backtrace as shown:
$ python3 -c "__requires__ = 'pymacaroons';from pkg_resources import load_entry_point"
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/pkg_resources.py", line 444, in _build_master
ws.require(__requires__)
File "/usr/lib/python3/dist-packages/pkg_resources.py", line 725, in require
needed = self.resolve(parse_requirements(requirements))
File "/usr/lib/python3/dist-packages/pkg_resources.py", line 632, in resolve
raise VersionConflict(dist,req) # XXX put more info here
pkg_resources.VersionConflict: (libnacl 1.4.5 (/usr/lib/python3/dist-packages), Requirement.parse('libnacl>=1.3.6,<1.4'))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/usr/lib/python3/dist-packages/pkg_resources.py", line 2749, in <module>
working_set = WorkingSet._build_master()
File "/usr/lib/python3/dist-packages/pkg_resources.py", line 446, in _build_master
return cls._build_from_requirements(__requires__)
File "/usr/lib/python3/dist-packages/pkg_resources.py", line 459, in _build_from_requirements
dists = ws.resolve(reqs, Environment())
File "/usr/lib/python3/dist-packages/pkg_resources.py", line 628, in resolve
raise DistributionNotFound(req)
pkg_resources.DistributionNotFound: libnacl>=1.3.6,<1.4
* the python3-six dependency check isn't reached, because the check stops at the first unsatisfied dependency and that happened to be libnacl. But when testing the fixed packages, there must be no backtrace like above.
[Fix]
* Changes
- Trusty: drop python2 binaries in trusty (was not released there yet)
Xenial has those already published, we are not gonna take them away.
see [1]
- Trusty: adapt python-six dependency to match what is really needed
and available in Trusty. Xenial has a version higher than that so
don't bother modifying it there.
see [2]
- Trusty and Xenial: adapt python-libnacl dependency by backporting
upstream fix on a too struct version requirement.
see [3]
[1]: https://git.launchpad.net/~paelzer/ubuntu/+source/pymacaroons/commit/?id=6746ad32b4d785919e849a4bef5685bf0bec6be2
[2]: https://git.launchpad.net/~paelzer/ubuntu/+source/pymacaroons/commit/?id=f94ac40aeb354c008c4764853b877991003ae429
[3]: https://git.launchpad.net/~paelzer/ubuntu/+source/pymacaroons/commit/?id=1987dffcffae29c63ea71635db1cfe19badc145f
[Regression Potential]
* Lets split this section for Trusty and Xenial.
a) Xenial only gets slightly relaxed version dependencies, those should
allow pymacaroons to run, but actually never cause any additional
issues.
b) Trusty this isn't released in trusty at all yet (still in proposed
intentionally). Therefore this is one of the few cases I'd call
regression risk next to zero. If anything then issues out of the py2
removal not working as expected, but it seems to be ok in build and
tests.
[Other Info]
* This is related to the SRU in bug 1817665
* Furthermore it is related to the MIR extension to Trusty in
bug 1746772 bug 1817327 and bug 1621386
---
On the extended testing for the SRU in bug 1817665 we found that there are a few dependency issues that need to be fixed.
Affects X&T:
python-libnacl - depends on <1.4 but xenial (and trusty soon) have 1.4.5
Fix by importing https://github.com/ecordell/pymacaroons/commit/3924d5b56c42234d0bff3820bc4cb6c4d3f74d8d
Affects T:
python-six - depends on >=1.8.0 - but trusty is on 1.5.2 still
We evaluated if we need to backport six as well (a lot or reverse deps).
We found that the usage of pymacaroons is actually ok with 1.5.2
Upstream regularly bumps the dependency level as well as some changes that got added but in the meantime removed (e.g. the serialization).
Eventually only two use cases for python3-six are left
- pymacaroons/caveat_delegates/encrypted_first_party.py:4:from six import iteritems
- pymacaroons/utils.py:5:from six import text_type, binary_type
None of these are changed in six between 1.5.2 and 1.8 checked by Odd_Bloke, ahasenack and me.
Affects T:
python2 - we don't need/want python2 support in this, so since we don't usually exercise and have no interest in supporting the python2 paths lets drop them from pymacaroons in trusty (where they are not published yet). |
|
| 2019-04-03 09:20:13 |
Christian Ehrhardt |
pymacaroons (Ubuntu Xenial): status |
Triaged |
Invalid |
|
| 2019-04-03 09:20:16 |
Christian Ehrhardt |
pymacaroons (Ubuntu Xenial): assignee |
Andreas Hasenack (ahasenack) |
|
|
| 2019-04-03 09:20:21 |
Christian Ehrhardt |
pymacaroons (Ubuntu Trusty): status |
Triaged |
In Progress |
|
| 2019-04-03 15:06:58 |
Robie Basak |
pymacaroons (Ubuntu Trusty): status |
In Progress |
Fix Committed |
|
| 2019-04-03 15:06:58 |
Robie Basak |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2019-04-03 15:07:00 |
Robie Basak |
bug |
|
|
added subscriber SRU Verification |
| 2019-04-03 15:07:03 |
Robie Basak |
tags |
|
verification-needed verification-needed-trusty |
|
| 2019-04-13 20:35:11 |
Mathew Hodson |
pymacaroons (Ubuntu Xenial): status |
Invalid |
Won't Fix |
|
| 2019-04-16 21:15:12 |
Andreas Hasenack |
tags |
verification-needed verification-needed-trusty |
verification-done-trusty verification-needed |
|
| 2019-05-01 23:59:18 |
Launchpad Janitor |
pymacaroons (Ubuntu Trusty): status |
Fix Committed |
Fix Released |
|
| 2019-05-01 23:59:28 |
Steve Langasek |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
