pyfltk: FTBFS: ./python/fltk_wrap.cpp:5241:35: error: format not a string literal and no format arguments [-Werror=format-security]

[Logan Rosen]

Imported from Debian bug http://bugs.debian.org/759824:

Source: pyfltk
Version: 1.3.0-1
Severity: serious
Tags: jessie sid
User: <email address hidden>
Usertags: qa-ftbfs-20140830 qa-ftbfs
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part (hopefully):
> x86_64-linux-gnu-gcc -pthread -g -O0 -Wall -Wstrict-prototypes -fno-strict-aliasing -g -O0 -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DUNIX=1 -I/usr/include/libpng12 -I/usr/include/libdrm -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/glib-2.0 -I/usr/include/cairo -I./src -I./contrib -I/usr/include -I/usr/include/python2.7_d -c ./python/fltk_wrap.cpp -o build/temp.linux-x86_64-2.7-pydebug/./python/fltk_wrap.o -DDO_NOT_USE_THREADS
> cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
> ./python/fltk_wrap.cpp: In function 'const char* fl_vararg_input(const char*, const char*)':
> ./python/fltk_wrap.cpp:5241:35: error: format not a string literal and no format arguments [-Werror=format-security]
> result = fl_input(label, deflt);
> ^
> ./python/fltk_wrap.cpp: In function 'const char* fl_vararg_password(const char*, const char*)':
> ./python/fltk_wrap.cpp:5247:38: error: format not a string literal and no format arguments [-Werror=format-security]
> result = fl_password(label, deflt);
> ^
> ./python/fltk_wrap.cpp: In function 'void fl_mt_message(const char*)':
> ./python/fltk_wrap.cpp:5285:20: error: format not a string literal and no format arguments [-Werror=format-security]
> fl_message(text);
> ^
> ./python/fltk_wrap.cpp: In function 'void fl_mt_alert(const char*)':
> ./python/fltk_wrap.cpp:5291:18: error: format not a string literal and no format arguments [-Werror=format-security]
> fl_alert(text);
> ^
> ./python/fltk_wrap.cpp: In function 'int fl_mt_ask(const char*)':
> ./python/fltk_wrap.cpp:5298:14: warning: 'int fl_ask(const char*, ...)' is deprecated (declared at /usr/include/FL/fl_ask.H:47) [-Wdeprecated-declarations]
> status = fl_ask(text);
> ^
> ./python/fltk_wrap.cpp:5298:25: error: format not a string literal and no format arguments [-Werror=format-security]
> status = fl_ask(text);
> ^
> ./python/fltk_wrap.cpp:5298:25: warning: 'int fl_ask(const char*, ...)' is deprecated (declared at /usr/include/FL/fl_ask.H:47) [-Wdeprecated-declarations]
> ./python/fltk_wrap.cpp: In function 'int fl_mt_choice(const char*, const char*, const char*, const char*)':
> ./python/fltk_wrap.cpp:5306:37: error: format not a string literal and no format arguments [-Werror=format-security]
> status = fl_choice(q, b0, b1, b2);
> ^
> ./python/fltk_wrap.cpp: In function 'const char* fl_mt_input(const char*, const char*)':
> ./python/fltk_wrap.cpp:5314:35: error: format not a string literal and no format arguments [-Werror=format-security]
> result = fl_input(label, deflt);
> ^
> ./python/fltk_wrap.cpp: In function 'const char* fl_mt_password(const char*, const char*)':
> ./python/fltk_wrap.cpp:5322:38: error: format not a string literal and no format arguments [-Werror=format-security]
> result = fl_password(label, deflt);
> ^
> ./python/fltk_wrap.cpp: In function 'PyObject* _wrap_fl_define_FL_ROUND_UP_BOX(PyObject*, PyObject*)':
> ./python/fltk_wrap.cpp:37722:1: warning: label 'fail' defined but not used [-Wunused-label]
> fail:
> ^
> ./python/fltk_wrap.cpp: In function 'PyObject* _wrap_fl_define_FL_SHADOW_BOX(PyObject*, PyObject*)':
> ./python/fltk_wrap.cpp:37734:1: warning: label 'fail' defined but not used [-Wunused-label]
> fail:
> ^
> ./python/fltk_wrap.cpp: In function 'PyObject* _wrap_fl_define_FL_ROUNDED_BOX(PyObject*, PyObject*)':
> ./python/fltk_wrap.cpp:37746:1: warning: label 'fail' defined but not used [-Wunused-label]
> fail:
> ^
> ./python/fltk_wrap.cpp: In function 'PyObject* _wrap_fl_define_FL_RFLAT_BOX(PyObject*, PyObject*)':
> ./python/fltk_wrap.cpp:37758:1: warning: label 'fail' defined but not used [-Wunused-label]
> fail:
> ^
> ./python/fltk_wrap.cpp: In function 'PyObject* _wrap_fl_define_FL_RSHADOW_BOX(PyObject*, PyObject*)':
> ./python/fltk_wrap.cpp:37770:1: warning: label 'fail' defined but not used [-Wunused-label]
> fail:
> ^
> ./python/fltk_wrap.cpp: In function 'PyObject* _wrap_fl_define_FL_DIAMOND_BOX(PyObject*, PyObject*)':
> ./python/fltk_wrap.cpp:37782:1: warning: label 'fail' defined but not used [-Wunused-label]
> fail:
> ^
> ./python/fltk_wrap.cpp: In function 'PyObject* _wrap_fl_define_FL_OVAL_BOX(PyObject*, PyObject*)':
> ./python/fltk_wrap.cpp:37794:1: warning: label 'fail' defined but not used [-Wunused-label]
> fail:
> ^
> ./python/fltk_wrap.cpp: In function 'PyObject* _wrap_fl_define_FL_PLASTIC_UP_BOX(PyObject*, PyObject*)':
> ./python/fltk_wrap.cpp:37806:1: warning: label 'fail' defined but not used [-Wunused-label]
> fail:
> ^

[...]

> cc1plus: some warnings being treated as errors
> error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
> [32846 refs]
> dh_auto_build: python-dbg setup.py build --force returned exit code 1
> debian/rules:4: recipe for target 'build' failed
> make: *** [build] Error 1

The full build log is available from:
   http://aws-logs.debian.net/ftbfs-logs/2014/08/30/pyfltk_1.3.0-1_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures. The build
was done with DEB_BUILD_OPTIONS="parallel=4", so if your packaging tries
to support this, it might be a good idea to explore whether this might
be the cause of the failure.