Activity log for bug #1315021

Date Who What changed Old value New value Message
2014-05-01 14:39:00 Matthew Wedgwood bug added bug
2014-05-01 14:39:27 Matthew Wedgwood description When the puppetmaster process (via the service command, or calling the initscript directly), the restart can fail if the original process does not exit immediately. This is because the initscript is not written to wait for the original process to exit. In my testing, adding "-R n" to the start-stop-daemon command in the initscript fixed the problem. It's difficult to determine an appropriate value for n, but it could be tunable via /etc/default/puppetmaster. It's definitely a problem not to wait at all for the process to exit. When restarting the puppetmaster process (via the service command, or calling the initscript directly), the restart can fail if the original process does not exit immediately. This is because the initscript is not written to wait for the original process to exit. In my testing, adding "-R n" to the start-stop-daemon command in the initscript fixed the problem. It's difficult to determine an appropriate value for n, but it could be tunable via /etc/default/puppetmaster. It's definitely a problem not to wait at all for the process to exit.
2014-05-01 14:40:39 Matthew Wedgwood description When restarting the puppetmaster process (via the service command, or calling the initscript directly), the restart can fail if the original process does not exit immediately. This is because the initscript is not written to wait for the original process to exit. In my testing, adding "-R n" to the start-stop-daemon command in the initscript fixed the problem. It's difficult to determine an appropriate value for n, but it could be tunable via /etc/default/puppetmaster. It's definitely a problem not to wait at all for the process to exit. When restarting the puppetmaster process (via the service command, or calling the initscript directly), the restart can fail if the original process does not exit immediately. This is because the initscript is not written to wait for the original process to exit. In my testing under Trusty, adding "-R n" to the start-stop-daemon command in the initscript fixed the problem. It's difficult to determine an appropriate value for n, but it could be tunable via /etc/default/puppetmaster. It's definitely a problem not to wait at all for the process to exit.
2015-01-30 15:08:04 Launchpad Janitor puppetmaster (Ubuntu): status New Confirmed
2015-01-30 23:06:58 Bryan Quigley tags cts
2015-02-04 15:27:30 Felipe Reyes attachment added lp1315021_vivid.debdiff https://bugs.launchpad.net/ubuntu/+source/puppetmaster/+bug/1315021/+attachment/4312243/+files/lp1315021_vivid.debdiff
2015-02-04 15:28:49 Felipe Reyes bug added subscriber Ubuntu Sponsors Team
2015-02-04 15:29:06 Felipe Reyes puppetmaster (Ubuntu): assignee Felipe Reyes (freyes)
2015-02-04 18:46:13 Felipe Reyes attachment removed lp1315021_vivid.debdiff https://bugs.launchpad.net/ubuntu/+source/puppetmaster/+bug/1315021/+attachment/4312243/+files/lp1315021_vivid.debdiff
2015-02-04 18:55:42 Felipe Reyes attachment added lp1315021_vivid.debdiff https://bugs.launchpad.net/ubuntu/+source/puppetmaster/+bug/1315021/+attachment/4312412/+files/lp1315021_vivid.debdiff
2015-02-04 19:36:17 Launchpad Janitor branch linked lp:ubuntu/vivid-proposed/puppet
2015-02-04 21:16:41 Felipe Reyes description When restarting the puppetmaster process (via the service command, or calling the initscript directly), the restart can fail if the original process does not exit immediately. This is because the initscript is not written to wait for the original process to exit. In my testing under Trusty, adding "-R n" to the start-stop-daemon command in the initscript fixed the problem. It's difficult to determine an appropriate value for n, but it could be tunable via /etc/default/puppetmaster. It's definitely a problem not to wait at all for the process to exit. [Impact] Users restarting puppet and puppetmaster may have problems restarting the daemons, in systems under heavy load may be more frequent, because if the stop operation takes more than 1 second the start operation fails due that the daemon is still running. If the daemon isn't started in a machine managed by puppet (or the puppetmaster) will require manual intervention to bring up the system. [Test] - Create a small VM (512MB, 1 vcpu) - Install puppet and puppetmaster packages - Restart each daemon twice with a 10 seconds pause # service puppetmaster restart; sleep 10; service puppetmaster restart Expected results: - The service is restarted Actual results: - The service is stopped, but it isn't started again the console prints: root@vivid-puppetmaster:~# service puppetmaster restart ; sleep 10 ; service puppetmaster restart * Restarting puppet master ...done. * Restarting puppet master ...fail! [Regression Potential] - If after 10 seconds the daemon isn't exited the start-stop-daemon command will send the KILL signal and wait for 5 seconds, this is different from the current behavior that just informs the restart failure to the user and doesn't send the KILL signal. [Other Info] When restarting the puppetmaster process (via the service command, or calling the initscript directly), the restart can fail if the original process does not exit immediately. This is because the initscript is not written to wait for the original process to exit. In my testing under Trusty, adding "-R n" to the start-stop-daemon command in the initscript fixed the problem. It's difficult to determine an appropriate value for n, but it could be tunable via /etc/default/puppetmaster. It's definitely a problem not to wait at all for the process to exit.
2015-02-04 21:16:52 Felipe Reyes summary Service restart fails because process has not exited [SRU] Service restart fails because process has not exited
2015-02-04 21:19:14 Felipe Reyes attachment added lp1315021_utopic.debdiff https://bugs.launchpad.net/ubuntu/+source/puppetmaster/+bug/1315021/+attachment/4312505/+files/lp1315021_utopic.debdiff
2015-02-04 21:20:14 Felipe Reyes attachment added lp1315021_trusty.debdiff https://bugs.launchpad.net/ubuntu/+source/puppetmaster/+bug/1315021/+attachment/4312506/+files/lp1315021_trusty.debdiff
2015-02-04 21:45:56 Chris J Arges nominated for series Ubuntu Utopic
2015-02-04 21:45:56 Chris J Arges bug task added puppetmaster (Ubuntu Utopic)
2015-02-04 21:45:56 Chris J Arges nominated for series Ubuntu Trusty
2015-02-04 21:45:56 Chris J Arges bug task added puppetmaster (Ubuntu Trusty)
2015-02-04 21:46:18 Chris J Arges puppetmaster (Ubuntu Trusty): assignee Felipe Reyes (freyes)
2015-02-04 21:46:23 Chris J Arges puppetmaster (Ubuntu Utopic): assignee Felipe Reyes (freyes)
2015-02-04 21:50:06 Chris J Arges puppetmaster (Ubuntu): status Confirmed Fix Released
2015-02-05 18:40:41 Brian Murray removed subscriber Ubuntu Sponsors Team
2015-02-05 18:41:38 Brian Murray bug added subscriber Ubuntu Stable Release Updates Team
2015-02-05 18:41:40 Brian Murray bug added subscriber SRU Verification
2015-02-05 18:41:45 Brian Murray tags cts cts verification-needed
2015-02-05 19:04:30 Launchpad Janitor branch linked lp:ubuntu/trusty-proposed/puppet
2015-02-05 19:04:33 Launchpad Janitor branch linked lp:ubuntu/utopic-proposed/puppet
2015-02-05 20:40:12 Felipe Reyes tags cts verification-needed cts verification-done-trusty verification-done-utopic
2015-02-12 09:00:03 Adam Conrad removed subscriber Ubuntu Stable Release Updates Team
2015-06-15 20:19:23 Felipe Reyes puppetmaster (Ubuntu Trusty): status New Fix Released
2015-06-15 20:19:29 Felipe Reyes puppetmaster (Ubuntu Utopic): status New Fix Released