autopkgtests fail on oracular & noble

[Pushkar Kulkarni]

[ Impact ]
* The puppetdb autopkgtests fail on noble after the FTBFS bug [1] is fixed.

[ Test Plan ]
* Running autopkgtests on noble reveals the failure.

[ Where problems could occur ]
Currently, both tests under debian/test fail on oracular [2].

====

autopkgtest [00:30:43]: @@@@@@@@@@@@@@@@@@@@ summary
standalone FAIL stderr: warn: JDK 21.0.4-ea is neither tested nor supported. Please use JDK 17
with-puppetserver FAIL non-zero exit status 1

====

Test "standalone" fails because of Java 21 usage warning appears on stderr. Test "with-puppetserver" is an integration
test of puppetdb and puppetserver. The latter has been updated to 8.4.1-1 on noble. Use of a custom format named PSON was
completely abandoned in puppetserver 8. Any use of PSON in puppetdb 7 on noble needs to be removed.

[ Other Info ]
PuppetDB 7.X is compatible with PuppetServer 8.X [3]

[1] https://bugs.launchpad.net/ubuntu/+source/puppetdb/+bug/2069384
[2] https://paste.ubuntu.com/p/74h3nmKpXB/
[3] https://www.puppet.com/docs/puppetdb/7/overview.html

[Pushkar Kulkarni (pushkarnk)]

The same tests fail, with the same errors, on noble (puppetdb 7.12.1-3) after fixing the FTBFS reported by LP#2069384

[Launchpad Janitor (janitor)]

This bug was fixed in the package puppetdb - 8.4.1-1ubuntu1

---------------
puppetdb (8.4.1-1ubuntu1) oracular; urgency=medium

  * Fix autopkgtest failures (LP: #2072516)
    - d/t/control: add allow-stderr to accommodate
      a Java version warning
    - d/t/with-puppetserver: avoid a parsing error
      on lxd by surrounding the node name in quotes

 -- Pushkar Kulkarni <email address hidden> Tue, 09 Jul 2024 01:01:45 +0530

[Dave Jones (waveform)]

Unsubscribing ubuntu-sponsors for now; see comments on LP: #2069384

[Timo Aaltonen (tjaalton)]

Hello Pushkar, or anyone else affected,

Accepted puppetdb into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/puppetdb/7.12.1-3ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Pushkar Kulkarni (pushkarnk)]

TEST CASE:
1. Install and upgrade test.
    - try installing and removing puppetdb 7.12.1-3ubuntu0.1
      - apt install puppetdb=7.12.1-3ubuntu0.1
    - try upgrading puppetdb from 7.12.1-3 to 7.12.1-3ubuntu0.1 from noble-proposed
      - apt upgrade puppetdb=7.12.1-3ubuntu0.1
2. Run autopkgtests for puppetdb on noble using 7.12.1-3ubuntu0.1 from noble-proposed
   - autopkgtest puppetdb --apt-pocket=proposed=src:puppetdb -U -- lxd autopkgtest/ubuntu/noble/amd64

VERIFICATION DONE
1. Installation and upgrade from noble-proposed works as expected.
2. Autopkgtests pass with 7.12.1-3ubuntu0.1

[Andreas Hasenack (ahasenack)]

According to [1], puppetdb 7.12.1-3ubuntu0.1 in noble-proposed is still failing[2]:

729s autopkgtest [09:47:09]: @@@@@@@@@@@@@@@@@@@@ summary
729s standalone PASS
729s with-puppetserver FAIL non-zero exit status 1

The only reason it's not marked as a regression in the excuses report[3] is, I believe, because the previous version was also failing. So normally this wouldn't be a problem, but here we are claiming in this bug that we are fixing the DEP8 tests, so I was expecting them to be green.

Can someone take a look, and either fix the error, or explain what's going on?

1. https://autopkgtest.ubuntu.com/packages/puppetdb/noble/amd64
2. https://autopkgtest.ubuntu.com/results/autopkgtest-noble/noble/amd64/p/puppetdb/20240731_094926_bb178@/log.gz

[Pushkar Kulkarni (pushkarnk)]

I can't reproduce these 403 errors locally. I wonder if failures in [1] are due to an infra issue. I'll take a detailed look later in my day tomorrow to attempt an explanation.

Locally, I ran:

=====

$ autopkgtest puppetdb --apt-pocket=proposed=src:puppetdb -U -- lxd autopkgtest/ubuntu/noble/amd64

...
...

autopkgtest [01:52:05]: @@@@@@@@@@@@@@@@@@@@ summary
standalone PASS
with-puppetserver PASS

=====

Full output here https://paste.ubuntu.com/p/4VKYk8v23b/

[1] https://autopkgtest.ubuntu.com/results/autopkgtest-noble/noble/amd64/p/puppetdb/20240731_094926_bb178@/log.gz

[Andreas Hasenack (ahasenack)]

Could it be the squid.internal proxy, set for dep8 runs in the infrastructure? Can you perhaps unset the proxy variables in the test, or use noproxy (or NOPROXY) for the domains the test is trying to fetch?

[Chris Halse Rogers (raof)]

I'm flipping this to verification-failed, as the autopkgtests did *not* pass -
https://autopkgtest.ubuntu.com/packages/puppetdb/noble/amd64 and particularly https://autopkgtest.ubuntu.com/results/autopkgtest-noble/noble/amd64/p/puppetdb/20240731_094926_bb178@/log.gz

It *does* look like an problem in the launchpad test environment, which has a restrictive proxy in place - you *might* be able to get some help from the documentation here: https://github.com/canonical/ubuntu-maintainers-handbook/blob/main/PackageTests.md#restrict-networking

That documentation points you to using the *real* proxy, only available on the Canonical VPN, but you could try something similar with a self-hosted restrictive proxy.

[Pushkar Kulkarni (pushkarnk)]

Profuse apologies for the long delay on addressing this. To fix the autopkgtests by disabling the proxy (thanks for the information above!), I have created a new SRU bug report [1] for oracular and noble, and an MP [2] for oracular.

I am unsure if I must create the noble MP right now or wait for the reviews on [2]. I should probably wait.

[1] https://bugs.launchpad.net/ubuntu/+source/puppetdb/+bug/2084635
[2] https://code.launchpad.net/~pushkarnk/ubuntu/+source/puppetdb/+git/puppetdb/+merge/475170

[Chris Halse Rogers (raof)]

Re-subscribing ubuntu-sponsors; needs new upload from the previous comment.

[Andreas Hasenack (ahasenack)]

Why a new bug report...
Now we have:
- original FTBFS: LP: #2069384
- dep8 failure (this bug): LP: #2072516
- another bug about dep8 failure: LP: #2084635
- with its own pr: https://code.launchpad.net/~pushkarnk/ubuntu/+source/puppetdb/+git/puppetdb/+merge/475170

And that new bug didn't have sponsors subscribed.

Ok, heading over there now...