too silent puppet agent pluginsync failure if CRL is missing from node

[James Troup]

TL;DR: when the CRL is missing on a node, puppet agent pluginsync
fails way too silently.

Me and several of my colleagues just spent about 6 hours debugging our
broken puppet infrastructure. In the end it turns out that the
problem was how we were serving the CRL on our puppeteers (puppet
masters for individual networks) no longer works with puppet in
precise. As a result, the CRL file wasn't downloaded/present on the
client. This is turn caused pluginsync to fail. My problem is that
it failed completely silently; there's absolutely no hint from the
output (even with --debug, --verbose and --trace) as to why the
pluginsync is failing.

(We only figured it out from the apache logs of the puppeteer.

XX.XX.XX.XX 8443 - [19/Jul/2012:20:56:00 +0000] "GET /golive/file_metadata/plugins? HTTP/1.1" 200 296 "-" "-"
XX.XX.XX.XX 601270 - [19/Jul/2012:20:55:40 +0000] "GET /golive/file_metadatas/plugins?links=manage&ignore=---+%0A++-+.svn%0A++-+CVS%0A++-+.git&checksum_type=md5&recurse=true& HTTP/1.1" 200 12675 "-" "-"

The first is a CRL-less node; the second one has the CRL.)