2010-04-30 15:00:37 |
Chow Loong Jin |
attachment added |
|
01Pulseaudio.patch http://launchpadlibrarian.net/46628622/01Pulseaudio.patch |
|
2010-04-30 15:00:37 |
Chow Loong Jin |
bug |
|
|
added bug |
2010-04-30 15:12:17 |
Chow Loong Jin |
description |
affects ubuntu/pulseaudio
status triaged
assignee hyperair
importance high
tag patch regression-release
PROBLEM:
These few days, I noticed pulseaudio making weird sounds during and after
suspending, as well as hanging and wrecking havoc in every sound-using application.
This is with a kernel with sound-2.6.git merged in, so it's not about broken
outdated audio drivers.
REASON:
FIX:
1. Remove -l from all instances of su invocations. -l causes a login shell which
immediately causes the script to fail silently since all the su invocations go
to /dev/null.
2. Fix su quoting.
Regarding #2, There were several instances of 'blahblah${var}', which was
intended to sub in ${var}, but obviously wouldn't work because they was not
exported in the first place. So the patch changes ' to " for these cases.
Then there are the savestate/restorestate/state_exists shell functions which
were within the quotes of the command passed to su. This broke the script as well.
Attached is a patch which combined fixes for all the above issues. Do what you
will with it. I've tested it, and it works on my system.
--
Kind regards,
Chow Loong Jin
|
affects ubuntu/pulseaudio
status triaged
assignee hyperair
importance high
tag patch regression-release
PROBLEM:
These few days, I noticed pulseaudio making weird sounds during and after
suspending, as well as hanging and wrecking havoc in every sound-using application.
This is with a kernel with sound-2.6.git merged in, so it's not about broken
outdated audio drivers.
REASON:
01Pulseaudio pm-utils hook script is broken in several places.
FIX:
1. Remove -l from all instances of su invocations. -l causes a login shell which
immediately causes the script to fail silently since all the su invocations go
to /dev/null.
2. Fix su quoting.
Regarding #2, There were several instances of 'blahblah${var}', which was
intended to sub in ${var}, but obviously wouldn't work because they was not
exported in the first place. So the patch changes ' to " for these cases.
Then there are the savestate/restorestate/state_exists shell functions which
were within the quotes of the command passed to su. This broke the script as well.
Attached is a patch which combined fixes for all the above issues. Do what you
will with it. I've tested it, and it works on my system.
--
Kind regards,
Chow Loong Jin
|
|
2010-04-30 15:12:23 |
Launchpad Janitor |
branch linked |
|
lp:~hyperair/pulseaudio/fix-01Pulseaudio-quoting |
|
2010-05-03 10:53:44 |
Daniel T Chen |
pulseaudio (Ubuntu): status |
Triaged |
Fix Committed |
|
2010-05-03 10:54:11 |
Daniel T Chen |
nominated for series |
|
Ubuntu Lucid |
|
2010-05-03 10:54:11 |
Daniel T Chen |
bug task added |
|
pulseaudio (Ubuntu Lucid) |
|
2010-05-03 10:54:34 |
Daniel T Chen |
pulseaudio (Ubuntu Lucid): status |
New |
Fix Committed |
|
2010-05-03 10:54:40 |
Daniel T Chen |
pulseaudio (Ubuntu Lucid): assignee |
|
Daniel T Chen (crimsun) |
|
2010-05-03 10:54:47 |
Daniel T Chen |
pulseaudio (Ubuntu Lucid): milestone |
|
lucid-updates |
|
2010-05-03 10:55:34 |
Daniel T Chen |
summary |
01Pulseaudio does nothing |
01Pulseaudio does nothing due to misuse of su -l and shell misquoting |
|
2010-05-03 14:19:25 |
Launchpad Janitor |
branch linked |
|
lp:~ubuntu-core-dev/pulseaudio/ubuntu.2a.maverick |
|
2010-05-08 15:15:10 |
Launchpad Janitor |
pulseaudio (Ubuntu): status |
Fix Committed |
Fix Released |
|
2010-05-08 16:15:32 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/pulseaudio |
|
2010-06-05 11:56:58 |
Julian Wiedmann |
removed subscriber Julian Wiedmann |
|
|
|
2015-06-17 11:46:00 |
Rolf Leggewie |
pulseaudio (Ubuntu Lucid): status |
Fix Committed |
Won't Fix |
|