Support kernel 5.4 Intel sound driver on bionic

[Kai-Chuan Hsieh]

[Impact]

 * Some Intel platform bionic user audio function will be broken after upgrade to kernel 5.4

 * pulseaudio can't find working profile, since card name is changed in kernel 5.4

[Test Case]

 * install kernel 5.4 and check audio function
   1. enable Pre-released updates in Developer Options
      Software & Updates > Developer Options > Pre-released updates (bionic-proposed)
   2. $ sudo apt update
   3. $ sudo apt install linux-generic-hwe-18.04-edge
   4. $ sudo reboot

 * install updated linux-firmware and pulseaudio
   $ sudo add-apt-repository ppa:kchsieh/training
   $ sudo apt-get update
   $ sudo apt install linux-firmware
   $ sudo apt install pulseaudio
   $ sudo reboot

 * test items
   1. check internal speaker/mic to playback and record audio
   2. plug headset and check headset functions
   3. plug HDMI from external monitor/TV, and check audio functions
   4. 1, 2, 3 works fine after resume from suspend

[Regression Potential]

 * The updated pulseaudio breaks audio function on old kernel

[Scope]

 * Need for bionic only

[Bug Discussion]

 * https://bugs.launchpad.net/timbuktu/+bug/1880632
 * MP: https://code.launchpad.net/~kchsieh/pulseaudio/+git/bionic-1880632/+merge/384610

[Chih-Hsyuan Ho (chih)]

Can we get SRU process for this fix in pulseaudio started as soon as possible? There is one OEM platform which is urgently waiting for it. Thank you.

[Kai-Chuan Hsieh (kchsieh)]

Should I take any action for it?

[Sebastien Bacher (seb128)]

Thanks Kai-Chuan

From the description

> * The updated pulseaudio breaks audio function on old kernel

is that a potential worry or a confirmed issue? is the new pulseaudion going to work with the current bionic kernel?

[Kai-Chuan Hsieh (kchsieh)]

@seb128

it is just a potential worry, I've verified on three different CPU platforms Cometlake, Coffeelake, and Whiskylake. They work both on old kernel and the 5.4-edge-kernel. I don't know If my description is appropriate, it is nice if you can give me some input, thanks.

[Sebastien Bacher (seb128)]

@Kai, is there any archive search or similar that could be done to ensure nothing is relying on the old naming? could it break existing user configurations?

[Kai-Chuan Hsieh (kchsieh)]

@Sebstien

Could you help to indicate how to do the archive search? I'll try to finish it to lower the regression risk.

Sorry that I have less experience about it, it would be nice if you can give me more insight.

Thanks,

[Sebastien Bacher (seb128)]

I can try to help with the grepping but I don't understand what were the old names and what are the new ones, maybe you could give some details on the changes?

[Kai-Chuan Hsieh (kchsieh)]

for a sound card, there is a short-name and long-name. I only adjust the short name which the pulseaudio utilize to identify the ucm config.

old short name: sofsklhdacard
new short name: sofhdadsp

may I know how you grepping it? what command you use would be enough.

Thanks,

[Hui Wang (hui.wang)]

@Kai-Chuan,

To be safe, could you please apply the change to a LENOVO machine and test if it works or not. Dell DMIC machines depends on the soundcard's name to work while Lenovo DMIC machines depends on soundcard's long name or BIOS Rev string to work. I remember there is a LENOVO X1C7 in Taipei office, and a couple of weeks ago this machine was kept by Kaiheng. If your change could work on LENOVO X1C7, it means all LENOVO DMIC machines could work.

thx.

[Kai-Chuan Hsieh (kchsieh)]

@Hui

Sure, will do.

[Kai-Chuan Hsieh (kchsieh)]

Test on LenovoX1C7. Default DMIC and speaker works okay with the updated pulseaudio for kernel 5.4 and kernel 5.3.

https://pastebin.ubuntu.com/p/hMjZmvwNh4/

[Sebastien Bacher (seb128)]

the changes are uploaded to the bionic SRU queue

[Gabriel Zhi Chen (gabrielzchen)]

[Test Case]

 * install kernel 5.4 and check audio function
   1. enable Pre-released updates in Developer Options
      Software & Updates > Developer Options > Pre-released updates (bionic-proposed)
   2. $ sudo apt update
   3. $ sudo apt install linux-generic-hwe-18.04-edge
   4. $ sudo reboot

 * install updated linux-firmware and pulseaudio
   $ sudo add-apt-repository ppa:kchsieh/training
   $ sudo apt-get update
   $ sudo apt install linux-firmware
   $ sudo apt install pulseaudio
   $ sudo reboot

 * test items
   1. check internal speaker/mic to playback and record audio
   2. plug headset and check headset functions
   3. plug HDMI from external monitor/TV, and check audio functions
   4. 1, 2, 3 works fine after resume from suspend

[Test machines and results]
   1. Lenovo ThinkPad X1 Carbon 7th, internal speaker/mic, headset functions, HDMI monitor/TV before/after S3 working normally.
   2. Lenovo ThinkPad X390, internal speaker/mic, headset functions, HDMI monitor/TV before/after S3 working normally too.

[Gabriel Zhi Chen (gabrielzchen)]

[Test Case]

 * install kernel 5.4 and check audio function
   1. enable Pre-released updates in Developer Options
      Software & Updates > Developer Options > Pre-released updates (bionic-proposed)
   2. $ sudo apt update
   3. $ sudo apt install linux-generic-hwe-18.04-edge
   4. $ sudo reboot

 * install updated linux-firmware and pulseaudio
   $ sudo add-apt-repository ppa:kchsieh/training
   $ sudo apt-get update
   $ sudo apt install linux-firmware
   $ sudo apt install pulseaudio
   $ sudo reboot

 * test items
   1. check internal speaker/mic to playback and record audio
   2. plug headset and check headset functions
   3. plug HDMI from external monitor/TV, and check audio functions
   4. 1, 2, 3 works fine after resume from suspend

[Test machines and results]
   Lenovo ThinkPad T15, internal speaker/mic, headset functions, HDMI monitor/TV before/after S3 working normally.

[Łukasz Zemczak (sil2100)]

Hello Kai-Chuan, or anyone else affected,

Accepted pulseaudio into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/pulseaudio/1:11.1-1ubuntu7.9 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Kai-Chuan Hsieh (kchsieh)]

Test on Dell Inspiron 7591 from stock Ubuntu

Have found a issue on the hardware, lp: 1885713.
Proceed the test by the following step:

1. add bionic-proposed to source list
2. $ sudo apt install linux-firmware
3. $ sudo apt install pulseaudio

internal speaker + DMIC: ok
headset Mic + Headphone: ok
HDMI out to display with speaker: ok

4. $ sudo apt install linux-generic-hwe-18.04-edge

internal speaker + DMIC: ok
Headset Mic + Headphone: ok
HDMI output to display with speaker: ok

[Launchpad Janitor (janitor)]

This bug was fixed in the package pulseaudio - 1:11.1-1ubuntu7.9

---------------
pulseaudio (1:11.1-1ubuntu7.9) bionic; urgency=medium

  [Kai-Chuan Hsieh]
  * alsa-mixer: Correct ucm card name (LP: #1881094)

  [Hui Wang]
  * d/p/0901-alsa-solaris-oss-remove-unnecessary-error-handling-w.patch
  * d/p/0902-alsa-Improve-resume-logic-after-alsa-suspend.patch
  * (LP: #1882042)

 -- Kai-Chuan Hsieh <email address hidden> Wed, 27 May 2020 16:42:50 +0800

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for pulseaudio has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.