Activity log for bug #1806060

Date Who What changed Old value New value Message
2018-11-30 15:10:38 Hamish McIntyre-Bhatty bug added bug
2018-12-03 09:59:23 Karl Stenerud psmisc (Ubuntu): status New Confirmed
2018-12-03 10:03:39 Karl Stenerud description Newer versions of killall (Ubuntu 18.04+) display usage when the signal is passed like: killall -INT <name> and instead require it to be passed as: killall -int <name> In previous versions from Ubuntu 14.04 and 16.04, this doesn't happen. Is this a bug or a feature change? If so perhaps it should be noted in the usage information? The man page suggests capitals with "-SIGNAL". but that doesn't work any more. Hamish [Impact] Uppercase signal names are no longer accepted by killall; only lowercase signal names are accepted. The documentation still shows signal names in uppercase. This is a regression as of bionic. [Test Case] # killall -int asdf asdf: no process found # killall -INT asdf Usage: killall [ -Z CONTEXT ] [ -u USER ] [ -y TIME ] [ -o TIME ] [ -eIgiqrvw ] [ -s SIGNAL | -SIGNAL ] NAME... [Regression Potential] This is a regression, and so there would be no regression potential in a fix. [Original Description] Newer versions of killall (Ubuntu 18.04+) display usage when the signal is passed like: killall -INT <name> and instead require it to be passed as: killall -int <name> In previous versions from Ubuntu 14.04 and 16.04, this doesn't happen. Is this a bug or a feature change? If so perhaps it should be noted in the usage information? The man page suggests capitals with "-SIGNAL". but that doesn't work any more. Hamish
2018-12-03 10:03:56 Karl Stenerud psmisc (Ubuntu): importance Undecided High
2018-12-03 10:04:48 Karl Stenerud tags server-next
2018-12-10 13:50:52 Christian Ehrhardt  nominated for series Ubuntu Cosmic
2018-12-10 13:50:52 Christian Ehrhardt  bug task added psmisc (Ubuntu Cosmic)
2018-12-10 13:50:52 Christian Ehrhardt  nominated for series Ubuntu Bionic
2018-12-10 13:50:52 Christian Ehrhardt  bug task added psmisc (Ubuntu Bionic)
2018-12-10 13:50:57 Christian Ehrhardt  psmisc (Ubuntu): status Confirmed Fix Released
2018-12-10 13:51:00 Christian Ehrhardt  psmisc (Ubuntu Bionic): status New Confirmed
2018-12-10 13:51:02 Christian Ehrhardt  psmisc (Ubuntu Cosmic): status New Confirmed
2018-12-10 13:51:19 Christian Ehrhardt  bug added subscriber Ubuntu Server
2018-12-11 15:24:06 Christian Ehrhardt  description [Impact] Uppercase signal names are no longer accepted by killall; only lowercase signal names are accepted. The documentation still shows signal names in uppercase. This is a regression as of bionic. [Test Case] # killall -int asdf asdf: no process found # killall -INT asdf Usage: killall [ -Z CONTEXT ] [ -u USER ] [ -y TIME ] [ -o TIME ] [ -eIgiqrvw ] [ -s SIGNAL | -SIGNAL ] NAME... [Regression Potential] This is a regression, and so there would be no regression potential in a fix. [Original Description] Newer versions of killall (Ubuntu 18.04+) display usage when the signal is passed like: killall -INT <name> and instead require it to be passed as: killall -int <name> In previous versions from Ubuntu 14.04 and 16.04, this doesn't happen. Is this a bug or a feature change? If so perhaps it should be noted in the usage information? The man page suggests capitals with "-SIGNAL". but that doesn't work any more. Hamish [Impact] * Not all Uppercase signal names are accepted by killall in the new version (INT + ILL + VTALRM will not work) * by that the man page refers to things no more working and old scripts might break. [Test Case] * run this and check if all signals were accepted by the commandline of killall #!/bin/bash #set -x TNAME="uninitialized" testkillall () { local tsig=${1} /tmp/${TNAME} /dev/urandom & local tpid=$!; echo "TEST -${tsig}"; killall -${tsig} "${TNAME}" kill -9 "${tpid}" 2>/dev/null; kill -9 "${TNAME}" 2>/dev/null; } for sig in $(killall -l | xargs); do TNAME="test${sig}" cp /usr/bin/md5sum "/tmp/${TNAME}" testkillall "$(echo ${sig} | tr '[:lower:]' '[:upper:]')" testkillall "SIG$(echo ${sig} | tr '[:lower:]' '[:upper:]')" #testkillall "$(echo ${sig} | tr '[:upper:]' '[:lower:]')" rm -f "/tmp/${TNAME}" sync done [Regression Potential] * This reworks more of the argument parsing than one would like, but this is due to one of such reworks being the breaking change in the former version and a more minimal fix is hard to come up with. Due to that obviously there could be "new" issues added to the argument parsing. At least in this case we checked all signals and they worked fine. Furthermore the new code also added a bunch of tests which work fine since adding that. [Other Info] * This is a regression as of bionic. --- [Original Description] Newer versions of killall (Ubuntu 18.04+) display usage when the signal is passed like: killall -INT <name> and instead require it to be passed as: killall -int <name> In previous versions from Ubuntu 14.04 and 16.04, this doesn't happen. Is this a bug or a feature change? If so perhaps it should be noted in the usage information? The man page suggests capitals with "-SIGNAL". but that doesn't work any more. Hamish
2018-12-11 15:57:59 Launchpad Janitor merge proposal linked https://code.launchpad.net/~paelzer/ubuntu/+source/psmisc/+git/psmisc/+merge/360686
2018-12-11 15:58:20 Launchpad Janitor merge proposal linked https://code.launchpad.net/~paelzer/ubuntu/+source/psmisc/+git/psmisc/+merge/360687
2018-12-11 16:00:06 Christian Ehrhardt  psmisc (Ubuntu Bionic): status Confirmed Triaged
2018-12-11 16:00:07 Christian Ehrhardt  psmisc (Ubuntu Cosmic): status Confirmed Triaged
2018-12-12 10:15:27 Christian Ehrhardt  description [Impact] * Not all Uppercase signal names are accepted by killall in the new version (INT + ILL + VTALRM will not work) * by that the man page refers to things no more working and old scripts might break. [Test Case] * run this and check if all signals were accepted by the commandline of killall #!/bin/bash #set -x TNAME="uninitialized" testkillall () { local tsig=${1} /tmp/${TNAME} /dev/urandom & local tpid=$!; echo "TEST -${tsig}"; killall -${tsig} "${TNAME}" kill -9 "${tpid}" 2>/dev/null; kill -9 "${TNAME}" 2>/dev/null; } for sig in $(killall -l | xargs); do TNAME="test${sig}" cp /usr/bin/md5sum "/tmp/${TNAME}" testkillall "$(echo ${sig} | tr '[:lower:]' '[:upper:]')" testkillall "SIG$(echo ${sig} | tr '[:lower:]' '[:upper:]')" #testkillall "$(echo ${sig} | tr '[:upper:]' '[:lower:]')" rm -f "/tmp/${TNAME}" sync done [Regression Potential] * This reworks more of the argument parsing than one would like, but this is due to one of such reworks being the breaking change in the former version and a more minimal fix is hard to come up with. Due to that obviously there could be "new" issues added to the argument parsing. At least in this case we checked all signals and they worked fine. Furthermore the new code also added a bunch of tests which work fine since adding that. [Other Info] * This is a regression as of bionic. --- [Original Description] Newer versions of killall (Ubuntu 18.04+) display usage when the signal is passed like: killall -INT <name> and instead require it to be passed as: killall -int <name> In previous versions from Ubuntu 14.04 and 16.04, this doesn't happen. Is this a bug or a feature change? If so perhaps it should be noted in the usage information? The man page suggests capitals with "-SIGNAL". but that doesn't work any more. Hamish [Impact]  * Not all Uppercase signal names are accepted by killall in the new    version (INT + ILL + VTALRM will not work)  * by that the man page refers to things no more working and old scripts    might break. [Test Case]  * run this and check if all signals were accepted by the commandline of killall #!/bin/bash TNAME="uninitialized" testkillall () {         local tsig=${1}         /tmp/${TNAME} /dev/urandom &         local tpid=$!;         echo "TEST -${tsig}";         killall -${tsig} "${TNAME}"         kill -9 "${tpid}" 2>/dev/null;         kill -9 "${TNAME}" 2>/dev/null; } for sig in $(killall -l | xargs); do         TNAME="test${sig}"         cp /usr/bin/md5sum "/tmp/${TNAME}"         testkillall "$(echo ${sig} | tr '[:lower:]' '[:upper:]')"         testkillall "SIG$(echo ${sig} | tr '[:lower:]' '[:upper:]')"         rm -f "/tmp/${TNAME}"         sync done [Regression Potential]  * This reworks more of the argument parsing than one would like, but this    is due to one of such reworks being the breaking change in the former    version and a more minimal fix is hard to come up with.    Due to that obviously there could be "new" issues added to the argument    parsing. At least in this case we checked all signals and they worked    fine. Furthermore the new code also added a bunch of tests which work    fine since adding that. [Other Info]  * This is a regression as of bionic. --- [Original Description] Newer versions of killall (Ubuntu 18.04+) display usage when the signal is passed like: killall -INT <name> and instead require it to be passed as: killall -int <name> In previous versions from Ubuntu 14.04 and 16.04, this doesn't happen. Is this a bug or a feature change? If so perhaps it should be noted in the usage information? The man page suggests capitals with "-SIGNAL". but that doesn't work any more. Hamish
2018-12-13 20:32:35 Andreas Hasenack psmisc (Ubuntu Bionic): status Triaged In Progress
2018-12-13 20:32:37 Andreas Hasenack psmisc (Ubuntu Cosmic): status Triaged In Progress
2018-12-13 20:32:44 Andreas Hasenack psmisc (Ubuntu Bionic): importance Undecided High
2018-12-13 20:32:45 Andreas Hasenack psmisc (Ubuntu Cosmic): importance Undecided High
2018-12-13 20:32:52 Andreas Hasenack psmisc (Ubuntu Bionic): assignee Christian Ehrhardt  (paelzer)
2018-12-13 20:33:00 Andreas Hasenack psmisc (Ubuntu Cosmic): assignee Christian Ehrhardt  (paelzer)
2018-12-18 17:18:08 Brian Murray psmisc (Ubuntu Cosmic): status In Progress Fix Committed
2018-12-18 17:18:10 Brian Murray bug added subscriber Ubuntu Stable Release Updates Team
2018-12-18 17:18:12 Brian Murray bug added subscriber SRU Verification
2018-12-18 17:18:16 Brian Murray tags server-next server-next verification-needed verification-needed-cosmic
2018-12-18 17:22:48 Brian Murray psmisc (Ubuntu Bionic): status In Progress Fix Committed
2018-12-18 17:22:53 Brian Murray tags server-next verification-needed verification-needed-cosmic server-next verification-needed verification-needed-bionic verification-needed-cosmic
2018-12-19 12:10:43 Hamish McIntyre-Bhatty tags server-next verification-needed verification-needed-bionic verification-needed-cosmic server-next verification-done-bionic verification-needed verification-needed-cosmic
2018-12-19 12:21:13 Hamish McIntyre-Bhatty tags server-next verification-done-bionic verification-needed verification-needed-cosmic server-next verification-done-bionic verification-done-cosmic verification-needed
2019-01-07 08:15:23 Launchpad Janitor psmisc (Ubuntu Cosmic): status Fix Committed Fix Released
2019-01-07 08:15:28 Łukasz Zemczak removed subscriber Ubuntu Stable Release Updates Team
2019-01-07 10:41:43 Launchpad Janitor psmisc (Ubuntu Bionic): status Fix Committed Fix Released