psensor 0.6.2.15-1 fails to build in precise due to an unnamed struct in glib

[Micah Gersten]

Debian glib2.0 version: 2.30.2-4
Ubuntu glib2.0 version: 2.31.4.tested-0ubuntu3
Link to glib upstream code: http://git.gnome.org/browse/glib/tree/glib/deprecated/gthread.h?id=2f9ab64ac9dc4aeba4a6a297888986d26515d6f8#n151

When trying to build psensor 0.6.2.15-1 in precise, it fails to due to an unnamed struct in glib:
gcc -DHAVE_CONFIG_H -I. -I../.. -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/libgtop-2.0 -I/usr/include/json -D_FORTIFY_SOURCE=2 -Wall -Werror -pedantic -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -c -o libpsensor_a-cpu.o `test -f 'cpu.c' || echo './'`cpu.c
In file included from /usr/include/glib-2.0/glib.h:107:0,
                 from /usr/include/libgtop-2.0/glibtop.h:25,
                 from /usr/include/libgtop-2.0/glibtop/cpu.h:25,
                 from cpu.c:25:
/usr/include/glib-2.0/glib/deprecated/gthread.h:165:4: error: ISO C90 doesn't support unnamed structs/unions [-Werror=edantic]
cc1: all warnings being treated as errors

make[4]: *** [libpsensor_a-cpu.o] Error 1
make[4]: Leaving directory `/«PKGBUILDDIR»/src/lib'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/«PKGBUILDDIR»/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/«PKGBUILDDIR»'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/«PKGBUILDDIR»'
dh_auto_build: make -j1 returned exit code 2
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2

[Micah Gersten (micahg)]

BTW, you can pull this version from Debian. I can't merge it to Ubuntu unless psensor does away with -pedantic or the glib declaration is fixed.

[Jean-Philippe Orsini (jfi)]

The PPA used for daily build reproduce this issue since few days.

Could glib maintainer let know if this issue is going to be fixed or considered as 'not a bug'? If considered as bug, is it going to be fixed in Ubuntu before the Precise feature?

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Jean-Philippe Orsini (jfi)]

*before Precise feature freeze

[Jean-Philippe Orsini (jfi)]

This issue has been workarounded by the removal of the -pedantic option in the v0.6.2.16 of Psensor (http://wpitchoune.net/psensor/files/psensor-0.6.2.16.tar.gz).

I have asked my Debian sponsor to upload to Debian repository a new version of the package (http://wpitchoune.net/tmp/nduboc/v0.6.2.16-1/) which also fixes 'Please use wrap-and-sort from devscripts' (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=652531).

[Jean-Philippe Orsini (jfi)]

I opened a bug on the GLib side:
https://bugzilla.gnome.org/show_bug.cgi?id=666978

[Jean-Philippe Orsini (jfi)]

Attached a patch for fixing the issue at the glib level. It is similar to the modification done by upstream

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "fix_905893.debdiff" of this bug report has been identified as being a patch in the form of a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

[Jean-Philippe Orsini (jfi)]

Psensor v0.6.2.16 which is workarounding the compilation issue on Ubuntu Precise has reached the unstable debian repository: http://packages.debian.org/source/unstable/psensor.

[Jean-Philippe Orsini (jfi)]

Psensor v0.6.2.16 is now in the Debian testing repository:
http://packages.qa.debian.org/p/psensor/news/20120118T163914Z.html

It fixes this build issue.

[Micah Gersten (micahg)]

Yes, I'll probably merge it tomorrow night.

[Launchpad Janitor (janitor)]

This bug was fixed in the package psensor - 0.6.2.16-1ubuntu1

---------------
psensor (0.6.2.16-1ubuntu1) precise; urgency=low

  * Merge from Debian testing. Remaining changes:
    + Modifed build-dep to add NVidia and Application Indicator support
    + Only add an nvidia-settings build-dep on i386 and amd64

  * Add a patch to drop the deprecated g_thread_init() call
    - add debian/patches/drop_g_thread_init.patch
    - add debian/patches/series

psensor (0.6.2.16-1) unstable; urgency=low

  * New upstream release
      - removed -pedantic compilation option. (Closes LP: #905893)
  * debian/control, debian/psensor.install, debian/psensor-server.install:
      - applied wrap-and-sort. (Closes: #652531)

psensor (0.6.2.15-1) unstable; urgency=low

  * New upstream release
      - fct sysinfo is replaced by gtop2 calls. (Closes: #650533)
  * debian/control
      - set priority to 'extra' instead of 'optional' due to dependence
  on json-c lib which is using a priority 'extra'.

psensor (0.6.2.14-1) unstable; urgency=low

  * New upstream release
      - monochrome icons for Ubuntu themes. (Closes LP: #811003)
  * debian/copyright:
      - replaced email with my personnal one
      - added license and copyright info for jqplot
  * debian/control:
      - removed useless dep to lua
      - switch to Standards-Version 3.9.2
      - added build dep to libjs-query
      - replaced email with my personnal one
      - build dep to gtk3 instead of gtk2
  * debian/psensor.install:
      - added icons directory to include ubuntu default icons theme
      - added directories for glade files
      - added directory for autostart file
  * debian/psensor-server.links:
      - linked query.js file from libjs-query package
 -- Micah Gersten <email address hidden> Sat, 21 Jan 2012 22:41:34 -0600

[Sebastien Bacher (seb128)]

the glib issue got fixed as well