Precedence issue in /usr/sbin/fwcheck_psad line 193

[James Fraser]

NAME="Ubuntu"
VERSION="16.10 (Yakkety Yak)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 16.10"
VERSION_ID="16.10"
HOME_URL="http://www.ubuntu.com/"
SUPPORT_URL="http://help.ubuntu.com/"
BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="http://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=yakkety
UBUNTU_CODENAME=yakkety

--

psad:
  Installed: 2.2.3-1.1
  Candidate: 2.2.3-1.1
  Version table:
 *** 2.2.3-1.1 500
        500 http://au.archive.ubuntu.com/ubuntu yakkety/universe amd64 Packages
        100 /var/lib/dpkg/status

--

When you run "psad -R", you get warning:

Possible precedence issue with control flow operator at /usr/sbin/fwcheck_psad line 193.

--

This can be fixed by setting parenthesis around return on 193:

    return ($forward_chain_rv and $input_chain_rv);

[Max Cady (max-cady)]

Thank you! This was very helpful!

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.