crash/coredump with long username/password (basic auth)
Bug #1648264 reported by
Tharrrk
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
proxytunnel (Ubuntu) |
New
|
Undecided
|
Unassigned |
Bug Description
Basic auth buffer (<email address hidden>:35) is only 80 bytes.
So any longer username/password combination (after being b64'd) will result either in some kind of hidden or visible crash.
The same buffer size (80) is defined for a whole message to proxy (<email address hidden>:169) standalone daemon mode (do_daemon()) which probably causes crashes as well or at least strange behaviour since parts of the memory are definitely overwritten in strzcat, where the buffer is 65535.
Global value for buffers' sizes (macro <email address hidden>:56) is however defined as 65536 and I think it should be used instead of those 80's.
To post a comment you must log in.
proposed patch