crash/coredump with long username/password (basic auth)

Bug #1648264 reported by Tharrrk on 2016-12-08
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
proxytunnel (Ubuntu)
Undecided
Unassigned

Bug Description

Basic auth buffer (<email address hidden>:35) is only 80 bytes.
So any longer username/password combination (after being b64'd) will result either in some kind of hidden or visible crash.
The same buffer size (80) is defined for a whole message to proxy (<email address hidden>:169) standalone daemon mode (do_daemon()) which probably causes crashes as well or at least strange behaviour since parts of the memory are definitely overwritten in strzcat, where the buffer is 65535.
Global value for buffers' sizes (macro <email address hidden>:56) is however defined as 65536 and I think it should be used instead of those 80's.

Tharrrk (tharrrk) wrote :

proposed patch

The attachment "008_buffersizes" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers