Thank you for volunteering your time to get this bug fixed.

Your diff, with the quilt patch you added, looks functional and does roughly what you intended. However, as you expected there are a number of things that need fixing, which I've described in more detail below. I think the list is quite long only because you're jumping in at the deep end by trying to update to a newer release and you're drowning in all the complications that entail. I think it'd be much simpler for your first update if you aim to fix just this particular bug first.

To make progress, I suggest that you focus just on this particular bug ("protracker refuses to run due to incorrect ABI check"), and don't attempt to update Bionic to a newer release, which is much harder all round - from technical, policy and process perpsectives. Please figure out the minimal patch that stops protracker refusing to run due to the incorrect ABI check, and follow the documented SRU procedure (https://wiki.ubuntu.com/StableReleaseUpdates#Procedure) with just that fix in mind.

Here's a review of the debdiff you attached in comment 20. Keep in mind that many of these will disappear if you try to simply fix this bug rather than try to update everything else at once.

Noise is introduced in other debian patches (your debdiff changes all the other files in debian/patches/!). Please don't refresh unrelated patches unless necessary. When refreshing, please use quilt settings described at https://wiki.debian.org/UsingQuilt to minimise noise.

There's a bunch of line ending noise introduced in your new 00-update-upstream-r126.patch file. I don't know if this was in the upstream code, but if it was not then it's inappropriate to add here.

We don't update to new upstreams revisions using quilt. We use a new orig tarball instead. This is too complex to explain directly here, but as I'm proposing that you don't attempt this for your first update, I suggest you don't worry about it for now.

Changelog bug references needs to be in the form "LP: #1769693" for tooling to pick it up correctly.

Changelog entry should say "bionic" instead of "unstable" for an update to bionic.

When introducing an Ubuntu delta, please run "update-maintainer" to fix the Maintainer fields in debian/control.

Version string should be 2.3d.r92-1.1 for a bugfix update to Bionic, or 2.3d.r126-0ubuntu0.18.04.1 for a full upstream version bump to Bionic.

SRU process needs to be followed either way, but is much more complex for an upstream version update. Please familarise yourself with the SRU documentation page (https://wiki.ubuntu.com/StableReleaseUpdates). Then make sure that your proposed upload meets all the requirements, make sure you've detailed how it does so for your reviewer in any grey areas, and make sure you've followed the SRU procedure fully.

Fixes going to a stable release need to be fixed in the development release first. You can't leave Cosmic on r122 but put Bionic on r126, for example, since that will cause users to regress when they upgrade. This applies for bug fixes too, but in that case it's only the specific bug fixes you're applying to Bionic that need to go into Cosmic first. Olav says in comment 12 that this bug is already fixed upstream. Please check if this fix is included in the version currently in Cosmic. If it is not, then you'll need to prepare an update for Cosmic first.

Thanks again for looking at this. Sorry my review is so long. I'd like to re-iterate that I think it'll be much easier for you if you focus on just this bug first, and forget about a full upstream update for now. Once you have some experience you will be able assess for yourself if an upstream update will comply with SRU policy and you'll know how to do it.

Feel free to ping me in #ubuntu-motu if you have any questions.