Trailing comma after enum definition list fails with pedantic warning

Bug #264124 reported by Jay Pipes
4
Affects Status Importance Assigned to Milestone
Drizzle
Fix Released
High
Monty Taylor
protobuf (Ubuntu)
Undecided
Unassigned

Bug Description

This is a known upstream issue (see http://groups.google.com/group/protobuf/browse_thread/thread/2e7fffac6fa5c6c9/099acdd9ced1b004?hl=en). protoc generates enum definitions that fail pedantic warnings for gcc.

Attached patch fixes issue. Patch will be included in 2.0.1beta version, to be released shortly.

Apply patch and then run:

bash ./generate_descriptor_proto.sh

in order to generate an updated descriptor.pb.h file so that make check will pass all tests.

Cheers,

Jay

Related branches

Revision history for this message
Jay Pipes (jaypipes) wrote :
Revision history for this message
Elliot Murphy (statik) wrote :

Applied the patch from Jay. There is no patch system currently in the package, but this is a really simple single patch, so I decided not to add a patch system at this point. Instead I'd like to wait until there is a second patch that needs applying, and add the patch system then. If one of the universe sponsors thinks this is the wrong approach, I'm willing to take suggestions.

Attaching a debdiff which includes this patch and fixes the issue. Subscribing ubuntu-universe-sponsors.

Changed in protobuf:
assignee: nobody → statik
status: New → Confirmed
assignee: statik → nobody
Revision history for this message
Elliot Murphy (statik) wrote :

This has a failing test in the PPA, so I need to update the patch. Doesn't look like I can unsubscribe ubuntu-universe-sponsors, so I'll just try to get an updated debdiff attached quickly.

Revision history for this message
Elliot Murphy (statik) wrote :

Updated debdiff attached.

Revision history for this message
Jay Pipes (jaypipes) wrote : Re: [Bug 264124] Re: Trailing comma after enum definition list fails with pedantic warning

The failing test case is fixed by applying the patch and then running
the following utility from the GPB source code root directory:

bash generate_descriptor_proto.sh

Cheers!
Jay

Elliot Murphy wrote:
> This has a failing test in the PPA, so I need to update the patch.
> Doesn't look like I can unsubscribe ubuntu-universe-sponsors, so I'll
> just try to get an updated debdiff attached quickly.
>

Revision history for this message
Daniel Holbach (dholbach) wrote :

Elliot: do you think you can add a reference to the origin of the patch to debian/changelog or at least mention the files that were changed, so it's easier for the next person who merges stuff either from Debian or upstream?

Revision history for this message
Elliot Murphy (statik) wrote :

Daniel: certainly, I'll do that now and provide a new debdiff shortly.

Revision history for this message
Daniel Holbach (dholbach) wrote : Unsubscribing Sponsors.

I'm unsubscribing the Sponsors' Team for now. Please re-subscribe when ready.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package protobuf - 2.0.0~b-3ubuntu2

---------------
protobuf (2.0.0~b-3ubuntu2) intrepid; urgency=low

  * src/google/protobuf/compiler/cpp/cpp_enum.cc: added patch to stop
    generating trailing comma after enum definition. (Going to be applied
    upstream soon: http://tinyurl.com/3l72co) (LP: #264124)
  * src/google/protobuf/descriptor.pb.h: Run 'bash
    generate_descriptor_proto.sh'.

 -- Elliot Murphy <email address hidden> Tue, 23 Sep 2008 17:48:44 -0400

Changed in protobuf:
status: Confirmed → Fix Released
Revision history for this message
Monty Taylor (mordred) wrote :

The bug has also been fixed in 2.0.2 of protobuf upstream.

Changed in drizzle:
assignee: nobody → mordred
importance: Undecided → High
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers