Activity log for bug #1246245

Date Who What changed Old value New value Message
2013-10-30 09:56:28 Goldhead bug added bug
2013-11-04 06:57:38 Launchpad Janitor proftpd-dfsg (Ubuntu): status New Confirmed
2013-11-19 19:33:07 WebChip bug added subscriber WebChip
2014-05-06 11:58:49 Alexander Birkner bug added subscriber Alexander Birkner
2014-05-06 12:00:46 Alexander Birkner description proftpd-basic 1.3.5~rc3-2 from Ubuntu 13.10 Init script from proftpd-basic package contains the BUG: when you run /etc/init.d/proftpd restart it fails because of there is the race between pidfile removal and start() which checks pidfile existency: --- ProFTPD is started in standalone mode, currently running. root@aa:~# /etc/init.d/proftpd restart * Stopping ftp server proftpd [ OK ] * Starting ftp server proftpd [ OK ] root@aa:~# /etc/init.d/proftpd status ProFTPD is started in standalone mode, currently not running. --- the next workaround helps: --- --- /etc/init.d/proftpd.orig 2013-10-30 13:52:46.791265726 +0400 +++ /etc/init.d/proftpd 2013-10-30 13:52:57.456265698 +0400 @@ -107,6 +107,7 @@ fi if [ -f "$PIDFILE" ]; then start-stop-daemon --stop --signal $SIGNAL --quiet --pidfile "$PIDFILE" + sleep 1 if [ $? = 0 ]; then log_end_msg 0 else --- Please, fix. proftpd-basic 1.3.5~rc3-2 from Ubuntu 13.10 proftpd-basic 1.3.5~rc3-2.1ubuntu2 from Ubuntu 14.04 Init script from proftpd-basic package contains the BUG: when you run /etc/init.d/proftpd restart it fails because of there is the race between pidfile removal and start() which checks pidfile existency: --- ProFTPD is started in standalone mode, currently running. root@aa:~# /etc/init.d/proftpd restart  * Stopping ftp server proftpd [ OK ]  * Starting ftp server proftpd [ OK ] root@aa:~# /etc/init.d/proftpd status ProFTPD is started in standalone mode, currently not running. --- the next workaround helps: --- --- /etc/init.d/proftpd.orig 2013-10-30 13:52:46.791265726 +0400 +++ /etc/init.d/proftpd 2013-10-30 13:52:57.456265698 +0400 @@ -107,6 +107,7 @@      fi      if [ -f "$PIDFILE" ]; then         start-stop-daemon --stop --signal $SIGNAL --quiet --pidfile "$PIDFILE" + sleep 1          if [ $? = 0 ]; then                 log_end_msg 0         else --- Please, fix.
2014-05-15 10:27:37 ciastek bug added subscriber ciastek
2014-05-26 07:56:05 webrat bug added subscriber webrat
2014-05-29 11:10:27 Benpro bug added subscriber Benpro
2014-06-09 10:31:56 Markus bug added subscriber Markus
2014-06-23 09:26:26 Markus Breitegger bug added subscriber Markus Breitegger
2014-07-14 12:28:53 Tobias Schmidt bug added subscriber Tobias Schmidt
2014-07-20 18:32:26 Michel St-Pierre bug added subscriber Michel St-Pierre
2014-07-22 16:06:45 Santiago M. Mola bug added subscriber Santiago M. Mola
2014-10-13 07:33:31 Roman Shipovskij bug added subscriber Roman Shipovskij
2014-10-13 08:25:44 Robin Kluth bug added subscriber Robin Kluth
2014-10-24 15:07:58 Joel attachment added proftp.patch https://bugs.launchpad.net/ubuntu/+source/proftpd-dfsg/+bug/1246245/+attachment/4243699/+files/proftp.patch
2014-10-24 15:08:46 Joel tags patch
2014-10-24 15:14:54 Joel attachment added proftp.patch https://bugs.launchpad.net/ubuntu/+source/proftpd-dfsg/+bug/1246245/+attachment/4243717/+files/proftp.patch
2014-10-24 16:24:52 Ubuntu Foundations Team Bug Bot bug added subscriber Ubuntu Review Team
2014-10-24 19:37:27 Joel tags patch
2014-10-27 16:14:59 Joel attachment added Patch vs trunk b63ec2128f324610404efa991456b6206095531d https://bugs.launchpad.net/ubuntu/+source/proftpd-dfsg/+bug/1246245/+attachment/4246332/+files/proftp.patch
2014-10-27 16:16:31 Joel attachment removed proftp.patch https://bugs.launchpad.net/ubuntu/+source/proftpd-dfsg/+bug/1246245/+attachment/4243699/+files/proftp.patch
2014-10-27 16:16:49 Joel attachment removed proftp.patch https://bugs.launchpad.net/ubuntu/+source/proftpd-dfsg/+bug/1246245/+attachment/4243717/+files/proftp.patch
2014-10-27 16:17:57 Joel attachment removed Patch vs trunk b63ec2128f324610404efa991456b6206095531d https://bugs.launchpad.net/ubuntu/+source/proftpd-dfsg/+bug/1246245/+attachment/4246332/+files/proftp.patch
2014-10-27 16:20:26 Joel attachment added Patch vs trunk b63ec2128f324610404efa991456b6206095531d https://bugs.launchpad.net/ubuntu/+source/proftpd-dfsg/+bug/1246245/+attachment/4246333/+files/proftp.patch
2015-01-26 06:54:03 hansluk bug added subscriber hansluk
2015-02-11 11:58:57 RedShift bug added subscriber RedShift
2015-04-08 14:13:05 mmmsssddd bug added subscriber mmmsssddd
2015-04-13 14:15:38 Eloy Paris bug added subscriber Eloy Paris
2015-04-20 07:40:32 danb1974 attachment added proftpd-1.3.5-reload-fix.diff https://bugs.launchpad.net/ubuntu/+source/proftpd-dfsg/+bug/1246245/+attachment/4379801/+files/proftpd-1.3.5-reload-fix.diff
2015-06-01 00:02:46 Christopher Chow bug added subscriber Christopher Chow
2015-08-25 07:35:45 martiner bug added subscriber martiner
2015-10-19 06:29:56 Richard Moe bug task added proftpd-dfsg
2015-10-19 06:30:44 Richard Moe bug task deleted proftpd-dfsg
2015-10-28 08:14:05 Erik van Luijk bug added subscriber Erik van Luijk
2015-12-03 11:43:21 Anton Statutov bug added subscriber Anton Statutov
2016-02-22 22:36:58 gubitna bug added subscriber gubitna
2016-05-09 13:43:06 Josip Rodin summary proftpd service failed to restart proftpd service fails to restart (including via logrotate)
2016-05-26 08:07:47 Joel removed subscriber Joel
2016-05-26 08:45:01 wolf proftpd-dfsg (Ubuntu): assignee wolf (l-wolf)
2016-05-26 08:45:43 wolf proftpd-dfsg (Ubuntu): assignee wolf (l-wolf)
2016-07-15 11:05:27 vagk attachment added with changes taken from /etc/init.d/proftpd in 16.04 https://bugs.launchpad.net/ubuntu/+source/proftpd-dfsg/+bug/1246245/+attachment/4701440/+files/proftpd.patch
2016-07-15 11:07:14 vagk bug added subscriber vagk
2016-09-29 09:09:16 Matthias Baur bug added subscriber Matthias Baur
2016-12-13 11:49:22 LucaChiampo bug added subscriber LucaChiampo
2017-02-11 21:41:03 Brian Morton proftpd-dfsg (Ubuntu): assignee Brian Morton (rokclimb15)
2017-02-13 02:18:54 Brian Morton attachment added Debdiff for trusty https://bugs.launchpad.net/ubuntu/+source/proftpd-dfsg/+bug/1246245/+attachment/4817938/+files/proftpd-dfsg_1.3.5~rc3-2.1ubuntu3.debdiff
2017-02-13 02:20:00 Brian Morton description proftpd-basic 1.3.5~rc3-2 from Ubuntu 13.10 proftpd-basic 1.3.5~rc3-2.1ubuntu2 from Ubuntu 14.04 Init script from proftpd-basic package contains the BUG: when you run /etc/init.d/proftpd restart it fails because of there is the race between pidfile removal and start() which checks pidfile existency: --- ProFTPD is started in standalone mode, currently running. root@aa:~# /etc/init.d/proftpd restart  * Stopping ftp server proftpd [ OK ]  * Starting ftp server proftpd [ OK ] root@aa:~# /etc/init.d/proftpd status ProFTPD is started in standalone mode, currently not running. --- the next workaround helps: --- --- /etc/init.d/proftpd.orig 2013-10-30 13:52:46.791265726 +0400 +++ /etc/init.d/proftpd 2013-10-30 13:52:57.456265698 +0400 @@ -107,6 +107,7 @@      fi      if [ -f "$PIDFILE" ]; then         start-stop-daemon --stop --signal $SIGNAL --quiet --pidfile "$PIDFILE" + sleep 1          if [ $? = 0 ]; then                 log_end_msg 0         else --- Please, fix. [Impact] * ProFTPd exits with signal 15 when restarted via init script. Worse yet, init script returns success. * Since logrotate runs via cron and performs a restart, this causes FTP service to stop and results in unexpected service downtime. * Final version of upstream patch at https://anonscm.debian.org/git/pkg-proftpd/proftpd-dfsg.git/commit/?id=23c5e44b3c30a082a0e15279961c3c4c3d7393fd * Only trusty and prior are affected [Test Case] * bmorton@maui:~$ sudo service proftpd restart * Stopping ftp server proftpd [ OK ] * Starting ftp server proftpd [ OK ] bmorton@maui:~$ sudo service proftpd status ProFTPD is started in standalone mode, currently not running. * After a restart, status should say "currently running" [Regression Potential] * Failure to start/stop/restart proftpd service * Patched package currently running on production host without issues [Other Info] * This is a very old bug affecting a substantial number of users * Early AM nagios notifications about FTP service are undesirable ------------------------------------------------------------------------- proftpd-basic 1.3.5~rc3-2 from Ubuntu 13.10 proftpd-basic 1.3.5~rc3-2.1ubuntu2 from Ubuntu 14.04 Init script from proftpd-basic package contains the BUG: when you run /etc/init.d/proftpd restart it fails because of there is the race between pidfile removal and start() which checks pidfile existency: --- ProFTPD is started in standalone mode, currently running. root@aa:~# /etc/init.d/proftpd restart  * Stopping ftp server proftpd [ OK ]  * Starting ftp server proftpd [ OK ] root@aa:~# /etc/init.d/proftpd status ProFTPD is started in standalone mode, currently not running. --- the next workaround helps: --- --- /etc/init.d/proftpd.orig 2013-10-30 13:52:46.791265726 +0400 +++ /etc/init.d/proftpd 2013-10-30 13:52:57.456265698 +0400 @@ -107,6 +107,7 @@      fi      if [ -f "$PIDFILE" ]; then         start-stop-daemon --stop --signal $SIGNAL --quiet --pidfile "$PIDFILE" + sleep 1          if [ $? = 0 ]; then                 log_end_msg 0         else --- Please, fix.
2017-02-13 02:20:15 Brian Morton description [Impact] * ProFTPd exits with signal 15 when restarted via init script. Worse yet, init script returns success. * Since logrotate runs via cron and performs a restart, this causes FTP service to stop and results in unexpected service downtime. * Final version of upstream patch at https://anonscm.debian.org/git/pkg-proftpd/proftpd-dfsg.git/commit/?id=23c5e44b3c30a082a0e15279961c3c4c3d7393fd * Only trusty and prior are affected [Test Case] * bmorton@maui:~$ sudo service proftpd restart * Stopping ftp server proftpd [ OK ] * Starting ftp server proftpd [ OK ] bmorton@maui:~$ sudo service proftpd status ProFTPD is started in standalone mode, currently not running. * After a restart, status should say "currently running" [Regression Potential] * Failure to start/stop/restart proftpd service * Patched package currently running on production host without issues [Other Info] * This is a very old bug affecting a substantial number of users * Early AM nagios notifications about FTP service are undesirable ------------------------------------------------------------------------- proftpd-basic 1.3.5~rc3-2 from Ubuntu 13.10 proftpd-basic 1.3.5~rc3-2.1ubuntu2 from Ubuntu 14.04 Init script from proftpd-basic package contains the BUG: when you run /etc/init.d/proftpd restart it fails because of there is the race between pidfile removal and start() which checks pidfile existency: --- ProFTPD is started in standalone mode, currently running. root@aa:~# /etc/init.d/proftpd restart  * Stopping ftp server proftpd [ OK ]  * Starting ftp server proftpd [ OK ] root@aa:~# /etc/init.d/proftpd status ProFTPD is started in standalone mode, currently not running. --- the next workaround helps: --- --- /etc/init.d/proftpd.orig 2013-10-30 13:52:46.791265726 +0400 +++ /etc/init.d/proftpd 2013-10-30 13:52:57.456265698 +0400 @@ -107,6 +107,7 @@      fi      if [ -f "$PIDFILE" ]; then         start-stop-daemon --stop --signal $SIGNAL --quiet --pidfile "$PIDFILE" + sleep 1          if [ $? = 0 ]; then                 log_end_msg 0         else --- Please, fix. SRU request for Trusty [Impact]  * ProFTPd exits with signal 15 when restarted via init script.    Worse yet, init script returns success.  * Since logrotate runs via cron and performs a restart, this causes    FTP service to stop and results in unexpected service downtime.  * Final version of upstream patch at https://anonscm.debian.org/git/pkg-proftpd/proftpd-dfsg.git/commit/?id=23c5e44b3c30a082a0e15279961c3c4c3d7393fd  * Only trusty and prior are affected [Test Case]  * bmorton@maui:~$ sudo service proftpd restart    * Stopping ftp server proftpd [ OK ]    * Starting ftp server proftpd [ OK ]    bmorton@maui:~$ sudo service proftpd status    ProFTPD is started in standalone mode, currently not running.  * After a restart, status should say "currently running" [Regression Potential]  * Failure to start/stop/restart proftpd service  * Patched package currently running on production host without issues [Other Info]  * This is a very old bug affecting a substantial number of users  * Early AM nagios notifications about FTP service are undesirable ------------------------------------------------------------------------- proftpd-basic 1.3.5~rc3-2 from Ubuntu 13.10 proftpd-basic 1.3.5~rc3-2.1ubuntu2 from Ubuntu 14.04 Init script from proftpd-basic package contains the BUG: when you run /etc/init.d/proftpd restart it fails because of there is the race between pidfile removal and start() which checks pidfile existency: --- ProFTPD is started in standalone mode, currently running. root@aa:~# /etc/init.d/proftpd restart  * Stopping ftp server proftpd [ OK ]  * Starting ftp server proftpd [ OK ] root@aa:~# /etc/init.d/proftpd status ProFTPD is started in standalone mode, currently not running. --- the next workaround helps: --- --- /etc/init.d/proftpd.orig 2013-10-30 13:52:46.791265726 +0400 +++ /etc/init.d/proftpd 2013-10-30 13:52:57.456265698 +0400 @@ -107,6 +107,7 @@      fi      if [ -f "$PIDFILE" ]; then         start-stop-daemon --stop --signal $SIGNAL --quiet --pidfile "$PIDFILE" + sleep 1          if [ $? = 0 ]; then                 log_end_msg 0         else --- Please, fix.
2017-02-13 09:10:26 Robie Basak nominated for series Ubuntu Trusty
2017-02-13 09:10:26 Robie Basak bug task added proftpd-dfsg (Ubuntu Trusty)
2017-02-13 13:40:39 Brian Morton attachment added Debdiff for trusty with corrected changelog https://bugs.launchpad.net/ubuntu/+source/proftpd-dfsg/+bug/1246245/+attachment/4818195/+files/proftpd-dfsg_1.3.5~rc3-2.1ubuntu3.debdiff
2017-02-13 13:40:50 Brian Morton attachment removed Debdiff for trusty https://bugs.launchpad.net/ubuntu/+source/proftpd-dfsg/+bug/1246245/+attachment/4817938/+files/proftpd-dfsg_1.3.5~rc3-2.1ubuntu3.debdiff
2017-02-13 13:41:26 Brian Morton bug added subscriber Ubuntu Sponsors Team
2017-02-14 04:44:01 Mathew Hodson proftpd-dfsg (Ubuntu): importance Undecided Medium
2017-02-14 04:44:03 Mathew Hodson proftpd-dfsg (Ubuntu Trusty): importance Undecided Medium
2017-02-14 04:47:00 Mathew Hodson tags patch
2017-02-15 23:06:24 Brian Murray bug watch added http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=594449
2017-02-15 23:06:24 Brian Murray bug task added proftpd-dfsg (Debian)
2017-02-15 23:06:43 Brian Murray proftpd-dfsg (Ubuntu Trusty): status New Triaged
2017-02-15 23:15:13 Brian Murray proftpd-dfsg (Ubuntu): status Confirmed Fix Released
2017-02-15 23:15:19 Brian Murray removed subscriber Ubuntu Sponsors Team
2017-02-16 00:26:24 Bug Watch Updater proftpd-dfsg (Debian): status Unknown Fix Released
2017-02-17 19:13:28 Brian Murray proftpd-dfsg (Ubuntu Trusty): status Triaged Fix Committed
2017-02-17 19:13:33 Brian Murray bug added subscriber Ubuntu Stable Release Updates Team
2017-02-17 19:13:39 Brian Murray bug added subscriber SRU Verification
2017-02-17 19:13:57 Brian Murray tags patch patch verification-needed
2017-02-28 03:51:25 Brian Morton tags patch verification-needed patch verification-done
2017-02-28 19:22:32 Launchpad Janitor proftpd-dfsg (Ubuntu Trusty): status Fix Committed Fix Released
2017-02-28 19:22:40 Brian Murray removed subscriber Ubuntu Stable Release Updates Team