| 2023-09-11 07:29:40 |
Robert Malz |
bug |
|
|
added bug |
| 2023-09-11 07:37:02 |
Robert Malz |
procps (Ubuntu): assignee |
|
Robert Malz (rmalz) |
|
| 2023-09-11 07:41:09 |
Robert Malz |
nominated for series |
|
Ubuntu Focal |
|
| 2023-09-11 07:41:09 |
Robert Malz |
bug task added |
|
procps (Ubuntu Focal) |
|
| 2023-09-11 07:41:09 |
Robert Malz |
nominated for series |
|
Ubuntu Jammy |
|
| 2023-09-11 07:41:09 |
Robert Malz |
bug task added |
|
procps (Ubuntu Jammy) |
|
| 2023-09-11 07:41:15 |
Robert Malz |
procps (Ubuntu Focal): assignee |
|
Robert Malz (rmalz) |
|
| 2023-09-11 07:41:17 |
Robert Malz |
procps (Ubuntu Jammy): assignee |
|
Robert Malz (rmalz) |
|
| 2023-09-11 07:41:23 |
Robert Malz |
procps (Ubuntu): importance |
Undecided |
Low |
|
| 2023-09-11 07:41:25 |
Robert Malz |
procps (Ubuntu Focal): importance |
Undecided |
Low |
|
| 2023-09-11 07:41:31 |
Robert Malz |
procps (Ubuntu Jammy): importance |
Undecided |
Low |
|
| 2023-09-11 08:26:47 |
Robert Malz |
attachment added |
|
uptime_jammy.debdiff https://bugs.launchpad.net/ubuntu/+source/procps/+bug/2035061/+attachment/5699852/+files/uptime_jammy.debdiff |
|
| 2023-09-11 08:27:17 |
Robert Malz |
attachment added |
|
uptime_focal.debdiff https://bugs.launchpad.net/ubuntu/+source/procps/+bug/2035061/+attachment/5699853/+files/uptime_focal.debdiff |
|
| 2023-09-11 08:29:57 |
Robert Malz |
bug |
|
|
added subscriber Support Engineering Sponsors |
| 2023-09-11 08:30:21 |
Dariusz Gadomski |
bug |
|
|
added subscriber Dariusz Gadomski |
| 2023-09-11 10:43:08 |
Dariusz Gadomski |
tags |
|
se se-sponsor-dgadomski |
|
| 2023-09-11 12:16:23 |
Ubuntu Foundations Team Bug Bot |
tags |
se se-sponsor-dgadomski |
patch se se-sponsor-dgadomski |
|
| 2023-09-11 12:16:28 |
Ubuntu Foundations Team Bug Bot |
bug |
|
|
added subscriber Ubuntu Sponsors |
| 2023-09-12 14:20:12 |
Robert Malz |
description |
[IMPACT]
uptime will provide incorrect data after 52 weeks. This is at least confusing for users utilizing this tool.
Issue is already fixed in upstream https://gitlab.com/procps-ng/procps/-/commit/8827c6763f79f77a126968e200b0e402de7cb749.
Latest procps releases already include this patch (procps 4.0.3 lunar/mantic)
The fix is needed for following set of packages:
procps | 2:3.3.17-6ubuntu2 | jammy
procps | 2:3.3.16-1ubuntu2 | focal
[TEST CASE]
UPTIME="31528920 31528800"; mkfifo uptime_fifo; while true; do cat <<<$UPTIME > uptime_fifo; done & sudo mount -obind uptime_fifo /proc/uptime
uptime -p
Running above commands will result in incorrect uptime output.
[REGRESSION POTENTIAL]
The patch is already available in upstream, lunar/mantic releases already include is as well.
[OTHER]
Bug upstream: https://gitlab.com/procps-ng/procps/-/issues/217
Following patch is needed for older releases: https://gitlab.com/procps-ng/procps/-/commit/8827c6763f79f77a126968e200b0e402de7cb749 |
[IMPACT]
uptime will provide incorrect data after 52 weeks. This is at least confusing for users utilizing this tool.
Issue is already fixed in upstream https://gitlab.com/procps-ng/procps/-/commit/8827c6763f79f77a126968e200b0e402de7cb749.
Latest procps releases already include this patch (procps 4.0.3 lunar/mantic)
The fix is needed for following set of packages:
procps | 2:3.3.17-6ubuntu2 | jammy
procps | 2:3.3.16-1ubuntu2 | focal
[TEST CASE]
UPTIME="31528920 31528800"; mkfifo uptime_fifo; while true; do cat <<<$UPTIME > uptime_fifo; done & sudo mount -obind uptime_fifo /proc/uptime
uptime -p
Running above commands will result in incorrect uptime output.
[REGRESSION POTENTIAL]
The patch is already available in upstream, lunar/mantic releases already include is as well.
Old behavior will inaccurately print uptime -p for 24h after 31449600 seconds (0 years, 0 weeks).
With new patch during that time uptime -p will print "52 weeks".
[OTHER]
Bug upstream: https://gitlab.com/procps-ng/procps/-/issues/217
Following patch is needed for older releases: https://gitlab.com/procps-ng/procps/-/commit/8827c6763f79f77a126968e200b0e402de7cb749 |
|
| 2023-09-14 15:18:47 |
Robert Malz |
attachment added |
|
uptime_test_results https://bugs.launchpad.net/ubuntu/+source/procps/+bug/2035061/+attachment/5700926/+files/uptime_test_results |
|
| 2023-09-15 09:57:31 |
Robert Malz |
description |
[IMPACT]
uptime will provide incorrect data after 52 weeks. This is at least confusing for users utilizing this tool.
Issue is already fixed in upstream https://gitlab.com/procps-ng/procps/-/commit/8827c6763f79f77a126968e200b0e402de7cb749.
Latest procps releases already include this patch (procps 4.0.3 lunar/mantic)
The fix is needed for following set of packages:
procps | 2:3.3.17-6ubuntu2 | jammy
procps | 2:3.3.16-1ubuntu2 | focal
[TEST CASE]
UPTIME="31528920 31528800"; mkfifo uptime_fifo; while true; do cat <<<$UPTIME > uptime_fifo; done & sudo mount -obind uptime_fifo /proc/uptime
uptime -p
Running above commands will result in incorrect uptime output.
[REGRESSION POTENTIAL]
The patch is already available in upstream, lunar/mantic releases already include is as well.
Old behavior will inaccurately print uptime -p for 24h after 31449600 seconds (0 years, 0 weeks).
With new patch during that time uptime -p will print "52 weeks".
[OTHER]
Bug upstream: https://gitlab.com/procps-ng/procps/-/issues/217
Following patch is needed for older releases: https://gitlab.com/procps-ng/procps/-/commit/8827c6763f79f77a126968e200b0e402de7cb749 |
[ Impact ]
uptime -p will provide incorrect data for 24 hours after exactly 52 weeks. Users and tools utilizing this command will receive example output "up 2 hours" instead of "up 52 weeks, 2 hours". After 24 hours since 52 weeks, uptime -p will report "up 1 year" which is correct output.
Issue is already fixed in upstream https://gitlab.com/procps-ng/procps/-/commit/0496b39876d569fe1cecb76ad5ef212cd14c0374.
Latest procps releases already include this patch (procps 4.0.3 lunar/mantic)
The fix is needed for following set of packages:
procps | 2:3.3.17-6ubuntu2 | jammy
procps | 2:3.3.16-1ubuntu2 | focal
[ Test Plan ]
Reproduction:
UPTIME="31528920 31528800"; mkfifo uptime_fifo; while true; do cat <<<$UPTIME > uptime_fifo; done & sudo mount -obind uptime_fifo /proc/uptime
uptime -p
Running above commands will result in incorrect uptime output.
Testing:
In attached uptime_test_results file there is modified print_uptime function which has been used to test multiple corner cases.
[ Where problems could occur ]
Proposed changes modifies output format of "uptime -p". Issue has been already fixed in latest version of procps package available in lunar/mantic however older releases are based on different code base and patch cannot be directly cherry-picked. Due to backport requirements some code of "uptime" (without -p) has been also changed but this should not impact logic for that usage.
As the change focuses on modifying "uptime -p" output format any potential issues will impact this command.
I have also looked for a reverse dependencies on procps package to check for potential uses of uptime -p, however I was not able to find any. Internally within procps package this functionality is used in "top" application, however for that case "uptime" (without -p) is used.
[ Other Info ]
Bug upstream: https://gitlab.com/procps-ng/procps/-/issues/217
Following patch is needed for older releases: https://gitlab.com/procps-ng/procps/-/commit/0496b39876d569fe1cecb76ad5ef212cd14c0374
Old commit on which upstream patch is based: https://gitlab.com/procps-ng/procps/-/commit/8827c6763f79f77a126968e200b0e402de7cb749
Small change on top of proposed patch (already included in debdiff): https://gitlab.com/procps-ng/procps/-/commit/10824b0655f3eeaeac87ae6e4e3881429a237f3e |
|
| 2023-09-15 09:57:56 |
Robert Malz |
attachment removed |
uptime_jammy.debdiff https://bugs.launchpad.net/ubuntu/+source/procps/+bug/2035061/+attachment/5699852/+files/uptime_jammy.debdiff |
|
|
| 2023-09-15 09:58:06 |
Robert Malz |
attachment removed |
uptime_focal.debdiff https://bugs.launchpad.net/ubuntu/+source/procps/+bug/2035061/+attachment/5699853/+files/uptime_focal.debdiff |
|
|
| 2023-09-15 09:58:51 |
Robert Malz |
attachment added |
|
jammy debdiff https://bugs.launchpad.net/ubuntu/+source/procps/+bug/2035061/+attachment/5701218/+files/uptime_jammy.debdiff |
|
| 2023-09-15 09:59:31 |
Robert Malz |
attachment added |
|
focal debdiff https://bugs.launchpad.net/ubuntu/+source/procps/+bug/2035061/+attachment/5701220/+files/uptime_focal.debdiff |
|
| 2023-09-18 18:21:25 |
Steve Langasek |
procps (Ubuntu): status |
New |
Fix Released |
|
| 2023-09-18 19:22:45 |
Robie Basak |
procps (Ubuntu Focal): status |
New |
Won't Fix |
|
| 2023-09-18 19:22:47 |
Robie Basak |
procps (Ubuntu Jammy): status |
New |
Won't Fix |
|
| 2023-09-18 19:22:49 |
Robie Basak |
bug |
|
|
added subscriber Robie Basak |
| 2023-09-18 19:23:42 |
Robie Basak |
removed subscriber Ubuntu Sponsors |
|
|
|
