ppscsi won't build with module-assistant under kernel 2.6.17-10-generic (or newer)

Bug #69023 reported by Scott Testerman
18
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ppscsi (Debian)
Fix Released
Unknown
ppscsi (Ubuntu)
Undecided
Eduard Bloch

Bug Description

The build log:

dh_clean
rm -f *.o *.ko
/usr/bin/make -f debian/rules kdist_clean kdist_config binary-modules
make[1]: Entering directory `/usr/src/modules/ppscsi'
dh_clean
rm -f *.o *.ko
/usr/bin/gcc-4.1
for templ in /usr/src/modules/ppscsi/debian/ppscsi-drivers-_KVERS_.postinst /usr/src/modules/ppscsi/debian/ppscsi-drivers-_KVERS_.postinst.modules.in; do \
    cp $templ `echo $templ | sed -e 's/_KVERS_/2.6.17-10-generic/g'` ; \
  done
for templ in `ls debian/*.modules.in` ; do \
    test -e ${templ%.modules.in}.backup || cp ${templ%.modules.in} ${templ%.modules.in}.backup 2>/dev/null || true; \
    sed -e 's/##KVERS##/2.6.17-10-generic/g ;s/#KVERS#/2.6.17-10-generic/g ; s/_KVERS_/2.6.17-10-generic/g ; s/##KDREV##/2.6.17-10.33/g ; s/#KDREV#/2.6.17-10.33/g ; s/_KDREV_/2.6.17-10.33/g ' < $templ > ${templ%.modules.in}; \
  done
dh_testdir
dh_testroot
dh_clean -k
dh_installdirs -pppscsi-drivers-2.6.17-10-generic lib/modules/2.6.17-10-generic/ppscsi
make KERNEL_DIR=/lib/modules/2.6.17-10-generic/build
make[2]: Entering directory `/usr/src/modules/ppscsi'
make modules -C /lib/modules/2.6.17-10-generic/build SUBDIRS=/usr/src/modules/ppscsi
make[3]: Entering directory `/usr/src/linux-headers-2.6.17-10-generic'
  CC [M] /usr/src/modules/ppscsi/ppscsi.o
  CC [M] /usr/src/modules/ppscsi/onscsi.o
In file included from /usr/src/modules/ppscsi/onscsi.c:13:
/usr/src/modules/ppscsi/ppscsi.h:325: error: expected ‘)’ before string constant
/usr/src/modules/ppscsi/ppscsi.h:326: error: expected ‘)’ before string constant
/usr/src/modules/ppscsi/ppscsi.h:327: error: expected ‘)’ before string constant
/usr/src/modules/ppscsi/ppscsi.h:328: error: expected ‘)’ before string constant
/usr/src/modules/ppscsi/ppscsi.h:329: error: expected ‘)’ before string constant
make[4]: *** [/usr/src/modules/ppscsi/onscsi.o] Error 1
make[3]: *** [_module_/usr/src/modules/ppscsi] Error 2
make[3]: Leaving directory `/usr/src/linux-headers-2.6.17-10-generic'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/usr/src/modules/ppscsi'
make[1]: *** [binary-modules] Error 2
make[1]: Leaving directory `/usr/src/modules/ppscsi'
make: *** [kdist_build] Error 2

_______________

Also, a newer version "beta 2" is available at
http://penguin-breeder.org/kernel/download/ppscsi-beta2-20060424.tar.gz

Revision history for this message
ybkosher (bobby-weinmann) wrote :

See solution below

Changed in ppscsi:
assignee: nobody → blade
status: Unconfirmed → Confirmed
Revision history for this message
ybkosher (bobby-weinmann) wrote :

Solution is to change lines 325-329 from:
MODULE_PARM(host0,"1-8i");
MODULE_PARM(host1,"1-8i");
MODULE_PARM(host2,"1-8i");
MODULE_PARM(host3,"1-8i");
MODULE_PARM(verbose,"i");

to:
module_param_array(host0, int, NULL, 0);
module_param_array(host1, int, NULL, 0);
module_param_array(host2, int, NULL, 0);
module_param_array(host3, int, NULL, 0);
module_param(verbose, int, 0);

Unfortunately, I can only scan in Lineart right now.

Bobby

Changed in ppscsi:
status: Unknown → Unconfirmed
Revision history for this message
JAdshead (jads) wrote :

Hi,
This bug is still outstanding after a whole year..
The ppscsi modules failed to compile and were unusable on 'edgy' and then 'feisty'
and now the upcoming 'gutsy' too.
There are more errors under 'feisty' and 'gusty' due to further kernel internal api changes
in 2.6.20.
I have made a patch to fix this for these recent kernels and am trying to contact
the upstream source maintainer to get this incorporated.
The patch allows me to correctly use my HP Scanjet 5100c scanner.

- What needs to be done to get this fixed before the 'gutsy' release?

- Isn't there some kind of 'automated build tester' for the 'module-assistant' package
  such that if any of the source packages it controls fails to build then the whole
  package is flagged as needing attention?
  (just seems like a basic quality control issue to be continuously shipping packages
  that fail to build)

Jon

Revision history for this message
ybkosher (bobby-weinmann) wrote :

I followed the instructions shown in many places including:

http://ubuntuforums.org/archive/index.php/t-455500.html

I merged it with the ppscsi-source code, so it has the debian directory and archived it. All you have to do is replace the ppscsi-source package with this tarball and voila. Hopefully it can get into the repository soon.

NOTE: This is not a patch, it is a tarball of all the code. I also did not change the version (it is 0.92, like the penguin-breeder.org tarball) nor did I update the changelog.

I still have a problem scanning, but it doesn't seem to be driver related.

BTW, Jon - if you have something else/better please attach it to this bug so everyone can use it, even if Ubuntu/Debian don't put it in the official package.

Bobby

Revision history for this message
khm (kfx) wrote :

This bug still exists in Gutsy and Hardy, and now that the scsi subsystem has been reorganized the linked instructions do not work.

The bug is now a year and a half old; please either fix it or mark it wontfix.

Revision history for this message
showgun (showgun) wrote :

I am a newbie so not 100% sure it is the same problem.

I have HP6100C connected to a PCI SCSI card Adaptec AHA2940U it was working fine if Feisty, Gutsy but since I have upgraded to Hardy the screen that use to come up at the beginning to load the SCSI does not.

When I type any of the following command line
lsscsi lspci lshw
I can not see anything about the above Hardware It is like the scsi module does not exist?

If this is the same problem in my case it only stopped working since my upgrade to Hardy, I sure hope some one is working on this since this is retrograding...
Thanks

Revision history for this message
ybkosher (bobby-weinmann) wrote : Re: [Bug 69023] Re: ppscsi won't build with module-assistant under kernel 2.6.17-10-generic (or newer)

showgun - yours is a regular scsi scanner. This is a bug for parallel
port scanners.

Revision history for this message
showgun (showgun) wrote :

Ok but the problem is not the scanner but the SCSI CARD not being detected...
But I will see if I can find anything in the parralele

Revision history for this message
Jaska Kivelä (jaska) wrote :

Here's a solution that compiles (and scans with a HP 5100C) on Ubuntu 8.04 LTS (linux 2.6-24):

http://www.kivela.net/jaska/projects/ubuntu-ppscsi/

I'll attach a diff for ppscsi-beta2-20060424.

Changed in ppscsi:
status: New → Fix Released
Revision history for this message
Scott Testerman (scott-testerman) wrote :

This package has been removed and is no longer available in Ubuntu. It has also been removed from upstream: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=383738#45 .

Although still applicable to 8.04, newer releases don't have this package available, so I suggest closing the bug.

Revision history for this message
internetter (internetter) wrote :

8.04 is an LTS release. This package is only two years into a five-year support cycle. Has the LTS policy been abandoned?

Revision history for this message
Scott Testerman (scott-testerman) wrote :

Per the ppSCSI page at http://cyberelk.net/tim/parport/ppscsi.html the project is no longer maintained, and Ubuntu 8.04LTS reached EOL on May 9, 2013.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.