systemd 234-2ubuntu9 ADT test failure with linux 4.13.0-9.10

[Seth Forshee]

Testing failed on:
    ppc64el: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-artful-canonical-kernel-team-unstable/artful/ppc64el/s/systemd/20170906_131209_2a96a@/log.gz

[Seth Forshee (sforshee)]

ep 06 12:23:41 6963eeea-263f-4ad0-8fdf-549bd646f5dc-adt-prepare systemd[1]: Starting ppc64-diag rtas_errd (platform error handling) Service...
Sep 06 12:23:41 6963eeea-263f-4ad0-8fdf-549bd646f5dc-adt-prepare systemd[1]: Started ppc64-diag rtas_errd (platform error handling) Service.
Sep 06 12:23:42 6963eeea-263f-4ad0-8fdf-549bd646f5dc-adt-prepare systemd[1]: rtas_errd.service: Service hold-off time over, scheduling restart.
Sep 06 12:23:42 6963eeea-263f-4ad0-8fdf-549bd646f5dc-adt-prepare systemd[1]: Stopped ppc64-diag rtas_errd (platform error handling) Service.
Sep 06 12:23:42 6963eeea-263f-4ad0-8fdf-549bd646f5dc-adt-prepare systemd[1]: Starting ppc64-diag rtas_errd (platform error handling) Service...
Sep 06 12:23:42 6963eeea-263f-4ad0-8fdf-549bd646f5dc-adt-prepare systemd[1]: Started ppc64-diag rtas_errd (platform error handling) Service.
Sep 06 12:23:42 6963eeea-263f-4ad0-8fdf-549bd646f5dc-adt-prepare systemd[1]: rtas_errd.service: Service hold-off time over, scheduling restart.
Sep 06 12:23:42 6963eeea-263f-4ad0-8fdf-549bd646f5dc-adt-prepare systemd[1]: Stopped ppc64-diag rtas_errd (platform error handling) Service.
Sep 06 12:23:42 6963eeea-263f-4ad0-8fdf-549bd646f5dc-adt-prepare systemd[1]: Starting ppc64-diag rtas_errd (platform error handling) Service...
Sep 06 12:23:42 6963eeea-263f-4ad0-8fdf-549bd646f5dc-adt-prepare systemd[1]: Started ppc64-diag rtas_errd (platform error handling) Service.
Sep 06 12:23:42 6963eeea-263f-4ad0-8fdf-549bd646f5dc-adt-prepare systemd[1]: rtas_errd.service: Service hold-off time over, scheduling restart.
Sep 06 12:23:42 6963eeea-263f-4ad0-8fdf-549bd646f5dc-adt-prepare systemd[1]: Stopped ppc64-diag rtas_errd (platform error handling) Service.
Sep 06 12:23:42 6963eeea-263f-4ad0-8fdf-549bd646f5dc-adt-prepare systemd[1]: Starting ppc64-diag rtas_errd (platform error handling) Service...
Sep 06 12:23:42 6963eeea-263f-4ad0-8fdf-549bd646f5dc-adt-prepare systemd[1]: Started ppc64-diag rtas_errd (platform error handling) Service.
Sep 06 12:23:42 6963eeea-263f-4ad0-8fdf-549bd646f5dc-adt-prepare systemd[1]: rtas_errd.service: Service hold-off time over, scheduling restart.
Sep 06 12:23:42 6963eeea-263f-4ad0-8fdf-549bd646f5dc-adt-prepare systemd[1]: Stopped ppc64-diag rtas_errd (platform error handling) Service.
Sep 06 12:23:42 6963eeea-263f-4ad0-8fdf-549bd646f5dc-adt-prepare systemd[1]: Starting ppc64-diag rtas_errd (platform error handling) Service...
Sep 06 12:23:42 6963eeea-263f-4ad0-8fdf-549bd646f5dc-adt-prepare systemd[1]: Started ppc64-diag rtas_errd (platform error handling) Service.
Sep 06 12:23:42 6963eeea-263f-4ad0-8fdf-549bd646f5dc-adt-prepare systemd[1]: rtas_errd.service: Service hold-off time over, scheduling restart.
Sep 06 12:23:42 6963eeea-263f-4ad0-8fdf-549bd646f5dc-adt-prepare systemd[1]: Stopped ppc64-diag rtas_errd (platform error handling) Service.
Sep 06 12:23:42 6963eeea-263f-4ad0-8fdf-549bd646f5dc-adt-prepare systemd[1]: rtas_errd.service: Start request repeated too quickly.
Sep 06 12:23:42 6963eeea-263f-4ad0-8fdf-549bd646f5dc-adt-prepare systemd[1]: Failed to start ppc64-diag rtas_errd (platform error handling) Service.
Sep 06 12:23:42 6963eeea-263f-4ad0-8fdf-549bd646f5dc-adt-prepare syste...

[Seth Forshee (sforshee)]

I see adt failures with 4.12 as well, looks like a regression in ppc64-diag. Changing affected package.

[Manoj Iyer (manjo)]

Barry,

The kernel team discovered a potential regression in ppc64-diag
package. You can find the details in the bug report:
https://launchpad.net/bugs/1715397

Could you please mirror this bug internally and assign it to the
appropriate person at IBM to fix this issue? The upstream maintainer
for this package is https://launchpad.net/~frediz (Frédéric Bonnard).

Thanks
Manoj Iyer

[Manoj Iyer (manjo)]

Kernel team, IBM is working on a fix with top priority. Please stay tuned for a fix from Fred.

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2017-09-08 06:59 EDT-------
(In reply to comment #6)
> Kernel team, IBM is working on a fix with top priority. Please stay tuned
> for a fix from Fred.

Very bad :-( accidently I added "=|!" instead of "=|" in upstream which is causing below warnings in syslog.

This is just a warning comes on PowerNV host and safe to ignore.

Below patch should fix this issue . Can you please verify ?

diff --git a/scripts/rtas_errd.service b/scripts/rtas_errd.service
index 5507b8a..8475c3e 100644
--- a/scripts/rtas_errd.service
+++ b/scripts/rtas_errd.service
@@ -1,7 +1,7 @@
[Unit]
Description=ppc64-diag rtas_errd (platform error handling) Service
-ConditionPathExists=|!/proc/ppc64/rtas/error_log
-ConditionPathExists=|!/proc/ppc64/error_log
+ConditionPathExists=|/proc/ppc64/rtas/error_log
+ConditionPathExists=|/proc/ppc64/error_log
After=syslog.target

[Service]

-Vasant

[Frédéric Bonnard (frediz)]

Thanks Vasant for double checking the fix.
The patch is in ppc64-diag 2.7.4-2 in Unstable.

F.

[Steve Langasek (vorlon)]

This bug was fixed in the package ppc64-diag - 2.7.4-2

---------------
ppc64-diag (2.7.4-2) unstable; urgency=medium

  * d/patches/fix-rtas_errd-unit.patch : fix rtas_errd being started where it
    should not and being reported by systemd as failing whereas the daemon
    exits as it should (LP: #1715397)

 -- Frédéric Bonnard <email address hidden> Fri, 08 Sep 2017 11:08:42 +0000

[Brian Murray (brian-murray)]

Hello Seth, or anyone else affected,

Accepted ppc64-diag into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ppc64-diag/2.7.4-2~16.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Brian Murray (brian-murray)]

Hello Seth, or anyone else affected,

Accepted ppc64-diag into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ppc64-diag/2.7.4-2~14.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-trusty to verification-done-trusty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-trusty. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Dimitri John Ledkov (xnox)]

Everything is green now \o/ *ship it*

[Launchpad Janitor (janitor)]

This bug was fixed in the package ppc64-diag - 2.7.4-2~16.04

---------------
ppc64-diag (2.7.4-2~16.04) xenial; urgency=medium

  * SRU: LP: #1708494. Update to the version found in 17.10.

ppc64-diag (2.7.4-2) unstable; urgency=medium

  * d/patches/fix-rtas_errd-unit.patch : fix rtas_errd being started where it
    should not and being reported by systemd as failing whereas the daemon
    exits as it should (LP: #1715397)

 -- Dimitri John Ledkov <email address hidden> Tue, 28 Nov 2017 16:59:36 +0000

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for ppc64-diag has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ppc64-diag - 2.7.4-2~14.04

---------------
ppc64-diag (2.7.4-2~14.04) trusty; urgency=medium

  * SRU: LP: #1708494. Update to the version found in 17.10.

ppc64-diag (2.7.4-2) unstable; urgency=medium

  * d/patches/fix-rtas_errd-unit.patch : fix rtas_errd being started where it
    should not and being reported by systemd as failing whereas the daemon
    exits as it should (LP: #1715397)

 -- Dimitri John Ledkov <email address hidden> Tue, 28 Nov 2017 16:59:36 +0000