[SRU] Include powerpc port upstream fixes to librpmem 1.10 on pmdk package
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
The Ubuntu-power-systems project |
Fix Released
|
Medium
|
Ubuntu on IBM Power Systems Bug Triage | ||
pmdk (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Hirsute |
Fix Released
|
Undecided
|
Paride Legovini | ||
Impish |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
On ppc64el the librpmem checks for RPMEM_RAW_BUFF_SIZE and LANE_ALIGN_SIZE are broken because they're not using the reference values for the target architecture.
[Test Plan]
(Adapted from comment #13.)
The upstream source tree contains a test suite that can be used for the verification.
1. Unpack the source package.
2. Configure src/test/
- To do that copy the testconfig.
Fill it with the configurations for your system.
- Be sure to set the variable PMDK_LIB_
librpmem.so as installed by the package to test.
- As you are not on a DAX device use PMEM_FS_
- As this will be a librpmem test we need to configure the node
variables. Also ssh keys must be configured to access the nodes
without password.
3. Inside the src/test/ directory run "./RUNTESTS -b nondebug rpmem_fip".
Here is an example of testconfig.sh:
PMEM_FS_
NON_PMEM_
PMEM_FS_
RDMAV_FORK_SAFE=1
PMDK_LIB_
TEST_BUILD=
TEST_TIMEOUT=6m
TM=1
KEEP_GOING=y
CLEAN_FAILED=y
UNITTEST_
UNITTEST_
NODE[0]=127.0.0.1
NODE[1]=127.0.0.1
NODE[2]=127.0.0.1
NODE[3]=127.0.0.1
NODE_ADDR[
NODE_ADDR[
NODE_ADDR[
NODE_ADDR[
NODE_WORKING_
NODE_WORKING_
NODE_WORKING_
NODE_WORKING_
NODE_ENV[
NODE_ENV[
NODE_ENV[
NODE_ENV[
TEST_PROVIDERS=
[Where problems could occur]
On architectures where this was "not a bug" nothing changes, there is just one more indirection in some #defines, but the same values as before will be set. On affected arch (ppc64el) I don't see a possible case of "users relying on the bug". The scope of the fix is limited.
[Development Fix]
Already fixed in 1.11.0-1 (new upstream release, sync from Debian experimental).
[Original Description]
== Comment: #0 - Lucas Alexandre Mello Magalhaes <email address hidden> - 2021-06-04 14:06:47 ==
On PPC64LE there is an issue on librpmem check for RPMEM_RAW_
fixed upstream already. Please include the follow commits to include the fix.
652659830 rpmem: Fix RPMEM_RAW_BUFF_SIZE and LANE_ALIGN_SIZE for powerpc64le
e672c09d9 common: Move page_size.h from common to core
The following patches are fixes to the unity test. Please include them if you need for testing.
bc048c7e4 test: Fix obj_rpmem_
736e42b1d test: Fix pmempool_
2e1a6a1da test: fix rpmem_basic for ppc64le
74e3ca419 test: Add create_
ffeb20d6c test: Fix rpmemd_obc POOL_DESC_SIZE redefinition
aa7aae2b4 test: Fix tools/fip includes
Related branches
- Christian Ehrhardt (community): Approve
- Canonical Server: Pending requested
-
Diff: 1246 lines (+1226/-0)3 files modifieddebian/changelog (+7/-0)
debian/patches/lp1931063-rpmem-Fix-RPMEM_RAW_BUFF_SIZE-and-LANE_ALIGN_SIZE.patch (+1218/-0)
debian/patches/series (+1/-0)
tags: | added: architecture-ppc64le bugnameltc-193088 severity-medium targetmilestone-inin--- |
Changed in ubuntu: | |
assignee: | nobody → Ubuntu on IBM Power Systems Bug Triage (ubuntu-power-triage) |
affects: | ubuntu → kernel-package (Ubuntu) |
Changed in ubuntu-power-systems: | |
status: | New → Triaged |
tags: | added: server-next |
Changed in pmdk (Ubuntu Hirsute): | |
assignee: | nobody → Paride Legovini (paride) |
Changed in ubuntu-power-systems: | |
status: | Triaged → In Progress |
Changed in pmdk (Ubuntu Hirsute): | |
status: | New → In Progress |
summary: |
- Include powerpc port upstream fixes to librpmem 1.10 on pmdk package + [SRU] Include powerpc port upstream fixes to librpmem 1.10 on pmdk + package |
description: | updated |
description: | updated |
description: | updated |
Changed in ubuntu-power-systems: | |
status: | In Progress → Fix Committed |
Changed in ubuntu-power-systems: | |
status: | Fix Committed → Fix Released |
I think this affects pmdk (rather the Linux kernel).