/usr/lib/pm-utils/sleep.d/55NetworkManager calls the wrong method

Bug #888434 reported by István Váradi
64
This bug affects 10 people
Affects Status Importance Assigned to Milestone
pm-utils (Ubuntu)
Confirmed
Undecided
Unassigned

Bug Description

As of 11.10, 55NetworkManager calls the already non-existing "sleep" and "wake" methods on org.freedesktop.NetworkManager. It should call instead the "Sleep" (note the capital 'S') method with a boolean argument:

dbus_send ... ... org.freedesktop.NetworkManager.Sleep boolean:true

for suspending, and false for resuming.

Attached the fixed file.

ProblemType: Bug
DistroRelease: Ubuntu 11.10
Package: pm-utils 1.4.1-8ubuntu1 [modified: usr/lib/pm-utils/sleep.d/55NetworkManager]
ProcVersionSignature: Ubuntu 3.0.0-12.20~ppa1-generic-tuxonice 3.0.4
Uname: Linux 3.0.0-12-generic-tuxonice x86_64
ApportVersion: 1.23-0ubuntu3
Architecture: amd64
Date: Thu Nov 10 08:32:17 2011
InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Release amd64 (20110426)
PackageArchitecture: all
ProcEnviron:
 LANGUAGE=en_US:en
 PATH=(custom, no user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: pm-utils
UpgradeStatus: Upgraded to oneiric on 2011-10-30 (11 days ago)

Revision history for this message
István Váradi (ivaradi) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in pm-utils (Ubuntu):
status: New → Confirmed
Revision history for this message
Sidnei da Silva (sidnei) wrote :

Moreover, it's calling 'dbus_send' instead of 'dbus-send'.

Revision history for this message
Sidnei da Silva (sidnei) wrote :

Argh. And '--type=method_call' is missing too!

Revision history for this message
Nicolas Cavallari (batchman) wrote :

i just stumbled across this bug after filling a duplicate bug (#906347).

Calling dbus_send is perfectly correct, it is defined in $PM_FUNCTIONS as a wrapper to dbus-send.

Revision history for this message
Oliver R. (oliverr) wrote :

The bug seems to be still present in version 1.4.1-9fix.ubuntu12.04

Is anyone able to fix this? Is it fixed in future versions?

Revision history for this message
Oliver R. (oliverr) wrote :

I attached a modified version of 55NetworkManager that simply calls "stop network-manager" and "start network-manager", respectively. This works for me, i.e. I have a working network connection after resume, which I hadn't before (Mint 13 Xfce, kernel 3.13.0-43-generic, ThinkPad R500).

Please comment if this is a sensible solution – or post a correct version using dbus_send.

Revision history for this message
Nicolas Cavallari (batchman) wrote :

This is not a sensible solution.

There are numerous patches already to fix the original problem:

On launchpad:
https://bugs.launchpad.net/ubuntu/+source/pm-utils/+bug/906347 (mine).
https://bugs.launchpad.net/ubuntu/+source/pm-utils/+bug/1007924
On debian:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=647418
Upstream:
https://bugs.freedesktop.org/show_bug.cgi?id=30701
https://bugs.freedesktop.org/show_bug.cgi?id=42500

There are also some random sources on the internet saying that NetworkManager also listen to UPower events.

Ken Sharp (kennybobs)
description: updated
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.