xfs handling on battery not working correctly

Bug #645974 reported by Andre D on 2010-09-23
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Won't Fix
pm-utils (Ubuntu)
Bryce Harrington

Bug Description

Binary package hint: pm-utils

The file /usr/lib/pm-utils/power.d/xfs_buffer has a typo, preventing /proc/sys/fs/xfs/xfssyncd_centisecs and xfsbufd_centisecs from being updated correctly when on battery power.

Currently, it has a function like this:

xfs_battery() {
    state_exists xfs_buffer_default || \
        read_values |savestate xfs_buffer_default
    write_values "$XFS_AGE_BUFFER" "$XFS_BUFD" "$XFS_SYNCD"

Whereas it should be:

xfs_battery() {
    state_exists xfs_buffer_default || \
        read_values |savestate xfs_buffer_default
    write_values "$XFS_AGE_BUFFER" "$XFS_SYNCD" "$XFS_BUFD"

Patch is attached.

This is on maverick beta with latest updates (pm-utils 1.4.1-2)

Related branches

Andre D (ad-andred) wrote :
Bryce Harrington (bryce) on 2011-11-08
Changed in pm-utils (Ubuntu):
status: New → Triaged
importance: Undecided → Low
assignee: nobody → Bryce Harrington (bryce)
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pm-utils - 1.4.1-8ubuntu2

pm-utils (1.4.1-8ubuntu2) precise; urgency=low

  * Add 91-xfs-buffer.patch: Use correct argument order when setting
    XFS bufd and syncd while on battery. (Thanks to Andre D)
    (LP: #645974)
 -- Bryce Harrington <email address hidden> Mon, 07 Nov 2011 18:34:40 -0800

Changed in pm-utils (Ubuntu):
status: Triaged → Fix Released


xfsfiles="age_buffer_centisecs xfssyncd_centisecs xfsbufd_centisecs"
    write_values "$XFS_AGE_BUFFER" "$XFS_BUFD" "$XFS_SYNCD"

That call writes the values the wrong way around.

Created attachment 55377
pm/power.d/xfs_buffer: Fix wrong argument ordering

Patch originally created by Andre Draszik in https://bugs.launchpad.net/pm-utils/+bug/645974.

Changed in pm-utils:
importance: Unknown → Medium
status: Unknown → Confirmed

pm-utils hasn't been touched in eight years, none of this is likely to get addressed. Closing bugs and disabling the bz product.

Changed in pm-utils:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.