| 2014-07-10 13:06:28 |
Michael Vogt |
description |
On Trusty (beta), while trying to diagnose an issue with the wireless not connecting upon resume from standby, I discovered an invalid check in '/usr/lib/pm-utils/power.d/wireless'. The script checks '/sys/class/net/$1/device/enable' to see if the wireless device is enabled, failing to perform any configuration if this sys file does not exist. That happens to be the case for me (intel wireless), which the actual location is '/sys/class/net/$1/device/enabled' (enable -> enabled).
Changing the script to use the correct location has not fixed my wireless resume issue, but perhaps it is contributing to wireless issues for others. My wireless power-saving is correctly turned off upon resume now, though (it would get stuck in power-saving mode sometimes).
$> lsb_release -rd
Description: Ubuntu Trusty Tahr (development branch)
Release: 14.04
$> apt-cache policy pm-utils
pm-utils:
Installed: 1.4.1-13
Candidate: 1.4.1-13
Version table:
*** 1.4.1-13 0
500 http://us.archive.ubuntu.com/ubuntu/ trusty/main amd64 Packages
100 /var/lib/dpkg/status |
TEST CASE:
- on a machine with a wireless interface, run:
PM_FUNCTIONS=/usr/lib/pm-utils/functions sh -ex /usr/lib/pm-utils/power.d/wireless true
and verify that it fails with /sys/class/net/wlan0/device/enable: No such file or directory
- install the update and run the command again and verify that the script continue beyond the point it stopped earlier, i.e. that it stops at a later point when running e.g. iwconfig
- now powersaving for wireless via pm-utils should work as intended from the script
REGRESSION POTENTIAL:
- the functionality in the script was completely broken before, by fixing this bug any bug in the power management that were previously hidden may now be uncovered.
On Trusty (beta), while trying to diagnose an issue with the wireless not connecting upon resume from standby, I discovered an invalid check in '/usr/lib/pm-utils/power.d/wireless'. The script checks '/sys/class/net/$1/device/enable' to see if the wireless device is enabled, failing to perform any configuration if this sys file does not exist. That happens to be the case for me (intel wireless), which the actual location is '/sys/class/net/$1/device/enabled' (enable -> enabled).
Changing the script to use the correct location has not fixed my wireless resume issue, but perhaps it is contributing to wireless issues for others. My wireless power-saving is correctly turned off upon resume now, though (it would get stuck in power-saving mode sometimes).
$> lsb_release -rd
Description: Ubuntu Trusty Tahr (development branch)
Release: 14.04
$> apt-cache policy pm-utils
pm-utils:
Installed: 1.4.1-13
Candidate: 1.4.1-13
Version table:
*** 1.4.1-13 0
500 http://us.archive.ubuntu.com/ubuntu/ trusty/main amd64 Packages
100 /var/lib/dpkg/status |
|
