plymouth ask-for-password with --number-of-tries gets Assertion `request_node != NULL' failed

[Bartosz Woronicz]

This is similar to https://bugs.launchpad.net/ubuntu/+source/plymouth/+bug/1355617
Seems like plymouth got serious issues with argument parsing in 'ask-for-password' command

You can reproduce like following (possibly start one machine and ssh to it from another to see what is going on)
1. Start plymouth on tty8
# plymouthd --mode=boot --attach-to-session --pid-file=/run/plymouth/pid --tty=/dev/tty8; chvt 8; plymouth --show-splash;

2. Try first without --number-of-tries
$ plymouth ask-for-password --command='/bin/cat' --prompt="This is a password prompt"
works great

3. Now with --number-of-tries
# plymouth ask-for-password --command='/bin/cat' --number-of-tries=3 --prompt="This is a password prompt"
plymouth: ./ply-boot-client.c:272: ply_boot_client_process_incoming_replies: Assertion `request_node != NULL' failed.
Aborted (core dumped)

That's not only this.
4. if you add random incorrect argument it will open dialog but wont't display prompt
# plymouth ask-for-password --XXXX --command='/bin/cat' --prompt="This is a password prompt"

5. But if we add this to the very end the program will crash
# plymouth ask-for-password --command='/bin/cat' --prompt="This is a password prompt" --XXXX
plymouth: ./ply-boot-client.c:272: ply_boot_client_process_incoming_replies: Assertion `request_node != NULL' failed.
Aborted (core dumped)

Plymouth version
Version: 0.9.4git20200323-0ubuntu6.2
Ubuntu 20.04 Focal Fossa LTS

[Daniel van Vugt (vanvugt)]

Maybe related to bug 1810154.

[Bartosz Woronicz (mastier1)]

Might be. However that was fixed in the version preceeeding this one. So either similar bug or reoccurement.