Activity log for bug #1810154

Date Who What changed Old value New value Message
2018-12-31 13:43:03 Andreas Hasenack bug added bug
2019-11-11 23:00:06 Launchpad Janitor plymouth (Ubuntu): status New Confirmed
2019-11-11 23:04:50 Witold Krecicki attachment added cached-password-fix.patch https://bugs.launchpad.net/ubuntu/+source/plymouth/+bug/1810154/+attachment/5304592/+files/cached-password-fix.patch
2019-11-12 00:24:41 Ubuntu Foundations Team Bug Bot tags patch
2019-11-12 00:24:52 Ubuntu Foundations Team Bug Bot bug added subscriber Ubuntu Review Team
2019-11-14 15:31:29 Colin Ian King plymouth (Ubuntu): importance Undecided Medium
2019-12-11 23:28:16 Seth Arnold bug added subscriber Seth Arnold
2019-12-12 12:53:21 Sebastien Bacher bug added subscriber Ubuntu Sponsors Team
2019-12-12 12:53:27 Sebastien Bacher plymouth (Ubuntu): importance Medium High
2019-12-14 19:01:57 Steve Langasek description ubuntu cosmic plymouth 0.9.3-1ubuntu10 initramfs-tools 0.131ubuntu15 I'm trying to get a password prompt working in the initramfs via plymouth, but I get an assertion error. This is the sample command I'm running: plymouth --debug ask-for-password --command=/bin/cat --prompt "Type something" And this is the output I get: [./plymouth.c:463] on_password_request:Password request [ply-event-loop.c:759] ply_event_loop_stop_watching_fd:stopping watching fd 6 [ply-event-loop.c:775] ply_event_loop_stop_watching_fd:removing destination for fd 6 [./plymouth.c:430] on_password_request_execute:executing password request (command /bin/cat) [ply-event-loop.c:759] ply_event_loop_stop_watching_fd:stopping watching fd 6 [ply-event-loop.c:775] ply_event_loop_stop_watching_fd:removing destination for fd 6 [ply-event-loop.c:759] ply_event_loop_stop_watching_fd:stopping watching fd 6 [ply-event-loop.c:775] ply_event_loop_stop_watching_fd:removing destination for fd 6 plymouth: ./ply-boot-client.c:272: ply_boot_client_process_incoming_replies: Assertion `request_node != NULL' failed. Aborted plymouth --ping returns 0. It doesn't matter which --command I try. [SRU Justification] An Ubuntu-specific patch causes a crash in plymouth that does not occur upstream and breaks one of the standard use cases of the plymouth client, to prompt for passwords. While the specific error does not affect password prompting for LUKS due to a different invocation of plymouth, it does break password prompting for ZFS encryption, leaving users at an initramfs prompt on boot. [Test case] 1. Change to VT3 on your system (so that you are not under a graphical login session) and log in. 2. As root, run: plymouthd --mode=boot --attach-to-session --pid-file=/run/plymouth/pid --tty=/dev/tty8; chvt 8; plymouth --show-splash; plymouth ask-for-password --prompt "This is a password prompt" --command="/bin/cat"; plymouth quit; chvt 3 3. Observe that you are immediately returned to VT3 without being shown a password prompt, and the error message "ply_boot_client_process_incoming_replies: Assertion `request_node != NULL' failed" is printed on the console. 4. Install the plymouth package from eoan-proposed. 5. Repeat step 2. 6. Observe that you are shown a password prompt. 7. Type something into the field and hit enter. 8. Observe that you are returned to VT3 and the text you typed in step 7 has been echoed to the screen, with no error messages. [Regression potential] This is an Ubuntu-specific bug due to missing handling of a new upstream message type in an Ubuntu-specific patch. This fixes a crash and has minimal risk of regression. ubuntu cosmic plymouth 0.9.3-1ubuntu10 initramfs-tools 0.131ubuntu15 I'm trying to get a password prompt working in the initramfs via plymouth, but I get an assertion error. This is the sample command I'm running: plymouth --debug ask-for-password --command=/bin/cat --prompt "Type something" And this is the output I get: [./plymouth.c:463] on_password_request:Password request [ply-event-loop.c:759] ply_event_loop_stop_watching_fd:stopping watching fd 6 [ply-event-loop.c:775] ply_event_loop_stop_watching_fd:removing destination for fd 6 [./plymouth.c:430] on_password_request_execute:executing password request (command /bin/cat) [ply-event-loop.c:759] ply_event_loop_stop_watching_fd:stopping watching fd 6 [ply-event-loop.c:775] ply_event_loop_stop_watching_fd:removing destination for fd 6 [ply-event-loop.c:759] ply_event_loop_stop_watching_fd:stopping watching fd 6 [ply-event-loop.c:775] ply_event_loop_stop_watching_fd:removing destination for fd 6 plymouth: ./ply-boot-client.c:272: ply_boot_client_process_incoming_replies: Assertion `request_node != NULL' failed. Aborted plymouth --ping returns 0. It doesn't matter which --command I try.
2019-12-14 19:04:10 Steve Langasek bug added subscriber Steve Langasek
2019-12-14 19:04:16 Steve Langasek plymouth (Ubuntu): assignee Steve Langasek (vorlon)
2019-12-14 22:33:20 Launchpad Janitor plymouth (Ubuntu): status Confirmed Fix Released
2019-12-16 11:22:53 Łukasz Zemczak plymouth (Ubuntu Eoan): status New Fix Committed
2019-12-16 11:22:54 Łukasz Zemczak bug added subscriber Ubuntu Stable Release Updates Team
2019-12-16 11:22:56 Łukasz Zemczak bug added subscriber SRU Verification
2019-12-16 11:22:58 Łukasz Zemczak tags patch patch verification-needed verification-needed-eoan
2019-12-17 20:35:46 Brian Murray bug added subscriber Brian Murray
2019-12-17 20:35:49 Brian Murray tags patch verification-needed verification-needed-eoan patch verification-failed-eoan verification-needed verification-needed-eoan
2019-12-19 06:40:59 Mathew Hodson plymouth (Ubuntu Eoan): importance Undecided High
2019-12-20 05:25:56 Steve Langasek tags patch verification-failed-eoan verification-needed verification-needed-eoan patch verification-needed verification-needed-eoan
2019-12-24 03:35:33 Steve Langasek tags patch verification-needed verification-needed-eoan patch verification-done-eoan
2020-01-08 01:52:23 Chris Halse Rogers removed subscriber Ubuntu Stable Release Updates Team
2020-01-08 01:54:46 Launchpad Janitor plymouth (Ubuntu Eoan): status Fix Committed Fix Released