pidgin-otr produces 3 identical menus in conversation windows

Bug #292311 reported by Joseph Price
26
This bug affects 5 people
Affects Status Importance Assigned to Milestone
pidgin-otr (Ubuntu)
Low
Unassigned

Bug Description

Binary package hint: pidgin-otr

I'm using a fresh install of Ubuntu 8.10
I have pidgin-otr 3.2.0-1 & pidgin 1:2.5.2-0ubuntu1

In conversation windows, by default there is 2 menus in the top row. The first is displayed as 'OTR'. The second displays the status of the conversation using an icon.
The third menu is to the right of the "Smile!" button.

All three of these buttons/menus produce the exact same thing.

I believe that in the pidgin options there should be an option to enable one menu on the toolbar and/or one menu next to "Smile!". I think that only one of these should be enabled by default. Whichever one is enabled, it should show the status of the conversation.

Revision history for this message
goto (gotolaunchpad) wrote :

Yes. So it looks very ugly. And it is untranslated, too.

goto (gotolaunchpad)
Changed in pidgin-otr:
status: New → Confirmed
Revision history for this message
Ted (tedks) wrote :

This bug is still present in 9.10 Karmic.

Daniel T Chen (crimsun)
Changed in pidgin-otr (Ubuntu):
importance: Undecided → Low
Revision history for this message
John Paul Adrian Glaubitz (glaubitz) wrote :

Still present in Lucid as well:

ii pidgin-otr 3.2.0-5 Off-the-Record Messaging plugin for pidgin
ii pidgin 1:2.6.5-2ubuntu1 graphical multi-protocol instant messaging client for X

I suggest simply dropping the two menus in the upper menu bar. The menu on the bottom right (see attached screenshot) should stay unchanged. It fits pretty neatly. I'll check the code if it's easy to patch.

Adrian

Revision history for this message
John Paul Adrian Glaubitz (glaubitz) wrote :

Ok, I checked the code. The menus are enabled in gtk-dialog.c (at least some of them, I have not yet fully understood the code).

The attached patch removes the top menu "OTR".

Note that the menu in the lower right is located in the "Formatting Toolbars". Thus, if we remove the second upper menu in the chat window and the user has disabled the formatting toolbar, there is no way of making any settings to OTR. I therefore suggest of removing the OTR menu in the lower right. I don't see how it fits into the formatting toolbar anyway.

Adrian

Revision history for this message
John Paul Adrian Glaubitz (glaubitz) wrote :

I have also just notified upstream (Ian Goldberg).

Adrian

Revision history for this message
John Paul Adrian Glaubitz (glaubitz) wrote :

Hi,

after contacting upstream I have to say that this issue is not really a bug but a feature. First, the OTR menu in the formatting toolbar can be turned off in the configuration dialog of the plugin. Second, in the menu bar "there's the "OTR"-headed menu representing the currently active conversation in that tab, and then one icon-headed menu for each conversation in the tab."
One can have multiple conversations in one tab, when one friend has multiple entries in the buddy list.

Anyway, please do NOT apply my patch, it breaks the plugin by removing necessary code. However, I will talk with Ian again and find a way with him to improve the layout a bit.

Adrian

tags: added: patch
tags: added: patch-needswork
removed: patch
Revision history for this message
Howard Chu (hyc) wrote :

Take a look at my rewrite of the pidgin-otr plugin, which only uses libpurple. It uses libpurple's native conversation menu support instead of creating 2-3 menus/buttons.

Be sure to read the README, since changing from using pidgin APIs to libpurple has required a lot of other things to change.

Revision history for this message
Howard Chu (hyc) wrote :

Oops. Forgot to paste the URL.

https://gitorious.org/purple-otr

This is also my solution for bug#236780 ...

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments