No notifications for IRC messages

[Erigami]

Binary package hint: pidgin-libnotify

Messages on IRC channels aren't shown as notifications unless the user's nickname is in the body of the message.

It would be nice if messages on IRC channels could (optionally) be shown in a notification.

[Erigami (erigami)]

I have a patch that shows notification for any message in an IRC chat. If there are multiple messages while the notification is visible, then the notification is updated to show the new message.

The behaviour is can be disabled with a flag in the configuration dialog.

The diff is generated against the 0.14 source.

[Adam Guthrie (therigu)]

Could you open an upstream feature request here:

http://sourceforge.net/tracker/?atid=760304&group_id=144907&func=browse

and attach your patch?

[Victor Vargas (kamus)]

I have sent your requirement to upstream tracker for you. Thanks in advance.

[shideneyu (shideneyu)]

It's still not implemented.

On top of that, I got a problem in the compilation, after having patched the "pidgin-libnotify.c" file with the patch :(
Sorry, I don't know what is the markdown here, so I'll paste the compilation error (doing 'make') in raw:

pidgin-libnotify.c: In function ‘action_cb’:
pidgin-libnotify.c:207:6: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘struct NotifyNotification *’ [-Wformat]
pidgin-libnotify.c: In function ‘closed_cb’:
pidgin-libnotify.c:237:5: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘struct NotifyNotification *’ [-Wformat]
pidgin-libnotify.c:237:5: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘gpointer’ [-Wformat]
pidgin-libnotify.c: In function ‘notify’:
pidgin-libnotify.c:317:17: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘gpointer’ [-Wformat]
pidgin-libnotify.c:332:2: error: too many arguments to function ‘notify_notification_new’
In file included from /usr/include/libnotify/notify.h:27:0,
                 from pidgin-libnotify.c:39:
/usr/include/libnotify/notification.h:114:21: note: declared here
pidgin-libnotify.c:335:7: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘gpointer’ [-Wformat]
pidgin-libnotify.c:340:3: warning: passing argument 2 of ‘notify_notification_set_icon_from_pixbuf’ discards ‘const’ qualifier from pointer target type [enabled by default]
In file included from /usr/include/libnotify/notify.h:27:0,
                 from pidgin-libnotify.c:39:
/usr/include/libnotify/notification.h:139:21: note: expected ‘struct GdkPixbuf *’ but argument is of type ‘const struct GdkPixbuf *’
pidgin-libnotify.c:296:17: warning: variable ‘contact’ set but not used [-Wunused-but-set-variable]
pidgin-libnotify.c: In function ‘notify_new_message_cb’:
pidgin-libnotify.c:486:3: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘struct PurpleConversation *’ [-Wformat]
pidgin-libnotify.c:492:3: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘struct PurpleConversation *’ [-Wformat]
make[2]: *** [pidgin-libnotify.lo] Error 1
make[2]: Leaving directory `/home/shideneyu/Desktop/pidgin-libnotify-0.14/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/shideneyu/Desktop/pidgin-libnotify-0.14'
make: *** [all] Error 2