Ubuntu

Possible Bug: php5-fpm does not listen on a socket by default

Reported by Thomas Ward on 2011-12-06
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
php5 (Debian)
Fix Released
Unknown
php5 (Ubuntu)
Wishlist
Thomas Ward

Bug Description

At the last I checked, the php5-fpm default config for the /etc/php5/fpm/pool.d/www.conf file does not have the listener listen on a UNIX socket.

As UNIX sockets are (generally) easier to use with web servers to pass data to the process, I'd suggest having php5-fpm listen on a UNIX socket by default.

***NOTE*** I noticed this last in the version of PHP which is in Natty. I have yet to check the 5.3.8 version in Precise / Debian sid

Clint Byrum (clint-fewbar) wrote :

Great idea.. also found the same request in Debian. Thomas, if you have a patch for this, I'll make sure it gets sponsored into Debian and precise ASAP. Thanks!

Changed in php5 (Ubuntu):
importance: Undecided → Wishlist
status: New → Triaged
tags: added: bitesize
Thomas Ward (teward) wrote :

Unfortunately, I do not know enough about the structure of the PHP upstream code (nor the package) to make such a modification. I am sure someone else will, though.

Changed in php5 (Debian):
status: Unknown → New
Thomas Ward (teward) wrote :

Clint: I'm trying to create the patch now, once I do, I'll upload it to this bug. I'm working off the source package that exists in Precise at the moment, though, but the basics should be the same.

Thomas Ward (teward) wrote :

I am attaching a patch created via quilt that fixes this bug.

Thomas Ward (teward) wrote :

Note that i have just attempted to upload a patch to fix the deb bug that was included in this bug. I do not know the outcome of that upload, nor will I know whether or not the thing is actually accepted.

Once I know anything, i will let you know (I might have accidentally changed the name in the debian patch).

The attachment "PHP-FPM - Use UNIX Sockets Instead of TCP Listener" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Clint Byrum (clint-fewbar) wrote :

Thomas, you've done everything right, and I appreciate your patience.

I want to make sure that the Debian PHP maintainers are on board with this change.. as this isn't something we'd want to have work differently than Debian, even if it is "better".

I've forwarded your patch.. and tagged the bug so hopefully it will get a look soon. I won't necessarily wait for this to land in Debian, as we're up against feature freeze next week, but I do want to see a response at least.

Since we need to wait for a response from Debian, I'm unsubscribing ubuntu-sponsors now. If for some reason I miss their response, please feel free to comment back here and re-subscribe ubuntu-sponsors.

Changed in php5 (Ubuntu):
assignee: nobody → Thomas Ward (EvilPhoenix) (trekcaptainusa-tw)
status: Triaged → In Progress
Ondřej Surý (ondrej) wrote :

Not sure if easier (you need to check permissions, etc.), but I have merged the patch into upcomming PHP 5.4. We haven't shipped php5-fpm to stable yet, so I don't really have to care for backwards compatibility - although I have added records into NEWS file - feel free to cherry-pick.

Changed in php5 (Debian):
status: New → Fix Released
Clint Byrum (clint-fewbar) wrote :

The latest merge from Debian included this. Fix Released in precise.

Changed in php5 (Ubuntu):
status: In Progress → Fix Released
Clint Byrum (clint-fewbar) wrote :

Whoops, this was only fixed in 5.4.0 in debian, so we did not ship it in precise.

Changed in php5 (Ubuntu):
status: Fix Released → Triaged
Thomas Ward (teward) wrote :

According to what I can see, 5.4.4 (which already has this fix) is in Quantal, but the debian/changelog did not reference this LP bug. Should this bug here (which is Wishlist / Triaged) be changed to Wishlist / Fix Released ?

Clint Byrum (clint-fewbar) wrote :

Thanks Thomas, marking Fix Released.

Changed in php5 (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.